Re: [Django] #29713: Add a django check to ensure the LANGUAGE_CODE setting uses the standard language ID format

2018-08-26 Thread Django
#29713: Add a django check to ensure the LANGUAGE_CODE setting uses the standard
language ID format
-+-
 Reporter:  Ian Foote|Owner:  darvid7
 Type:  New feature  |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by darvid7):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e52878bace7b91b73f2eb8dafb51136b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #26001: Make ModelAdmin.search_fields do an integer lookup for IntegerFields

2018-08-26 Thread Django
#26001: Make ModelAdmin.search_fields do an integer lookup for IntegerFields
-+-
 Reporter:  Tim Graham   |Owner:  Nick
 Type:   |  Sandford
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Nick Sandford):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.796568cabc229d55cca5df2179499e1e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #26001: Make ModelAdmin.search_fields do an integer lookup for IntegerFields

2018-08-26 Thread Django
#26001: Make ModelAdmin.search_fields do an integer lookup for IntegerFields
-+-
 Reporter:  Tim Graham   |Owner:  Nick
 Type:   |  Sandford
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Nick Sandford):

 * owner:  nobody => Nick Sandford
 * status:  new => assigned


Comment:

 PR: [https://github.com/django/django/pull/10339]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d3d4d9096474e88f13e9f7e60ff2d56d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

2018-08-26 Thread Django
#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  darvid7
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  2.1
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by darvid7):

 * owner:  nobody => darvid7
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.8e7d2e9113d9fcdaef1e1867d0c1ef15%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #20581: Support DEFERRABLE INITIALLY DEFERRED for UNIQUE constraints

2018-08-26 Thread Django
#20581: Support DEFERRABLE INITIALLY DEFERRED for UNIQUE constraints
-+-
 Reporter:  dmadeley@…   |Owner:  Ian Foote
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  db-indexes   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ian Foote):

 * owner:  nobody => Ian Foote
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/085.a245d245164a9199c6efe910150322aa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29713: Add a django check to ensure the LANGUAGE_CODE setting uses the standard language ID format

2018-08-26 Thread Django
#29713: Add a django check to ensure the LANGUAGE_CODE setting uses the standard
language ID format
-+-
 Reporter:  Ian Foote|Owner:  darvid7
 Type:  New feature  |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by darvid7):

 * status:  new => assigned
 * owner:  nobody => darvid7


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3464a0e537952f609d202f26ef293cb9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #29713: Add a django check to ensure the LANGUAGE_CODE setting uses the standard language ID format

2018-08-26 Thread Django
#29713: Add a django check to ensure the LANGUAGE_CODE setting uses the standard
language ID format
+
   Reporter:  Ian Foote |  Owner:  nobody
   Type:  New feature   | Status:  new
  Component:  Internationalization  |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 The {{{LANGUAGE_CODE}}} should be formatted like {{{en-us}}} not
 {{{en_US}}}. Add a check to detect this error.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.4cf2d853ed417e159b54286eef3987d7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

2018-08-26 Thread Django
#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
+
   Reporter:  Sanyam Khurana|  Owner:  nobody
   Type:  Bug   | Status:  new
  Component:  Internationalization  |Version:  2.1
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 The translations only work when the locale involving  region code is
 generated as this:

 `zh_CN` for Simplified Chinese

 Notice here that the region code should be in capital letters for the
 `django.po` file in the directory to correctly work.

 If we do `makemessages` as

 `python manage.py makemessages -l zh_cn`
 OR
 `python manage.py makemessages -l zh-cn`

 It wouldn't work and no error is produced even after running
 compilemessages, which can leave people baffled for a while.

 I would suggest adding a warning/error messages if the locale is used
 incorrectly. That would certainly be a great help.

 I can make a patch for this as well.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.81474f0a46ace8d045fde1391c5360a8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29667: path converters don't handle spaces well.

2018-08-26 Thread Django
#29667: path converters don't handle spaces well.
-+-
 Reporter:  Keryn Knight |Owner:  Jeff
 Type:  Bug  |   Status:  assigned
Component:  Core (URLs)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  converters path  | Triage Stage:  Accepted
  _route_to_regex|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 I think it would be be best to prohibit whitespace.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.410db0b8690a919dae9cd56ef873d978%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29641: Add support for unique constraints to Meta.constraints

2018-08-26 Thread Django
#29641: Add support for unique constraints to Meta.constraints
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 |  Charette
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ian Foote):

 * cc: Ian Foote (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.984c2bc652f7bfeded2b4aa26ad0fcb6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28919: Add support for Common Table Expression (CTE) queries

2018-08-26 Thread Django
#28919: Add support for Common Table Expression (CTE) queries
-+-
 Reporter:  Daniel Miller|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  QuerySet.extra   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ian Foote):

 * cc: Ian Foote (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3d2e1db0dd912b9ff75e4dfb948aed52%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29703: Deprecate undocumented QuerySetPaginator

2018-08-26 Thread Django
#29703: Deprecate undocumented QuerySetPaginator
-+-
 Reporter:  Nick Pope|Owner:  Nick Pope
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  paginator,   | Triage Stage:
  queryset, deprecation  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jon Dufresne):

 I think having an undocumented alias would only lead to confusion if it
 were used. Removing it better follows the zen of Python "There should be
 one-- and preferably only one --obvious way to do it.".

 +1 for deprecating and removing.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.0f8f040af790c95774677fb0f0eeeab6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29667: path converters don't handle spaces well.

2018-08-26 Thread Django
#29667: path converters don't handle spaces well.
-+-
 Reporter:  Keryn Knight |Owner:  Jeff
 Type:  Bug  |   Status:  assigned
Component:  Core (URLs)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  converters path  | Triage Stage:  Accepted
  _route_to_regex|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tom Forbes):

 * cc: Tom Forbes (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.aa800f119efab2a9973eda5600a50909%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29710: Support simple-style CASE expressions

2018-08-26 Thread Django
#29710: Support simple-style CASE expressions
-+-
 Reporter:  Tom Forbes   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * cc: felixxm (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.77c780470d6774007db9130df0f24fd0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29710: Support simple-style CASE expressions

2018-08-26 Thread Django
#29710: Support simple-style CASE expressions
-+-
 Reporter:  Tom Forbes   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * type:  Uncategorized => New feature


Comment:

 IMO it will not have a performance impact also on Oracle, that's why I
 don't think it is worth adding this to the Django. Thanks for checking
 this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.9bfa29df961b0416636086f56d4a8f8a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29667: path converters don't handle spaces well.

2018-08-26 Thread Django
#29667: path converters don't handle spaces well.
-+-
 Reporter:  Keryn Knight |Owner:  Jeff
 Type:  Bug  |   Status:  assigned
Component:  Core (URLs)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  converters path  | Triage Stage:  Accepted
  _route_to_regex|
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tom Forbes):

 I ran into this recently and ended up diagnosing the failure so I really
 hope you do not mind me jumping in and offering a PR Jeff. The path
 parameter regex was just a bit too strict about parsing spaces, and so
 ended up ignoring the pattern entirely

 PR: https://github.com/django/django/pull/10336

 I believe this fixes the issue but I'm not sure how much we want to
 document this. Should we raise a check failure?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1bcfaea3983ef92bbbc26031a4b30062%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29069: Static file serving does not call request_finished signal

2018-08-26 Thread Django
#29069: Static file serving does not call request_finished signal
-+-
 Reporter:  André Cruz   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  HTTP handling|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  streamingresponse| Triage Stage:  Accepted
  request_finished   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tom Forbes):

 On the PR Tim suggested:

 > Maybe it's possible to makes sense to omit the request_started signal
 for static files (if possible)?

 I do not believe it is, not without breaking a lot of our lovely
 abstractions. We could maybe fix it hackily for *just* for `staticfiles`,
 but the problem persists for *any* arbitrary `FileResponse`

 One potential thing I thought of is to wrap the `'wsgi.file_wrapper'` in a
 custom wrapper, which then calls `close()` on the request. But the
 problems would be similar to solution #1 above, and it would break any
 `isinstance()` checks that wsgi servers may perform.

 All in all I'm a bit stumped. This seems to be a deficiency with the wsgi
 spec more than anything

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.1244060fa8ea76a9b0c405b2697e894e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29069: Static file serving does not call request_finished signal

2018-08-26 Thread Django
#29069: Static file serving does not call request_finished signal
-+-
 Reporter:  André Cruz   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  HTTP handling|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:  streamingresponse| Triage Stage:  Accepted
  request_finished   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tom Forbes):

 I had another experiment today. As far as I can see we can pick only one:

 1. Support `sendfile` and other efficient means of sending static files
 2. Have the response ended signal fire

 The WSGI spec [has a section on
 this](https://www.python.org/dev/peps/pep-0333/#optional-platform-
 specific-file-handling). I'll try and summarize what I have found:

 We must give an iterable to `wsgi.file_wrapper`, which can optionally be a
 file like object. We currently pass the underlying file-like object given
 to the `FileResponse`, which is fine, but when it's `close()` method is
 called (or it finishes iterating) then the `FileResponse.close()` is not
 called. The `wsgi.file_wrapper` can try and detect if the file is a real
 file and if so use more efficient streaming methods.

 If we pass the entire `FileResponse` to `wsgi.file_wrapper` then we do not
 get fast streaming because the response is not an actual file, but the
 `close()` method is called

 If we give the underlying user-controlled value the `FileResponse` is
 given, we may get streaming but will not get the `FileResponse.close()`
 called.

 I can see two ways to hack around this:

 1. Return a mocked instance that wraps the user-supplied value, with a
 `close()` method that calls `FileResponse.close()`. This is tricky because
 it *cannot* have attributes or methods like `filenum()` if the
 *underlying* value does not, because `hasattr()` will be True and things
 will break. The spec gives an example of such a class (grep for `class
 FileWrapper:`), but... there are numerous issues with that.

 2. Somehow inject our own logic into the values `close()` method and pass
 that to `wsgi.wrapper`...

 {{{
 old_close = value.close
 function fake_close(*args, **kwargs):
 old_close(*args, **kwargs)
 our_response.close()   # send signals
 value.close = fake_close
 }}}

 I don't think either is nice.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2fea4eb61e5a2101a67c2c559cec6ad6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29710: Support simple-style CASE expressions

2018-08-26 Thread Django
#29710: Support simple-style CASE expressions
-+-
 Reporter:  Tom Forbes   |Owner:  nobody
 Type:  Uncategorized|   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tom Forbes):

 I did some benchmarking on MySQL and Postgres, and it seems the difference
 between the two is negligible. This might not hold for all databases
 however the work to add this might not be worth it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.7b9f833d31b2abe9683886eef5f9bfb1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.