Re: [Django] #30006: Wrong UUID serialization in inline admin when used as a 1to1Field primary key of a UUID primary key.

2018-12-03 Thread Django
#30006: Wrong UUID serialization in inline admin when used as a 1to1Field 
primary
key of a UUID primary key.
---+--
 Reporter:  Gerhut |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Gerhut):

 Found a workaround: add {{{readonly_fields = ('teachers',)}}} to student
 inline works.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f1a0004fee7325e0e3446e162561ae28%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #30006: Wrong UUID serialization in inline admin when used as a 1to1Field primary key of a UUID primary key.

2018-12-03 Thread Django
#30006: Wrong UUID serialization in inline admin when used as a 1to1Field 
primary
key of a UUID primary key.
-+
   Reporter:  Gerhut |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  contrib.admin  |Version:  2.1
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 Sorry for the confusing title, I create a reproducing
 [https://github.com/Gerhut/django-inline-admin-bug repo] on GitHub.

 Key code as follows:

 models.py


 {{{
 class Room(models.Model):
 id = models.UUIDField(default=uuid4, primary_key=True, editable=False)
 name = models.TextField()

 def __str__(self):
 return self.name


 class Teacher(models.Model):
 room = models.OneToOneField(Room, on_delete=models.CASCADE,
 primary_key=True)
 name = models.TextField()

 def __str__(self):
 return self.name


 class Student(models.Model):
 id = models.UUIDField(default=uuid4, primary_key=True, editable=False)
 teacher = models.ForeignKey(Teacher, on_delete=models.CASCADE)
 name = models.TextField()

 def __str__(self):
 return self.name
 }}}

 admin.py
 {{{
 from .models import Room, Teacher, Student


 @admin.register(Room)
 class RoomAdmin(admin.ModelAdmin):
 pass


 @admin.register(Teacher)
 class TeacherAdmin(admin.ModelAdmin):
 class StudentInline(admin.TabularInline):
 model = Student

 inlines = [StudentInline]
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.211ad9b532f163fef0e62730191fcc95%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #30005: Example in documentation of transaction.atomic uses both decorator and context manager

2018-12-03 Thread Django
#30005: Example in documentation of transaction.atomic uses both decorator and
context manager
---+--
 Reporter:  Peter Hull |Owner:  Peter Hull
 Type:  Bug|   Status:  assigned
Component:  Documentation  |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by Peter Hull):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/10717 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c39194e72b4503eb8567c59e938cf95c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #30005: Example in documentation of transaction.atomic uses both decorator and context manager

2018-12-03 Thread Django
#30005: Example in documentation of transaction.atomic uses both decorator and
context manager
---+--
 Reporter:  Peter Hull |Owner:  Peter Hull
 Type:  Bug|   Status:  assigned
Component:  Documentation  |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by Peter Hull):

 * owner:  nobody => Peter Hull
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.c9f8fb7367e369893c4357ad49095a4e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29895: Adjust atomic DDL documentation to avoid ambiguity with MySQL 8+ notion of atomic DDL.

2018-12-03 Thread Django
#29895: Adjust atomic DDL documentation to avoid ambiguity with MySQL 8+ notion 
of
atomic DDL.
--+
 Reporter:  Nathan Klug   |Owner:  Rodrigo
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  2.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Description changed by Rodrigo:

Old description:

> I noticed that Django's documentation says "The atomic attribute doesn’t
> have an effect on databases that don’t support DDL transactions (e.g.
> MySQL, Oracle)." here: https://docs.djangoproject.com/en/2.1/howto
> /writing-migrations/#non-atomic-migrations
>
> I noticed that MySQL 8 adds support for atomic DDL statements though
> (https://dev.mysql.com/doc/refman/8.0/en/atomic-ddl.html). Is this
> something that Django supports when using MySQL 8 and the documentation
> is imprecise (if so, consider this a bug report to clarify
> documentation)? or is this not yet supported (if so, consider this a
> feature request)? Thanks!
>
> https://github.com/math-a3k/django/pull/1

New description:

 I noticed that Django's documentation says "The atomic attribute doesn’t
 have an effect on databases that don’t support DDL transactions (e.g.
 MySQL, Oracle)." here: https://docs.djangoproject.com/en/2.1/howto
 /writing-migrations/#non-atomic-migrations

 I noticed that MySQL 8 adds support for atomic DDL statements though
 (https://dev.mysql.com/doc/refman/8.0/en/atomic-ddl.html). Is this
 something that Django supports when using MySQL 8 and the documentation is
 imprecise (if so, consider this a bug report to clarify documentation)? or
 is this not yet supported (if so, consider this a feature request)?
 Thanks!

 https://github.com/django/django/pull/10718

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f76549c2ec156a7e47b93a5396261f68%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29895: Adjust atomic DDL documentation to avoid ambiguity with MySQL 8+ notion of atomic DDL.

2018-12-03 Thread Django
#29895: Adjust atomic DDL documentation to avoid ambiguity with MySQL 8+ notion 
of
atomic DDL.
--+
 Reporter:  Nathan Klug   |Owner:  Rodrigo
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  2.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Rodrigo):

 * has_patch:  0 => 1


Old description:

> I noticed that Django's documentation says "The atomic attribute doesn’t
> have an effect on databases that don’t support DDL transactions (e.g.
> MySQL, Oracle)." here: https://docs.djangoproject.com/en/2.1/howto
> /writing-migrations/#non-atomic-migrations
>
> I noticed that MySQL 8 adds support for atomic DDL statements though
> (https://dev.mysql.com/doc/refman/8.0/en/atomic-ddl.html). Is this
> something that Django supports when using MySQL 8 and the documentation
> is imprecise (if so, consider this a bug report to clarify
> documentation)? or is this not yet supported (if so, consider this a
> feature request)? Thanks!

New description:

 I noticed that Django's documentation says "The atomic attribute doesn’t
 have an effect on databases that don’t support DDL transactions (e.g.
 MySQL, Oracle)." here: https://docs.djangoproject.com/en/2.1/howto
 /writing-migrations/#non-atomic-migrations

 I noticed that MySQL 8 adds support for atomic DDL statements though
 (https://dev.mysql.com/doc/refman/8.0/en/atomic-ddl.html). Is this
 something that Django supports when using MySQL 8 and the documentation is
 imprecise (if so, consider this a bug report to clarify documentation)? or
 is this not yet supported (if so, consider this a feature request)?
 Thanks!

 https://github.com/math-a3k/django/pull/1

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5ee81dc2914b6e23b197e8cd5e904b1a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #30005: Example in documentation of transaction.atomic uses both decorator and context manager

2018-12-03 Thread Django
#30005: Example in documentation of transaction.atomic uses both decorator and
context manager
---+
 Reporter:  Peter Hull |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Comment:

 I guess it's a typo in the original commit:
 d7bc4fbc94df6c231d71dffa45cf337ff13512ee.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6ee05358ffb92ffda314decaec0eb33f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #30005: Example in documentation of transaction.atomic uses both decorator and context manager

2018-12-03 Thread Django
#30005: Example in documentation of transaction.atomic uses both decorator and
context manager
-+
   Reporter:  Peter Hull |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Documentation  |Version:  2.1
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+
 In the documentation of transaction.atomic
 (https://docs.djangoproject.com/en/2.1/topics/db/transactions
 /#controlling-transactions-explicitly), the example below the line
 "Wrapping atomic in a try/except block allows for natural handling of
 integrity errors" uses both the decorator and the context manager versions
 of atomic().  This wouldn't necessarily be a problem except that using the
 decorator here causes the example to do exactly what the warning a couple
 paragraphs later says not to do: "Avoid catching exceptions inside
 atomic!"  I suggest that removing the use of the decorator in the example
 would be the most prudent edit?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.cf88be64672fc6fe0c572e1f03ba74f8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29999: Include overriding admin site to tutorial

2018-12-03 Thread Django
#2: Include overriding admin site to tutorial
-+-
 Reporter:  Jan Musílek  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  2.1
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => wontfix


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cdbab54a9ad66301b55cf6cc827a1578%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29895: Adjust atomic DDL documentation to avoid ambiguity with MySQL 8+ notion of atomic DDL.

2018-12-03 Thread Django
#29895: Adjust atomic DDL documentation to avoid ambiguity with MySQL 8+ notion 
of
atomic DDL.
--+
 Reporter:  Nathan Klug   |Owner:  Rodrigo
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Documentation |  Version:  2.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Rodrigo):

 * owner:  nobody => Rodrigo
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ae2d670df5ba7a7170e01391cf8f6e8d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29999: Include overriding admin site to tutorial

2018-12-03 Thread Django
#2: Include overriding admin site to tutorial
-+-
 Reporter:  Jan Musílek  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Rodrigo):

 I agree with Tim, overriding the admin site seems out of the scope of an
 introductory tutorial to me. If mentioned, I think it should be with
 something like "In an actual project, if you need to heavily customize the
 admin, it can be entirely overriden with...", not as a way of changing the
 site header - which is what the site.site_header attr is for

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ffea425bd2f753dcd6d70e36c4e1ee81%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29981: "Please correct the error below." (with no errors displayed) when changing an inline that has a one-to-one relation to the parent that uses to_field

2018-12-03 Thread Django
#29981: "Please correct the error below." (with no errors displayed) when 
changing
an inline that has a one-to-one relation to the parent that uses to_field
---+-
 Reporter:  Bernie |Owner:  Patrik Sletmo
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Patrik Sletmo):

 Thanks Bernie!

 There is currently some code for correctly setting the to_field
 
[https://github.com/django/django/blob/ef87b38ef7b07a5a9b4ee424a04a9811836dee39/django/forms/models.py#L961
 here], but it appears that this only works for foreign key fields when
 they are not also the primary key of the contained model. The code linked
 above was introduced 10 years ago in
 
[https://github.com/django/django/commit/a00be663112bc674f71492717f735b922e42
 this commit] and I'm beginning to wonder if the placement was incorrect
 back then.

 I've tried moving the linked if-statement outside of its surrounding
 block, and this seems to fix the issue while not breaking any existing
 test cases. I'll look through the code a bit more to see if this change
 introduces any issue or if there exist a better way of doing this. If this
 turns out to be a reasonable solution I'll make sure to submit a patch
 tomorrow.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.86d9fce1227c4a97d42e7b9e2768063b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #30004: Document TemporaryUploadedFile potential permission issues

2018-12-03 Thread Django
#30004: Document TemporaryUploadedFile potential permission issues
-+-
 Reporter:  Evgeny Arshinov  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * type:  Uncategorized => Cleanup/optimization


Comment:

 I think you're talking about ef70af77ec53160d5ffa060c1bdf5ed93322d84f
 (#28540). I guess the question is whether or not that documentation should
 be duplicated elsewhere.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9f15117fe4f78ede113f9a5196172079%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28549: Can't defer() fields from super- and sub-class at the same time

2018-12-03 Thread Django
#28549: Can't defer() fields from super- and sub-class at the same time
-+-
 Reporter:  Jeremy Kerr  |Owner:  Jeremy
 |  Kerr
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Chris Lamb):

 Replying to [comment:9 Simon Charette]:
 > Chris, probably because it was never reported as a regression in the
 first place. Can you confirm this was working in a previous version of
 Django?

 Yep. If I understand your question correctly, from:
 https://bugs.debian.org/876816#5:

 > This bug caused significant performance degradation when we upgraded a
 > Django [1.x] application to a new version that relied on model
 inheritance.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5485cda00489c293f3f9eae77d0f503c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


[Django] #30004: Document TemporaryUploadedFile potential permission issues

2018-12-03 Thread Django
#30004: Document TemporaryUploadedFile potential permission issues
---+
   Reporter:  Evgeny Arshinov  |  Owner:  nobody
   Type:  Uncategorized| Status:  new
  Component:  Documentation|Version:  2.1
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+
 Hello,

 As far as I can see, the
 [https://docs.djangoproject.com/en/2.1/topics/http/file-uploads/ File
 Uploads] documentation page does not mention any permission issues.

 What I would like to see is a warning that in absence of explicitly
 configured `FILE_UPLOAD_PERMISSIONS`, the permissions for a file uploaded
 to `FileSystemStorage` might not be consistent depending on whether a
 `MemoryUploadedFile` or a `TemporaryUploadedFile` was used for temporary
 storage of the uploaded data (which, with the default
 FILE_UPLOAD_HANDLERS, in turn depends on the uploaded data size).

 The `tempfile.NamedTemporaryFile` + `os.rename` sequence causes the
 resulting file permissions to be 0o0600 on some systems (I experience it
 here on CentOS 7.4.1708 and Python 3.6.5). In all probability, the
 implementation of Python's built-in `tempfile` module explicitly sets such
 permissions for temporary files due to security considerations.

 I found mentions of this issue [https://github.com/divio/django-
 filer/issues/1031 on GitHub], but did not manage to find any existing bug
 report in Django's bug tracker.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.e26e06aafc670b22a5322630351b21c4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #30000: QuerySet constructed with .union() should raise an exception on unsupported filter() attempt.

2018-12-03 Thread Django
#3: QuerySet constructed with .union() should raise an exception on 
unsupported
filter() attempt.
-+-
 Reporter:  thoha|Owner:  Hasan
 |  Ramezani
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.11
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  queryset union   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Hasan Ramezani):

 * owner:  nobody => Hasan Ramezani
 * status:  new => assigned


Comment:

 should we raise an exception for all `filter()` attempts? or just for
 unsupported one?
 if we should we raise an exception just for unsupported, is there any way
 to find them?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.349166b66d22d5ef12646202db686615%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #20024: QuerySet.exclude() does not work with lists containing a 'None' element.

2018-12-03 Thread Django
#20024: QuerySet.exclude() does not work with lists containing a 'None' element.
-+-
 Reporter:  stillwater.ke@…  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carsten Fuchs):

 * cc: Carsten Fuchs (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/081.942936b23d14611d06d123f9e8476c0c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29973: compilemessages misses ignore option, compiles more than needed

2018-12-03 Thread Django
#29973: compilemessages misses ignore option, compiles more than needed
-+-
 Reporter:  Elger Jonker |Owner:  Ryan
 |  Siemens
 Type:  New feature  |   Status:  assigned
Component:  Core (Management |  Version:  2.1
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  compilemessages, | Triage Stage:
  ignore, translation,   |  Unreviewed
  internationalization   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Ryan Siemens):

 I had initially implemented this to just drop a directory, by name, but I
 think thats actually incorrect.
 Consider a directory structure like so
 {{{
 ./
  |- locale/
  |- foo/
|- locale/
  |- bar/
|- foo/
  |- locale/
 }}}
 With my current patch doing `compilemessages --ignore=foo` would drop
 `./foo` and `./bar/foo` from being searched, but I think it should only
 drop dirs relative to the path. So in this case only `./foo` wouldn't be
 searched. Also I think I it should support globbing similar to
 `makemessages --ignore`. Thoughts or opinions?

 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a71a1d6e34eee071887df7603171ce15%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29930: View only permissions on stacked inline result in error

2018-12-03 Thread Django
#29930: View only permissions on stacked inline result in error
-+-
 Reporter:  Andre Lesa   |Owner:  Carlton
 |  Gibson
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  inlines, view only   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson ):

 In [changeset:"27f5b0aff3442e5c25e84972dff4f5fe1edd4e68" 27f5b0af]:
 {{{
 #!CommitTicketReference repository=""
 revision="27f5b0aff3442e5c25e84972dff4f5fe1edd4e68"
 [2.1.x] Fixed #29930 -- Allowed editing in admin with view-only inlines.

 Co-authored-by: Tim Graham 
 Backport of 8245c99ee6032c2748ba46583d8cab15b2f9438e from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.89ca56c062f82db3f70c2f3ab2eac12d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #28668: Add ON CONFLICT IGNORE support to QuerySet.bulk_create()

2018-12-03 Thread Django
#28668: Add ON CONFLICT IGNORE support to QuerySet.bulk_create()
-+-
 Reporter:  Tom Forbes   |Owner:  Tom
 |  Forbes
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Дилян Палаузов):

 In https://code.djangoproject.com/ticket/28668#comment:24 you offered to
 deviate from this ticket a new one.  Where do i find it?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.59caea1388e2a168a00b3c13706cd10a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29973: compilemessages misses ignore option, compiles more than needed

2018-12-03 Thread Django
#29973: compilemessages misses ignore option, compiles more than needed
-+-
 Reporter:  Elger Jonker |Owner:  Ryan
 |  Siemens
 Type:  New feature  |   Status:  assigned
Component:  Core (Management |  Version:  2.1
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  compilemessages, | Triage Stage:
  ignore, translation,   |  Unreviewed
  internationalization   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Ryan Siemens):

 * type:  Cleanup/optimization => New feature


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a0b26c26a58b716da9fbc03e5f598f4a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29973: compilemessages misses ignore option, compiles more than needed

2018-12-03 Thread Django
#29973: compilemessages misses ignore option, compiles more than needed
-+-
 Reporter:  Elger Jonker |Owner:  Ryan
 Type:   |  Siemens
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  2.1
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  compilemessages, | Triage Stage:
  ignore, translation,   |  Unreviewed
  internationalization   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Ryan Siemens):

 * cc: Ryan Siemens (added)
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.eb7d07ab47784c4aa3ee9db9e2a6ae1b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29973: compilemessages misses ignore option, compiles more than needed

2018-12-03 Thread Django
#29973: compilemessages misses ignore option, compiles more than needed
-+-
 Reporter:  Elger Jonker |Owner:  Ryan
 Type:   |  Siemens
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  2.1
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  compilemessages, | Triage Stage:
  ignore, translation,   |  Unreviewed
  internationalization   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Ryan Siemens):

 * owner:  (none) => Ryan Siemens
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2247bae68584627bc9ef87e3a39eed44%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29930: View only permissions on stacked inline result in error

2018-12-03 Thread Django
#29930: View only permissions on stacked inline result in error
-+-
 Reporter:  Andre Lesa   |Owner:  Carlton
 |  Gibson
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.1
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  inlines, view only   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8245c99ee6032c2748ba46583d8cab15b2f9438e" 8245c99e]:
 {{{
 #!CommitTicketReference repository=""
 revision="8245c99ee6032c2748ba46583d8cab15b2f9438e"
 Fixed #29930 -- Allowed editing in admin with view-only inlines.

 Co-authored-by: Tim Graham 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ef74fb4088430eb16f8c618d21799471%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29973: compilemessages misses ignore option, compiles more than needed

2018-12-03 Thread Django
#29973: compilemessages misses ignore option, compiles more than needed
-+-
 Reporter:  Elger Jonker |Owner:  (none)
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Management |  Version:  2.1
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  compilemessages, | Triage Stage:
  ignore, translation,   |  Unreviewed
  internationalization   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Manu Pascual):

 * status:  assigned => new
 * owner:  Manu Pascual => (none)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.75227e11e2261d6aa7202ed56972d523%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29973: compilemessages misses ignore option, compiles more than needed

2018-12-03 Thread Django
#29973: compilemessages misses ignore option, compiles more than needed
-+-
 Reporter:  Elger Jonker |Owner:  Manu
 Type:   |  Pascual
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Management |  Version:  2.1
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:  compilemessages, | Triage Stage:
  ignore, translation,   |  Unreviewed
  internationalization   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Manu Pascual):

 Of course, I would have liked to do it this last weekend, but I was sick.
 So all your sir.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.04defb5e345f39d46146810094de3275%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #20098: Add validation for models with the same db_table

2018-12-03 Thread Django
#20098: Add validation for models with the same db_table
-+-
 Reporter:  carsten.klein@…  |Owner:  Sanyam
 |  Khurana
 Type:  New feature  |   Status:  assigned
Component:  Core (System |  Version:  master
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 Not sure if it's worth adding a co-author given the final patch is quite
 different from the original one here.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/087.f10059df6cbb2633acef2a6c9d94c2ce%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29999: Include overriding admin site to tutorial

2018-12-03 Thread Django
#2: Include overriding admin site to tutorial
-+-
 Reporter:  Jan Musílek  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Jan Musílek):

 Replying to [comment:1 Tim Graham]:
 > I don't see overriding the admin site as a necessary requirement.
 `site.site_header = '...'` still works fine.
 Sure, it isn't necessary, I just see it as a new obvious way how to
 customize admin site in broader context. Is it the recommended way? I
 thought it might, which is why I proposed this change in the first place.
 Would it be better if we changed **and** to **or**?

 * We use this approach to teach you how to override templates. In an
 actual project, you would probably
 [https://docs.djangoproject.com/en/2.1/ref/contrib/admin/#overriding-
 default-admin-site override the default admin site] **or** use
 
[https://docs.djangoproject.com/en/2.1/ref/contrib/admin/#django.contrib.admin.AdminSite.site_header
 django.contrib.admin.AdminSite.site_header] attribute to more easily make
 this particular customization.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.33757eb460ec905db242556fa9f3fb3a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #29970: Using cached_property on a model fails with: "Cannot use cached_property instance without calling __set_name__() on it."

2018-12-03 Thread Django
#29970: Using cached_property on a model fails with: "Cannot use cached_property
instance without calling __set_name__() on it."
-+-
 Reporter:  Collin Anderson  |Owner:  Sergey
 |  Fedoseev
 Type:  Bug  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Just noting, this is a Release Blocker for 2.2 (first release including
 06076999026091cf007d8ea69146340a361259f8, fix from #29478).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.7c747b547a09dd003a29e47df00adb65%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.