Re: [Django] #30158: Subquery Expressions Incorrectly Added to Group by

[Django]

#30158: Subquery Expressions Incorrectly Added to Group by
-+-
 Reporter:  Jonny Fuller |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  subquery, group_by   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * type:  Bug => Cleanup/optimization


Comment:

 Jonny, by playing a bit with the code I noticed that it's a bit more
 complex than simply returning an empty list in
 `Subquery.get_group_by_cols`.

 Can you confirm that both queries were returning the appropriate results
 but that the one where subqueries were added to the `GROUP BY` was
 performing significantly slower?

 If that's the case then this is more of an optimization problem where
 subqueries can sometimes be removed from the `GROUP BY` and sometimes not
 but not in all cases.

 e.g.

 {{{#!python
 Publisher.objects.annotate(
 has_long_books=Exists(
 Book.objects.filter(
 publisher=OuterRef('pk'),
 pages__gt=800,
 ),
 ),
 ).values_list('has_long_books').annotate(
 total=Count('*'),
 )
 }}}

 When there's an explicit grouping by a subquery (or exists) then it must
 be honoured but I believe in other cases it's not.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.c9088e8365e5e5bb3da8b9feaff82a96%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30158: Subquery Expressions Incorrectly Added to Group by

[Django]

#30158: Subquery Expressions Incorrectly Added to Group by
-+-
 Reporter:  Jonny Fuller |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  subquery, group_by   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette):

 This happens to be a bit related to #29542.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.639e6dccd60c8085fdf97428c131743f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30158: Subquery Expressions Incorrectly Added to Group by

[Django]

#30158: Subquery Expressions Incorrectly Added to Group by
-+-
 Reporter:  Jonny Fuller |Owner:  Simon
 |  Charette
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  subquery, group_by   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * owner:  nobody => Simon Charette
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.9e3bd98f4370da415a9d4bfed1adb700%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29975: Password reset emails in combination with click tracking do not work with Intelligent Tracking Prevention on Safari for iOS 12 and macOS Mojave

[Django]

#29975: Password reset emails in combination with click tracking do not work 
with
Intelligent Tracking Prevention on Safari for iOS 12 and macOS Mojave
-+-
 Reporter:  Mat Gadd |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  2.1
 Severity:  Normal   |   Resolution:
 Keywords:  safari, privacy, | Triage Stage:  Accepted
  auth, password reset   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jeff Bowen):

 * cc: Jeff Bowen (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e944858b2db5a1cdb41b8139b480b3f8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30215: `AttributeError: __spec__` on `./manage.py runserver`

[Django]

#30215: `AttributeError: __spec__` on `./manage.py runserver`
-+-
 Reporter:  Flaviu Tamas |Owner:  Florian
 |  Moussous
 Type:  Bug  |   Status:  assigned
Component:  Core (Management |  Version:  2.2
  commands)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Florian Moussous):

 Work available here: https://github.com/shiningfm/django/tree/ticket_30215
 PR submitted: https://github.com/django/django/pull/11029

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3336be4f656bb97f215fe7cd962d6d3d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30215: `AttributeError: __spec__` on `./manage.py runserver`

[Django]

#30215: `AttributeError: __spec__` on `./manage.py runserver`
-+-
 Reporter:  Flaviu Tamas |Owner:  Florian
 |  Moussous
 Type:  Bug  |   Status:  assigned
Component:  Core (Management |  Version:  2.2
  commands)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Florian Moussous):

 * status:  new => assigned
 * owner:  (none) => Florian Moussous


Comment:

 Thanks ^^

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.44d299da9ca722b7ec68a6a52be80f23%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30215: `AttributeError: __spec__` on `./manage.py runserver`

[Django]

#30215: `AttributeError: __spec__` on `./manage.py runserver`
-+-
 Reporter:  Flaviu Tamas |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  2.2
  commands)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by approdriguez):

 Feel free then :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4296ea65967ff8d12b98834ec706b56f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30215: `AttributeError: __spec__` on `./manage.py runserver`

[Django]

#30215: `AttributeError: __spec__` on `./manage.py runserver`
-+-
 Reporter:  Flaviu Tamas |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  2.2
  commands)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by approdriguez):

 * status:  assigned => new
 * owner:  approdriguez => (none)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d4763bca23d9a0e4ee5cc12e8a2b9f6a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30215: `AttributeError: __spec__` on `./manage.py runserver`

[Django]

#30215: `AttributeError: __spec__` on `./manage.py runserver`
-+-
 Reporter:  Flaviu Tamas |Owner:
 |  approdriguez
 Type:  Bug  |   Status:  assigned
Component:  Core (Management |  Version:  2.2
  commands)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Florian Moussous):

 Actually I was wondering if someone already posted a patch somewhere
 because the checkbox "Has patch" is checked... So I did not send the PR
 yet because I don't want to cause a mess ^^
 But if the problem still needs fixing, I'd be glad to do so: I've already
 written the patch and the test to go with it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9e1574549661cbeda334e9c2d3759599%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30215: `AttributeError: __spec__` on `./manage.py runserver`

[Django]

#30215: `AttributeError: __spec__` on `./manage.py runserver`
-+-
 Reporter:  Flaviu Tamas |Owner:
 |  approdriguez
 Type:  Bug  |   Status:  assigned
Component:  Core (Management |  Version:  2.2
  commands)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by approdriguez):

 * status:  new => assigned
 * owner:  nobody => approdriguez


Comment:

 Wops sorry, I did not see the comment, do you still want the issue or can
 I do it? @Florian Moussous

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.53a194373aec58df8838e7c5a27aa677%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30217: Admin form for DateTimeField does should require both fields

[Django]

#30217: Admin form for DateTimeField does should require both fields
-+-
   Reporter:  wKavey |  Owner:  nobody
   Type:  New| Status:  new
  feature|
  Component: |Version:  2.1
  contrib.admin  |   Keywords:  admin field
   Severity:  Normal |  validation
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  1  |
-+-
 The default Admin form for a DateTimeField seems to be a split form, with
 separate inputs for both the Date and Time segments. If one provides a
 Date, but no Time, the form produces a value of 'None' and raises no
 ValidationErrors.

 I would expect at least a ValidationError indicating that one must provide
 both a Date and a Time. There is already one thrown if no values at all
 are provided.

 I would imaging this could involve setting "require_all_fields=True" on
 the SplitDateTimeField, however I am not sure.

 Somewhat related to https://code.djangoproject.com/ticket/9721

 I hit this because I have a custom validation applied in my model's
 clean() method (datetime_1 <= datetime_2). This is also called in my
 model's save() method (self.full_clean()). When, using the admin
 interface, I only specify a Date and no Time, I get an error because one,
 or both, of my datetimes are None.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.d951ebd0881f064d6f434e760695573d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30057: diffsettings leaves out custom default settings

[Django]

#30057: diffsettings leaves out custom default settings
-+-
 Reporter:  orlnub123|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  diffsettings,| Triage Stage:  Accepted
  settings   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"2c0fda7f206f2057df642939e51358944b313483" 2c0fda7f]:
 {{{
 #!CommitTicketReference repository=""
 revision="2c0fda7f206f2057df642939e51358944b313483"
 Refs #30057 -- Added more diffsettings tests.

 The test in 573f44d62fe1e87e2c20a74eba5e20ca9ff0ed85 doesn't act as a
 regression test.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.39b1bdbaef18ac43972040108aaaeade%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30214: Indexes defined on abstract base classes are not propagated to subclasses

[Django]

#30214: Indexes defined on abstract base classes are not propagated to 
subclasses
-+-
 Reporter:  wKavey   |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:  abstract base class  | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => invalid
 * type:  Uncategorized => Bug


Comment:

 Normal Python inheritance rules apply to `Meta` Use:
 {{{
 indexes = CustomBase.Meta.indexes + [
 models.Index(fields=['ip_address'], name='ip_address')
 ]
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4ddd6f65fe656204c1e5c560b22b57c4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:  Accepted
  get_search_results, search_fields  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Johannes Hoppe):

 * type:  New feature => Bug
 * stage:  Someday/Maybe => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.696cdc6b9a87e420a78ef99e4ebc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30215: `AttributeError: __spec__` on `./manage.py runserver`

[Django]

#30215: `AttributeError: __spec__` on `./manage.py runserver`
-+-
 Reporter:  Flaviu Tamas |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  2.2
  commands)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Flaviu Tamas):

 I should have done a better job presenting a reproducible case.

 1. {{{pip install django==2.2b py}}}
 2. {{{django-admin startproject mysite}}}
 3. Add {{{import py}}} to the top of {{{mysite/mysite/urls.py}}}
 4. {{{./manage.py runserver}}} and the error will show up.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2c5a9cf74bd8fe69619b4dff35f645d8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29120: Document that the admin autocomplete requires the change permission of the related model

[Django]

#29120: Document that the admin autocomplete requires the change permission of 
the
related model
-+-
 Reporter:  Rodrigo Pinheiro |Owner:  (none)
  Marques de Araújo  |
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Johannes Hoppe):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 This has actually changed to the new view permission. The change has been
 documented.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.94ac09bd437932346d295d08b3e6ffe4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29138: Add ModelAdmin.autocomplete_fields support for ForeignKeys that use to_field

[Django]

#29138: Add ModelAdmin.autocomplete_fields support for ForeignKeys that use
to_field
---+--
 Reporter:  Jonathan Nye   |Owner:  Johannes Hoppe
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  2.0
 Severity:  Normal |   Resolution:
 Keywords:  autocomplete   | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by Johannes Hoppe):

 * owner:  Constantino Schillebeeckx => Johannes Hoppe


Comment:

 This has been inactive and I stumbled upon a solution while fixing another
 issue, I am assigning this to me.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0330547461721859bc1271d5962d7850%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29010: Allow customizing the autocomplete search results based on the querying model

[Django]

#29010: Allow customizing the autocomplete search results based on the querying
model
-+-
 Reporter:  Muslu Y. |Owner:  Johannes
 |  Hoppe
 Type:  New feature  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  ForeignKey,  | Triage Stage:
  get_search_results, search_fields  |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Johannes Hoppe):

 * owner:  nobody => Johannes Hoppe
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.99afda0966842c164a03bc67cedca2b4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30216: Document BooleanField is no longer blank=True in Django 2.1+

[Django]

#30216: Document BooleanField is no longer blank=True in Django 2.1+
--+
 Reporter:  Ed Morley |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  2.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * type:  Uncategorized => Cleanup/optimization
 * easy:  1 => 0
 * stage:  Unreviewed => Accepted


Comment:

 I'm not sure what the note would say exactly. Is
 "`BooleanField.__init__()` no longer sets `blank=True`." enough? It
 doesn't seem to give much explanation about possible ramifications of the
 change and it's not Django's place to describe how django-rest-framework
 is affected. This behavior isn't documented in `ref/models/fields.txt`,
 and we normally don't include a versionchanged annotation for something
 that's undocumented.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4fb858f83c206f319943d7afe2f157de%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29784: Review and update the external links in the settings reference documentation

[Django]

#29784: Review and update the external links in the settings reference
documentation
-+-
 Reporter:  Ian Foote|Owner:  Darius
 Type:   |  Azimi
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Darius Azimi):

 * owner:  nobody => Darius Azimi
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.aab24bec774fb980154fd6bf5054cebf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29956: Allow formset form widget override for the ORDER field

[Django]

#29956: Allow formset form widget override for the ORDER field
--+--
 Reporter:  Claude Paroz  |Owner:  Hasan Ramezani
 Type:  New feature   |   Status:  assigned
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Hasan Ramezani):

 * needs_better_patch:  1 => 0


Comment:

 I changed the PR based on your suggestion. please check it and let me know
 if something else is required.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3cb6941489e9c654e9fb075381dcdeff%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30216: Document BooleanField is no longer blank=True in Django 2.1+

[Django]

#30216: Document BooleanField is no longer blank=True in Django 2.1+
---+--
 Reporter:  Ed Morley  |Owner:  (none)
 Type:  Uncategorized  |   Status:  new
Component:  Documentation  |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by Darius Azimi):

 * owner:  Darius Azimi => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8c657141aa4847bf94d0617b79b6b8a1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30216: Document BooleanField is no longer blank=True in Django 2.1+

[Django]

#30216: Document BooleanField is no longer blank=True in Django 2.1+
---+
 Reporter:  Ed Morley  |Owner:  Darius Azimi
 Type:  Uncategorized  |   Status:  assigned
Component:  Documentation  |  Version:  2.1
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by Darius Azimi):

 * owner:  nobody => Darius Azimi
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0453f1db41cc14956d1c5029b2d123fd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29444: Allow fields to be part of the RETURNING clause during INSERT

[Django]

#29444: Allow fields to be part of the RETURNING clause during INSERT
-+-
 Reporter:  Johannes Hoppe   |Owner:  Johannes
 Type:   |  Hoppe
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  django, db,  | Triage Stage:  Accepted
  returning, default, model, field   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Johannes Hoppe):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3cd6a4309e1eec3bde668ede89db3fcf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30216: Document BooleanField is no longer blank=True in Django 2.1+

[Django]

#30216: Document BooleanField is no longer blank=True in Django 2.1+
-+
   Reporter:  Ed Morley  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Documentation  |Version:  2.1
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  1
  UI/UX:  0  |
-+
 Hi!

 In Django 2.1, as part of adding `null` support to `BooleanField`, the
 previously implicit/hardcoded `blank=True` of `BooleanField` was removed:
 
https://github.com/django/django/commit/5fa4f40f45fcdbb7e48489ed3039a314b5c961d0
 #diff-bf776a3b8e5dbfac2432015825ef8afeL995

 In one of our projects, we had a model with a `BooleanField` defined like
 so:

 {{{#!python
 class PerformanceAlert(models.Model):
 id = models.AutoField(primary_key=True)
 # ...
 is_regression = models.BooleanField()
 }}}

 The REST API for that model uses django-rest-framework's
 `ModelSerializer`, which generates validation rules based on the model
 properties.

 In Django 2.0, the d-r-f API serializer's `repr()` is:

 {{{#!python
 PerformanceAlertSerializer():
 id = IntegerField(read_only=True)
 # ...
 is_regression = BooleanField(required=False)
 }}}

 But under Django 2.1 this changed to

 {{{#!python
 PerformanceAlertSerializer():
 id = IntegerField(read_only=True)
 # ...
 is_regression = BooleanField()
 }}}


 As such under Django 2.1 API calls that were previously successful then
 failed with `This field is required.`. (It turned out our API is using
 `PUT`s in places it should really be using `PATCH`.)

 We were able to resolve the issue by adjusting
 `PerformanceAlertSerializer` such that it explicitly configures the field
 with `serializers.BooleanField(required=False)`, however it would be great
 to mention this ~breaking change in the Django 2.1 release notes (and also
 as a "changed in" on the `BooleanField` entry on the fields page) -
 particularly since it looks like several other people have hit the same
 issue:
 
https://github.com/django/django/commit/5fa4f40f45fcdbb7e48489ed3039a314b5c961d0#r30206260
 https://code.djangoproject.com/ticket/29921

 If I get a chance I'll open a PR in the next few weeks, but happy for
 someone to beat me to it.

 Many thanks :-)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.4e12fa51cd7ab72669d1a414351351cb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30179: Merging 3 or more media objects can throw unnecessary MediaOrderConflictWarnings

[Django]

#30179: Merging 3 or more media objects can throw unnecessary
MediaOrderConflictWarnings
---+
 Reporter:  Matt Westcott  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Forms  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Johannes Hoppe):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a4e80bd1c310c266db0b65f6ddd31fad%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #24342: Add EnumField model/form fields

[Django]

#24342: Add EnumField model/form fields
-+-
 Reporter:  Thomas Stephenson|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sévastien Fievet):

 * cc: Sévastien Fievet (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.0670991719eb9f73537672ee5caf380b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30215: `AttributeError: __spec__` on `./manage.py runserver`

[Django]

#30215: `AttributeError: __spec__` on `./manage.py runserver`
-+-
 Reporter:  Flaviu Tamas |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  2.2
  commands)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Florian Moussous):

 * cc: Florian Moussous (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.95916628fb7d5beb9e93592805342ffe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30152: MySQL: "Cannot change column 'id': used in a foreign key constraint" when altering pk of model with ForeignKey to self

[Django]

#30152: MySQL: "Cannot change column 'id': used in a foreign key constraint" 
when
altering pk of model with ForeignKey to self
---+
 Reporter:  Carsten Fuchs  |Owner:  Dart
 Type:  Bug|   Status:  assigned
Component:  Migrations |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords:  mysql  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Carsten Fuchs):

 Don't know why I didn't see this earlier, but I can reproduce this with
 even simpler model definitions: the FK to self is not needed, having a
 many2many field is enough:

 {{{
 #!python
 # models.py
 from django.db import models


 class Kostenstelle(models.Model):
 #id = models.AutoField(primary_key=True)
 id = models.IntegerField(primary_key=True, help_text="...")


 class KalenderEintrag(models.Model):
 id  = models.AutoField(primary_key=True)
 kst = models.ManyToManyField(Kostenstelle, blank=True)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d4c0cfd2c0f69a79cb2180531ac58127%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30215: `AttributeError: __spec__` on `./manage.py runserver`

[Django]

#30215: `AttributeError: __spec__` on `./manage.py runserver`
-+-
 Reporter:  flaviut  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  2.2
  commands)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by shiningfm):

 Hello
 Just for my information, I'm new to contributing (never submitted a patch
 yet), and I'm trying to reproduce the bug, just to learn how it works, but
 I can't.
 I checked out the tag 2.2b1, installed requirements in a virtualenv,
 started a new project, and fired ./manage runserver
 What other steps can I take to reproduce the bug?
 (sorry if this not the right place to discuss it)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.725bf45a1573236c794c81ae77b4d121%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.