Re: [Django] #30589: urlize parses email addresses with apostrophes incorrectly. (was: urlize parses email addresses with apostrophes incorrectly)

2019-06-24 Thread Django 
#30589: urlize parses email addresses with apostrophes incorrectly.
--+
 Reporter:  Mark Gregson  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by felixxm):

 * cc: Shai Berger (added)
 * component:  Template system => Documentation
 * version:  1.11 => master
 * easy:  0 => 1
 * type:  Bug => Cleanup/optimization
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report. We excluded quotes in the #24471. It seems that
 only single quotes from the list of allowed special characters are
 affected. I agree that we can clarify this in the documentation, e.g.
 {{{Email addresses cannot contain the single quotes (``'``).}}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7a08f7f0ca12066445725e0748dfaba3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30589: urlize parses email addresses with apostrophes incorrectly

2019-06-24 Thread Django 
#30589: urlize parses email addresses with apostrophes incorrectly
-+--
 Reporter:  Mark Gregson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by Mark Gregson):

 Given the range of characters allowed in the local part of an email
 address is quite extensive and that a quoted local part is also allowed
 (RFC 3696 has a nice summary
 https://tools.ietf.org/html/rfc3696#section-3), I realise that there
 probably need to be some constraints on what range of email addresses
 `urlize` can parse. Potentially then this issue should be resolved by
 additional documentation clarifying those constraints.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e8f99bb04e9e57f520234df7aead04c6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30589: urlize parses email addresses with apostrophes incorrectly

2019-06-24 Thread Django 
#30589: urlize parses email addresses with apostrophes incorrectly
---+
   Reporter:  Mark Gregson |  Owner:  nobody
   Type:  Bug  | Status:  new
  Component:  Template system  |Version:  1.11
   Severity:  Normal   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
  UI/UX:  0|
---+
 In 1.11.21 I've observed that the urlize template tag messes up email
 addresses containing apostrophes in the local part, specifically, it
 excludes any characters before the apostrophe from the link text and href
 attribute.

 A simple example using django.utils.htmls.urlize:
 {{{
 >>> from django.utils.html import urlize
 >>> urlize("o'ne...@example.com")
 u'o\'mailto:ne...@example.com;>ne...@example.com'
 }}}
 I would expect this to return:
 {{{
 u'mailto:o\'ne...@example.com">o\'ne...@example.com'
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.0c250280713d256ca43cfbcf5557d82f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28919: Add support for Common Table Expression (CTE) queries

2019-06-24 Thread Django 
#28919: Add support for Common Table Expression (CTE) queries
-+-
 Reporter:  Daniel Miller|Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  QuerySet.extra   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Javier Buzzi):

 Bump.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.a13886d38bc34117ed5b8235757e482c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30511: Support Identity columns on PostgreSQL.

2019-06-24 Thread Django 
#30511: Support Identity columns on PostgreSQL.
-+-
 Reporter:  Michael Kany |Owner:  Michael
 |  Kany
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgres generated   | Triage Stage:  Accepted
  identity   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 You can check the scope of a really similar change on Oracle
 924a89e135fe54bc7622aa6f03405211e75c06e9.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.4b81aa06cecad25d1b38bb2395be2b44%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30555: Migration files generated do not follow PEP8 E501 rule

2019-06-24 Thread Django 
#30555: Migration files generated do not follow PEP8 E501 rule
-+--
 Reporter:  Aman Sharma  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  2.2
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by felixxm):

 No, if a ticket is `wontfix` then we will close PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.7badcf71fc539e105b3aeb691625c84f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30477: Filtering on reverse ForeignKey relation uses get_db_prep_value from a wrong field.

2019-06-24 Thread Django 
#30477: Filtering on reverse ForeignKey relation uses get_db_prep_value from a
wrong field.
-+-
 Reporter:  Michal Petrucha  |Owner:  Can
 |  Sarıgöl
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Can Sarıgöl):

 * owner:  nobody => Can Sarıgöl
 * status:  new => assigned
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/11510 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4b707b0bcf3e21f09243c3f664fb2553%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20535: Unnecessary join created for intermediate table between two M2M tables

2019-06-24 Thread Django 
#20535: Unnecessary join created for intermediate table between two M2M tables
-+-
 Reporter:  German M. Bravo  |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Can Sarıgöl):

 * status:  assigned => new
 * needs_better_patch:  0 => 1
 * owner:  Can Sarıgöl => (none)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.54bec0609753ce5e6f9e3a3d44c57dda%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #20535: Unnecessary join created for intermediate table between two M2M tables

2019-06-24 Thread Django 
#20535: Unnecessary join created for intermediate table between two M2M tables
-+-
 Reporter:  German M. Bravo  |Owner:  Can
 |  Sarıgöl
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Can Sarıgöl):

 * status:  new => assigned
 * needs_better_patch:  1 => 0
 * owner:  nobody => Can Sarıgöl


Comment:

 [https://github.com/django/django/pull/11510 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.2d52dbe7a1e67bd1fbb0d98ca0e32c41%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30511: Support Identity columns on PostgreSQL.

2019-06-24 Thread Django 
#30511: Support Identity columns on PostgreSQL.
-+-
 Reporter:  Michael Kany |Owner:  Michael
 |  Kany
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgres generated   | Triage Stage:  Accepted
  identity   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Simon Charette):

 Michael, I haven't look into all the details but I'm confident you'll have
 to at least change the following

 1.
 
https://github.com/django/django/blob/76b993a117b61c41584e95149a67d8a1e9f49dd1/django/db/backends/postgresql/base.py#L74-L75
 (not that you want `bigint GENERATED ...` for `BigAutoField`).
 2. You'll probably have to adjust introspection logic and tests to have
 both `serial` and `int GENERATED ...` map to `AutoField` and do the same
 for the `bigserial` and `BigAutoField`.
 3. You might have to adjust some migration code as I see
 
[https://github.com/django/django/blob/1378d665a1c85897d951f2ca9618b848fdbba2e7/django/db/backends/postgresql/schema.py#L9-L10
 it performs some sequence creation and deletion]. I guess you'll have to
 change the `create_sequence` usage in `_alter_column_type_sql` to use
 `ALTER COLUMN %(column) ADD GENERATED BY DEFAULT AS IDENTITY` on
 PostgreSQL 10+. Note at in this particular case I think we should keep
 dropping the sequence using `DROP SEQUENCE IF EXISTS ... CASCADE` even on
 PostgreSQL 10+ at least for one release after we drop support for
 PostgreSQL < 10 to avoid orphaning sequences during Django and PostgreSQL
 upgrades.

 That should get you started :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.8fa74d06520470f34149c378c2f02802%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30555: Migration files generated do not follow PEP8 E501 rule

2019-06-24 Thread Django 
#30555: Migration files generated do not follow PEP8 E501 rule
-+--
 Reporter:  Aman Sharma  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Migrations   |  Version:  2.2
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

Comment (by Jarek Glowacki):

 Ooh really?

 It's a little inconsistent currently, with how the `dependencies` list
 (from makemigrations) gets nicely newlined, whereas the `replaces` list
 (from squashmigrations) doesn't.

 This has been a little pet peeve of mine for yonks, where `replaces` lists
 are difficult to interact with when doing manual migration tinkering, but
 I never got round to raising a ticket for it..

 Despite this being closed as a wontfix, would a PR still be accepted if
 one were submitted? :D

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.c1e1a9aa1228311a91b226ed06ec5f0f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30427: Descriptors not accessible for inherited models.

2019-06-24 Thread Django 
#30427: Descriptors not accessible for inherited models.
-+-
 Reporter:  Jarek Glowacki   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  inherited| Triage Stage:  Accepted
  descriptor deferred|
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jarek Glowacki):

 * needs_better_patch:  1 => 0


Comment:

 Updated patch to get tests passing.
 The proposed patch addresses the problem presented in this ticket, but
 feels dirty -- there'll be similar problems if users try to define fields
 that clash with method names. But maybe we cross that bridge when we hit
 it.

 FYI, having the `is_attname_settable` field always return True, causes the
 following tests to fail:
 ```
 test_model_check_method_not_shadowed
 (check_framework.tests.CheckFrameworkReservedNamesTests)
 test_property_and_related_field_accessor_clash
 (invalid_models_tests.test_models.OtherModelTests)
 ```
 Interestingly, these tests only ensure checks are firing properly. Nothing
 else seems affected. So I guess if we wanted to, we could tweak those
 checks and get away with always overriding.
 Would you be interested in a competing PR for that, to compare? Would
 involve more decisions being made about whether we just drop the checks
 that no longer work, or try to rejig them.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d5b5371521dc93b912d7230303846b8e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30584: call_command raises ValueError when subparser dest is passed in options. (was: call_command doesn't recognize subparsers for parameter validation)

2019-06-24 Thread Django 
#30584: call_command raises ValueError when subparser dest is passed in options.
-+-
 Reporter:  bill parquet |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  master
  commands)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * cc: Hasan Ramezani (added)
 * stage:  Unreviewed => Accepted
 * version:  2.2 => master


Comment:

 Thanks for the report.

 In Django 1.11 your custom command raises `TypeError: __init__() missing 1
 required positional argument: 'cmd'` which has been fixed in
 dd68b51e1da54267bde4799fa0d9fbd4290eb8b5. I wasn't able to run your
 example in Django < 2.2.

 `call_command('mycommand', 'foo', bar=True)` raises `TypeError: Unknown
 option(s) for mycommand command: bar.` which seems fine for me because you
 added only `--bar` argument, i.e.
 {{{
 >>> management.call_command('mycommand', 'foo', '--bar', '1')
 >>> management.call_command('mycommand', 'foo', '--bar', True)
 }}}
 work as expected.

 IMO there is only issue with validation of `call_command('mycommand',
 subcommand='foo', bar=True)` because it raises
 {{{
 File "django/core/management/__init__.py", line 130, in 
 for opt in parser._actions if opt.required and opt.dest in options
 ValueError: min() arg is an empty sequence
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ec4fdc5ab00053fc65063f7a5318ae9e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26431: translate_url() creates an incorrect URL when optional named groups are missing in the URL pattern

2019-06-24 Thread Django 
#26431: translate_url() creates an incorrect URL when optional named groups are
missing in the URL pattern
---+---
 Reporter:  EugeneM|Owner:  Daniel Rios
 Type:  Bug|   Status:  closed
Component:  Core (URLs)|  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords:  translate_url  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"76b993a117b61c41584e95149a67d8a1e9f49dd1" 76b993a]:
 {{{
 #!CommitTicketReference repository=""
 revision="76b993a117b61c41584e95149a67d8a1e9f49dd1"
 Fixed #26431 -- Prevented django.urls.resolve() from returning missing
 optional parameters.

 Previous behavior was inconsistent with django.urls.reverse() and
 caused that translate_url() created an incorrect URL when an optional
 parameter was missing.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7567fdedccb205572574ba0686667a1d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26431: translate_url() creates an incorrect URL when optional named groups are missing in the URL pattern

2019-06-24 Thread Django 
#26431: translate_url() creates an incorrect URL when optional named groups are
missing in the URL pattern
---+---
 Reporter:  EugeneM|Owner:  Daniel Rios
 Type:  Bug|   Status:  assigned
Component:  Core (URLs)|  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  translate_url  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---

Comment (by Mariusz Felisiak ):

 In [changeset:"d640c71fa35640b4c13107c074be2f52c52ad861" d640c71f]:
 {{{
 #!CommitTicketReference repository=""
 revision="d640c71fa35640b4c13107c074be2f52c52ad861"
 Refs #26431 -- Added tests for resolving URL and translate_url() with
 provided optional parameter.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.b4a3229d26b561c4c645ba856a8be3fc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30588: ipdb breaks the autoreloader. (was: ipdb breaks the autoreloader)

2019-06-24 Thread Django 
#30588: ipdb breaks the autoreloader.
-+--
 Reporter:  Tom Forbes   |Owner:  Tom Forbes
 Type:  Bug  |   Status:  assigned
Component:  Utilities|  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by felixxm):

 * owner:  nobody => Tom Forbes
 * status:  new => assigned
 * component:  Uncategorized => Utilities
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report.

 Regression in b2790f74d4f38c8b297b7c1cef6875d2378f6fa6.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.2d0f41b4980ca802bd6c8af68e9c83d6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30587: Cloaking exceptions raised by get_object_or_404(). (was: Exceptions thrown by 'get_object_or_404()' shortcut method)

2019-06-24 Thread Django 
#30587: Cloaking exceptions raised by get_object_or_404().
-+-
 Reporter:  Ishwar Bhat  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => closed
 * component:  Uncategorized => Database layer (models, ORM)
 * version:  2.2 => master
 * resolution:   => duplicate


Old description:

> When we use get_object_or_404() method to query an object, sometimes due
> to invalid inputs it will through exceptions. Instead can it raise 404
> directly?
> Ex:
>
> Models:
> >>class Test1(models.Model):
> >>c2 = models.CharField(max_length=10)
>
> >>class Test2(models.Model):
> >>c1 = models.UUIDField(primary_key=True, default=uuid.uuid4)
> >>c2 = models.CharField(max_length=10)
>
> query:
> 1. Below statement raises valueError:
> >> get_object_or_404(Test1, pk='test')
> >> - invalid literal for int() with base 10: 'test'
>
> 2. Below statement raises ValidationError:
> >> get_object_or_404(Test2, pk="test")
> >> - 'test' is not a valid UUID.
>
> So this method will throw diffrent exceptions in diffenrent scenario. So
> would it be possible to raise 404 exceptions even if it finds invalid
> values.

New description:

 When we use get_object_or_404() method to query an object, sometimes due
 to invalid inputs it will through exceptions. Instead can it raise 404
 directly?
 Ex:

 Models:
 {{{
 >>class Test1(models.Model):
 >>c2 = models.CharField(max_length=10)

 >>class Test2(models.Model):
 >>c1 = models.UUIDField(primary_key=True, default=uuid.uuid4)
 >>c2 = models.CharField(max_length=10)
 }}}
 query:
 1. Below statement raises valueError:
 {{{
 >> get_object_or_404(Test1, pk='test')
 >> - invalid literal for int() with base 10: 'test'
 }}}
 2. Below statement raises ValidationError:
 {{{
 >> get_object_or_404(Test2, pk="test")
 >> - 'test' is not a valid UUID.
 }}}
 So this method will throw different exceptions in different scenario. So
 would it be possible to raise 404 exceptions even if it finds invalid
 values.

--

Comment:

 Duplicate of #22303.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4fdf4724555b3a78c079ca3eeb0a6a75%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30511: Support Identity columns on PostgreSQL.

2019-06-24 Thread Django 
#30511: Support Identity columns on PostgreSQL.
-+-
 Reporter:  Michael Kany |Owner:  Michael
 |  Kany
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgres generated   | Triage Stage:  Accepted
  identity   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Michael Kany):

 Ok, let's limit this to swapping `serial` to `int GENERATED ...` on pg10+.
 Where should I do that?
 contrib.postgres or db.backends.postgresql.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b18fd3762c0bdddad3d47299288945ce%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27604: Use set_signed_cookie for contrib.messages Cookie storage

2019-06-24 Thread Django 
#27604: Use set_signed_cookie for contrib.messages Cookie storage
-+-
 Reporter:  Anthony King |Owner:  Craig
 Type:   |  Anderson
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.messages |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6dcd326877c18fcd6fe8b4d9ddcc4200%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30451: Add ASGI support to Django.

2019-06-24 Thread Django 
#30451: Add ASGI support to Django.
-+-
 Reporter:  Andrew Godwin|Owner:  Andrew
 |  Godwin
 Type:  New feature  |   Status:  closed
Component:  HTTP handling|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  asgi | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"19895e897c9aa620de7db4dfd2fb19774075b755" 19895e89]:
 {{{
 #!CommitTicketReference repository=""
 revision="19895e897c9aa620de7db4dfd2fb19774075b755"
 Refs #30451 -- Added asgiref to the tests requirements.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.9de219734c60001d85d6ba8819a83742%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.