Re: [Django] #33358: Adding duration field with default <24h raises an error on Oracle.

2021-12-13 Thread Django 
#33358: Adding duration field with default <24h raises an error on Oracle.
-+-
 Reporter:  Marcello Dalponte|Owner:  Marcello
 |  Dalponte
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  3.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
  durationfield,oracle   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.d9a0580aad3b6190c36b410960ddb4b0%40djangoproject.com.

Re: [Django] #33361: Redis cache backend doesn't allow storing bool values

2021-12-13 Thread Django 
#33361: Redis cache backend doesn't allow storing bool values
-+-
 Reporter:  Jeremy Lainé |Owner:  Jeremy
 |  Lainé
 Type:  Bug  |   Status:  closed
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"3b03bce122b0f7336a90e3cc111a717c1a8f3700" 3b03bce1]:
 {{{
 #!CommitTicketReference repository=""
 revision="3b03bce122b0f7336a90e3cc111a717c1a8f3700"
 [4.0.x] Fixed #33361 -- Fixed Redis cache backend crash on booleans.

 Backport of 2f33217ea2cad688040dd6044cdda946c62e5b65 from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fdcaf83e2aca3ebc7381e6afdb014e86%40djangoproject.com.

Re: [Django] #33361: Redis cache backend doesn't allow storing bool values

2021-12-13 Thread Django 
#33361: Redis cache backend doesn't allow storing bool values
-+-
 Reporter:  Jeremy Lainé |Owner:  Jeremy
 |  Lainé
 Type:  Bug  |   Status:  closed
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2f33217ea2cad688040dd6044cdda946c62e5b65" 2f33217]:
 {{{
 #!CommitTicketReference repository=""
 revision="2f33217ea2cad688040dd6044cdda946c62e5b65"
 Fixed #33361 -- Fixed Redis cache backend crash on booleans.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a0f120d4dd9c2958916e6463feb41e58%40djangoproject.com.

Re: [Django] #33361: Redis cache backend doesn't allow storing bool values

2021-12-13 Thread Django 
#33361: Redis cache backend doesn't allow storing bool values
-+-
 Reporter:  Jeremy Lainé |Owner:  Jeremy
 |  Lainé
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"c7902612ca722f25f6e461c82e6d4d5f0c22f16a" c7902612]:
 {{{
 #!CommitTicketReference repository=""
 revision="c7902612ca722f25f6e461c82e6d4d5f0c22f16a"
 Refs #33361 -- Added Added DummyCache.set() test for boolean values.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.698a5225efd8086bee5758c4d17065be%40djangoproject.com.

Re: [Django] #33362: ALLOWED_HOSTS no longer accepts a non-list/tuple iterable.

2021-12-13 Thread Django 
#33362: ALLOWED_HOSTS no longer accepts a non-list/tuple iterable.
+--
 Reporter:  Carlton Gibson  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  HTTP handling   |  Version:  4.0
 Severity:  Normal  |   Resolution:  invalid
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--

Comment (by Carlton Gibson):

 The example is simplified, but I can work around, yes. I do feel we've cut
 out a legitimate use-case with an overly strict test — it demands more
 than we need — but it's not something I want to spend time pushing on now.
 (Not a problem!)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.acd4b23b52105026ca5d59b8c2c0e9e4%40djangoproject.com.

Re: [Django] #33361: Redis cache backend doesn't allow storing bool values

2021-12-13 Thread Django 
#33361: Redis cache backend doesn't allow storing bool values
-+-
 Reporter:  Jeremy Lainé |Owner:  Jeremy
 |  Lainé
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.77fbaa80c528c74798f2debb9f13c592%40djangoproject.com.

[Django] #33363: Don’t load static assets from external servers

2021-12-13 Thread Django 
#33363: Don’t load static assets from external servers
+
   Reporter:  kmohrf|  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  GIS   |Version:  4.0
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Hi,

 I’ve noticed that the `django.contrib.gis` module, specifically:

 *
 
[https://github.com/django/django/blob/main/django/contrib/gis/forms/widgets.py#L84
 forms/widgets.py line 84]
 *
 
[https://github.com/django/django/blob/main/django/contrib/gis/forms/widgets.py#L89
 forms/widgets.py line 89]
 * and
 
[https://github.com/django/django/blob/main/django/contrib/gis/admin/options.py#L64
 admin/options.py line 64]

 loads JavaScript and CSS files from Cloudflare CDN servers. I find this
 very irritating and though
 [https://docs.djangoproject.com/en/4.0/ref/contrib/gis/forms-
 api/#django.contrib.gis.forms.widgets.OpenLayersWidget the documentation
 mentions] that I’m free to override these assets myself I don’t think it’s
 a good default for privacy nor service reliability to use third party
 servers. I’ve noticed this myself because my project’s Content-Security-
 Policy blocks cross origin hosts.

 As far as I can see the sources are all released under the BSD license and
 can probably be shipped along with Django. Is there any reason this hasn’t
 been done and would you care for pull requests that include these
 libraries as part of the static assets shipped with the
 `django.contrib.gis` module?

 Thank you for your time,

 Konrad

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/049.882e8281ccb2a6556dbe839bf386e2c4%40djangoproject.com.

Re: [Django] #33361: Redis cache backend doesn't allow storing bool values

2021-12-13 Thread Django 
#33361: Redis cache backend doesn't allow storing bool values
-+-
 Reporter:  Jeremy Lainé |Owner:  Jeremy
 |  Lainé
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/15191 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.a920ed66e01bcc653c077b1210676ecd%40djangoproject.com.

Re: [Django] #29700: Document ModelAdmin.autocomplete_view() and AutocompleteJsonView (as customisation point).

2021-12-13 Thread Django 
#29700: Document ModelAdmin.autocomplete_view() and AutocompleteJsonView (as
customisation point).
-+-
 Reporter:  David W. Lloyd   |Owner:  Alexandru
 Type:   |  Balan
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by rossettistone):

 Thanks, Mariusz. Was reopening (rather than filing a new ticket) based on
 the above request from Johannes Maron.

 I'll follow the links that you posted and proceed from there.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bf9755d49322a1817dfdd947fc5e18e6%40djangoproject.com.

Re: [Django] #29700: Document ModelAdmin.autocomplete_view() and AutocompleteJsonView (as customisation point).

2021-12-13 Thread Django 
#29700: Document ModelAdmin.autocomplete_view() and AutocompleteJsonView (as
customisation point).
-+-
 Reporter:  David W. Lloyd   |Owner:  Alexandru
 Type:   |  Balan
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 I appreciate you'd like to reopen the ticket, but please
 [https://docs.djangoproject.com/en/stable/internals/contributing/triaging-
 tickets/#closing-tickets follow the triaging guidelines with regards to
 wontfix tickets] and take this to DevelopersMailingList.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9d03bb6e937679fb718c3b2f657baeb0%40djangoproject.com.

Re: [Django] #33350: some view decorators do not work with Django REST framework in Django 4.0

2021-12-13 Thread Django 
#33350: some view decorators do not work with Django REST framework in Django 
4.0
+--
 Reporter:  Terence Honles  |Owner:  Terence Honles
 Type:  Bug |   Status:  new
Component:  HTTP handling   |  Version:  4.0
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Mariusz Felisiak):

 * cc: Tom Christie, Carlton Gibson (added)


Comment:

 Replying to [comment:5 jason]:
 > [https://github.com/encode/django-rest-
 framework/blob/master/rest_framework/request.py#L140 Request] has never
 inherited from `HttpRequest` which has been the source of many issues like
 this even before 4.0. I am experiencing a lot of issues right now
 converting Django method views into DRF class-based views right now
 because all of the decorators keep breaking.

 Sorry, I confused `HttpRequest` with `HttpResponse`. Nevertheless, IMO, if
 DRF is duck typing `HttpRequest` it should be fixed in DRF, e.g. by adding
 `__instancecheck__()`. What do you think Tom? I'm happy to provide a patch
 to DRF.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.7094d9695350bcdf3d7012c5f46ab05e%40djangoproject.com.

Re: [Django] #29700: Document ModelAdmin.autocomplete_view() and AutocompleteJsonView (as customisation point).

2021-12-13 Thread Django 
#29700: Document ModelAdmin.autocomplete_view() and AutocompleteJsonView (as
customisation point).
-+-
 Reporter:  David W. Lloyd   |Owner:  Alexandru
 Type:   |  Balan
  Cleanup/optimization   |   Status:  new
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Someday/Maybe
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by rossettistone):

 * status:  closed => new
 * resolution:  wontfix =>


Comment:

 From what I can tell, removing `ModelAdmin.autocomplete_view` closed a
 pretty clean (if undocumented) option for modifying the label of items
 returned in the autocomplete Admin form. This Stack Overflow post
 illustrates: https://stackoverflow.com/questions/55629887/change-django-
 autocomplete-fields-label

 After some exploration, I haven't found another way to accomplish the same
 thing, i.e. providing a custom label for the admin autocomplete view
 without just overriding the `__str__` method on the model itself (which is
 rather heavy-handed).

 I don't know enough to write docs on this issue myself, but I think that
 documentation of the new pattern (or another way to edit autocomplete form
 labels) would be very helpful.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3bccc93870370b4b32b92edb26fd0e77%40djangoproject.com.

Re: [Django] #33350: some view decorators do not work with Django REST framework in Django 4.0

2021-12-13 Thread Django 
#33350: some view decorators do not work with Django REST framework in Django 
4.0
+--
 Reporter:  Terence Honles  |Owner:  Terence Honles
 Type:  Bug |   Status:  new
Component:  HTTP handling   |  Version:  4.0
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by jason):

 * status:  closed => new
 * resolution:  needsinfo =>


Comment:

 Replying to [comment:4 Mariusz Felisiak]:
 > I don't see how this can be a regression, these decorators use functions
 from [https://docs.djangoproject.com/en/4.0/ref/utils/#module-
 django.utils.cache django.utils.cache] which are documented as accepting
 `HttpResponse` 樂 Also `Response` defined in `django-rest-framework` is a
 subclass of `HttpResponse`.

 [https://github.com/encode/django-rest-
 framework/blob/master/rest_framework/request.py#L140 Response] has never
 inherited from `HttpResponse` which has been the source of many issues
 like this even before 4.0. I am experiencing a lot of issues right now
 converting Django method views into DRF class-based views right now
 because all of the decorators keep breaking.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.cd34bb5f2c94c8629f392445f97e7803%40djangoproject.com.

Re: [Django] #26780: Prefetch objects don't work with slices

2021-12-13 Thread Django 
#26780: Prefetch objects don't work with slices
-+-
 Reporter:  Ludwik Trammer   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  prefetch, slicing| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Arthur):

 Note that the solution above might not be portable to some MySql
 databases, with error

 `1235, "This version of MySQL doesn't yet support 'LIMIT & IN/ALL/ANY/SOME
 subquery'"`

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e71a663088700a595f15e05727b6d912%40djangoproject.com.

Re: [Django] #26780: Prefetch objects don't work with slices

2021-12-13 Thread Django 
#26780: Prefetch objects don't work with slices
-+-
 Reporter:  Ludwik Trammer   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  prefetch, slicing| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Arthur):

 * cc: Arthur (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.4f56dace28c0db0f6464866ec9413404%40djangoproject.com.

Re: [Django] #16406: Allow separate access to matches from urlpatterns and extra_context args

2021-12-13 Thread Django 
#16406: Allow separate access to matches from urlpatterns and extra_context args
-+-
 Reporter:  Florian Apolloner|Owner:  Anvesh
 Type:   |  Mishra
  Cleanup/optimization   |   Status:  assigned
Component:  Core (URLs)  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  resolvers, reverse   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Pedro Schlickmann Mendes):

 Replying to [comment:9 David Smith]:
 Can you give us more details on why the patch no longer applies cleanly?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c167981be13250c29c69e76b0c39e1d2%40djangoproject.com.

Re: [Django] #33338: Document that @never_cache and add_never_cache_headers() set the Expires header.

2021-12-13 Thread Django 
#8: Document that @never_cache and add_never_cache_headers() set the Expires
header.
-+-
 Reporter:  Andy Chosak  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  closed
Component:  Core (Cache system)  |  Version:  3.2
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  cache| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"cc5bbd447bec57165d5bdf062128fdee0df81ee4" cc5bbd44]:
 {{{
 #!CommitTicketReference repository=""
 revision="cc5bbd447bec57165d5bdf062128fdee0df81ee4"
 [4.0.x] Fixed #8 -- Doc'd that never_cache() decorator set Expires
 header.

 Backport of 669dcefc04837c35fc2ec5ce906d84397005965d from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e929cb9054945896676df00602eb7b46%40djangoproject.com.

Re: [Django] #33338: Document that @never_cache and add_never_cache_headers() set the Expires header.

2021-12-13 Thread Django 
#8: Document that @never_cache and add_never_cache_headers() set the Expires
header.
-+-
 Reporter:  Andy Chosak  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  closed
Component:  Core (Cache system)  |  Version:  3.2
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  cache| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"669dcefc04837c35fc2ec5ce906d84397005965d" 669dcefc]:
 {{{
 #!CommitTicketReference repository=""
 revision="669dcefc04837c35fc2ec5ce906d84397005965d"
 Fixed #8 -- Doc'd that never_cache() decorator set Expires header.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.25fba0ba5febd8cf0ebe0bfc03a68edb%40djangoproject.com.

Re: [Django] #33338: Document that @never_cache and add_never_cache_headers() set the Expires header.

2021-12-13 Thread Django 
#8: Document that @never_cache and add_never_cache_headers() set the Expires
header.
-+-
 Reporter:  Andy Chosak  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Cache system)  |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:  cache| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"e61abab6e0d57c333289790496f358bb8ee4c565" e61abab]:
 {{{
 #!CommitTicketReference repository=""
 revision="e61abab6e0d57c333289790496f358bb8ee4c565"
 Refs #8 -- Added never_cache() tests for Expires header.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.3152eeb2dc525f740f46c62d32fc7cae%40djangoproject.com.

Re: [Django] #33362: ALLOWED_HOSTS no longer accepts a non-list/tuple iterable.

2021-12-13 Thread Django 
#33362: ALLOWED_HOSTS no longer accepts a non-list/tuple iterable.
+--
 Reporter:  Carlton Gibson  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  HTTP handling   |  Version:  4.0
 Severity:  Normal  |   Resolution:  invalid
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--

Comment (by Adam Johnson):

 There's nothing complicated about your class there, it can be determined
 at import time right? It only depends on whether DEBUG is True or not.

 You could always make your setting a subclass of `list` and override
 `__iter__` if really required.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.37eddcc633d226ef5a65e9b3f0d4491e%40djangoproject.com.

Re: [Django] #33361: Redis cache backend doesn't allow storing bool values

2021-12-13 Thread Django 
#33361: Redis cache backend doesn't allow storing bool values
-+-
 Reporter:  Jeremy Lainé |Owner:  Jeremy
 |  Lainé
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jeremy Lainé):

 I've submitted a PR which includes a simple unit test on serialization. I
 checked the tests pass by running it locally with a configured Redis
 cache, I'm not sure if CI executes backend-specific tests though.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.1854b643abdb7a9208b776af55704347%40djangoproject.com.

Re: [Django] #28919: Add support for Common Table Expression (CTE) queries

2021-12-13 Thread Django 
#28919: Add support for Common Table Expression (CTE) queries
-+-
 Reporter:  Daniel Miller|Owner:  Moses
 |  Mugisha
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  QuerySet.extra   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Dave Johansen):

 * cc: Dave Johansen (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7bf44d4fd9efb480e2cfe0e60b9655cc%40djangoproject.com.

Re: [Django] #24462: Add a new QuerySet operation to use current results as a subquery

2021-12-13 Thread Django 
#24462: Add a new QuerySet operation to use current results as a subquery
-+-
 Reporter:  trosos   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  distinct order_by| Triage Stage:  Accepted
  subquery   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Dave Johansen):

 * cc: Dave Johansen (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.05b28f812f3a35a7ddb4f8e1d5a50bcb%40djangoproject.com.

Re: [Django] #28333: Filter and subquery for window expressions

2021-12-13 Thread Django 
#28333: Filter and subquery for window expressions
-+-
 Reporter:  Mads Jensen  |Owner:  (none)
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  window orm filter| Triage Stage:  Accepted
  subquery GSoC  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Dave Johansen):

 * cc: Dave Johansen (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.33e2f62a7a6eecac9fb54c31fceb3504%40djangoproject.com.

Re: [Django] #33362: ALLOWED_HOSTS no longer accepts a non-list/tuple iterable.

2021-12-13 Thread Django 
#33362: ALLOWED_HOSTS no longer accepts a non-list/tuple iterable.
+--
 Reporter:  Carlton Gibson  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  HTTP handling   |  Version:  4.0
 Severity:  Normal  |   Resolution:  invalid
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--

Comment (by Carlton Gibson):

 OK, we can say that 
 (It’s worked this way since ≈forever, so it is a change in behaviour, but
 there’ll be another way.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.c9eb9a3adbe86da5175a628df6f6657a%40djangoproject.com.

Re: [Django] #33362: ALLOWED_HOSTS no longer accepts a non-list/tuple iterable.

2021-12-13 Thread Django 
#33362: ALLOWED_HOSTS no longer accepts a non-list/tuple iterable.
+--
 Reporter:  Carlton Gibson  |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  HTTP handling   |  Version:  4.0
 Severity:  Normal  |   Resolution:  invalid
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 It's [https://docs.djangoproject.com/en/4.0/ref/settings/#allowed-hosts
 documented] that `ALLOWED_HOSTS` is ''"a **list** of strings
 representing..."'', it was also discussed in one of
 [https://github.com/django/django/pull/13927#discussion_r566242010 PRs]. I
 wouldn't consider it as a regression, sorry :) I'm of course open to
 discussion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/071.eacdd987f799d0e32dbdaf41aaf67e55%40djangoproject.com.

[Django] #33362: ALLOWED_HOSTS no longer accepts a non-list/tuple iterable.

2021-12-13 Thread Django 
#33362: ALLOWED_HOSTS no longer accepts a non-list/tuple iterable.
--+
   Reporter:  Carlton Gibson  |  Owner:  nobody
   Type:  Bug | Status:  new
  Component:  HTTP handling   |Version:  4.0
   Severity:  Normal  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+
 cdd0b213a825fcfe90ae93dcc554fba8c1e5ff5d added `ALLOWED_HOSTS` to the list
 of `tuple_settings` that are checked to be lists or tuples in
 `Settings.__init__()`.

 This causes a regression with settings such as:


 {{{
 class AllowedHosts:
 """
 An allowed hosts proxy, implementing SOME logic to determine
 ALLOWED_HOSTS.
 """

 DEBUG_ALLOWED_HOSTS = ["localhost", "127.0.0.1", "[::1]"]

 def __iter__(self):
 if settings.DEBUG:
 yield from self.DEBUG_ALLOWED_HOSTS

 yield "domain.com"
 yield "domain.org"
 yield from [
 "other-domain.com",
 "www.other-domain.com",
 ]

 ALLOWED_HOSTS = AllowedHosts()
 }}}

 This works fine before Django 4.0 but raises afterwards:


 {{{
 raise ImproperlyConfigured("The %s setting must be a list or a tuple." %
 setting)
 django.core.exceptions.ImproperlyConfigured: The ALLOWED_HOSTS setting
 must be a list or a tuple.
 }}}

 We could revert cdd0b213a825fcfe90ae93dcc554fba8c1e5ff5d, or else adjust
 the test. I think the force of it is "`iterable()` but not a string"? 樂

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/056.13c1722b4beebfd591eda3becb19ff94%40djangoproject.com.

Re: [Django] #33355: Optimize SQLite backend connection functions

2021-12-13 Thread Django 
#33355: Optimize SQLite backend connection functions
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 Type:   |  Johnson
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"c66ecc556883e569fb328b5d7258b17d660c2266" c66ecc5]:
 {{{
 #!CommitTicketReference repository=""
 revision="c66ecc556883e569fb328b5d7258b17d660c2266"
 Refs #33355 -- Moved Trunc() assertions for invalid arguments and ISO 8601
 week to separate tests.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.9e9d4787452769ac910d6a69c5ef08fb%40djangoproject.com.

Re: [Django] #33355: Optimize SQLite backend connection functions

2021-12-13 Thread Django 
#33355: Optimize SQLite backend connection functions
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 Type:   |  Johnson
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"5111b636d9b63535fa8990142f3b5c756d08c1b6" 5111b63]:
 {{{
 #!CommitTicketReference repository=""
 revision="5111b636d9b63535fa8990142f3b5c756d08c1b6"
 Refs #33355 -- Fixed Trunc() with years < 1000 on SQLite.

 Thanks to Nick Pope for spotting the bug in Code Review.

 Co-Authored-By: Nick Pope 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.56c00926739c91d09e8f81f228f35577%40djangoproject.com.

Re: [Django] #33361: Redis cache backend doesn't allow storing bool values

2021-12-13 Thread Django 
#33361: Redis cache backend doesn't allow storing bool values
-+-
 Reporter:  Jeremy Lainé |Owner:  Jeremy
 |  Lainé
 Type:  Bug  |   Status:  assigned
Component:  Core (Cache system)  |  Version:  4.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak):

 Replying to [comment:2 Jeremy Lainé]:
 > Thanks for the reply and the link to the discussion. I'm assigning
 myself to the ticket as I'd be happy to prepare a patch and corresponding
 test.
 >
 > Regarding the proposed fix, it feels like we're just moving the problem
 as I'd expect similar issues with an user-defined subclasses of `int`.
 Would it be acceptable to do:
 >
 > {{{#!diff
 > diff --git a/django/core/cache/backends/redis.py
 b/django/core/cache/backends/redis.py
 > index 16556b1ded..bbb0e0320d 100644
 > --- a/django/core/cache/backends/redis.py
 > +++ b/django/core/cache/backends/redis.py
 > @@ -11,7 +11,7 @@ from django.utils.module_loading import import_string
 >
 >  class RedisSerializer(PickleSerializer):
 >  def dumps(self, obj):
 > -if isinstance(obj, int):
 > +if type(obj) is int:
 >  return obj
 >  return super().dumps(obj)
 >
 > }}}

 Yes, looks good, a small comment could de helpful.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f7171970a4a57d85a09277807c02e5ea%40djangoproject.com.

Re: [Django] #33355: Optimize SQLite backend connection functions

2021-12-13 Thread Django 
#33355: Optimize SQLite backend connection functions
-+-
 Reporter:  Adam Johnson |Owner:  Adam
 Type:   |  Johnson
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => Adam Johnson
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ce412c4333db5a06dc8282d3223e17a8%40djangoproject.com.

Re: [Django] #33351: path()/re_path() should raise a TypeError when kwargs is not a dict.

2021-12-13 Thread Django 
#33351: path()/re_path() should raise a TypeError when kwargs is not a dict.
-+-
 Reporter:  Keryn Knight |Owner:  Pedro
 Type:   |  Schlickmann Mendes
  Cleanup/optimization   |   Status:  closed
Component:  Core (URLs)  |  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  path _path   | Triage Stage:  Ready for
  URLPattern check   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"75485d16a289c1fc4eb39702c14d2f08f0d8ccce" 75485d16]:
 {{{
 #!CommitTicketReference repository=""
 revision="75485d16a289c1fc4eb39702c14d2f08f0d8ccce"
 Fixed #33351 -- Made path()/re_path() raise TypeError when kwargs argument
 is not a dict.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ae559df9288253d83753df4aa86be434%40djangoproject.com.

Re: [Django] #33338: Document that @never_cache and add_never_cache_headers() set the Expires header.

2021-12-13 Thread Django 
#8: Document that @never_cache and add_never_cache_headers() set the Expires
header.
-+-
 Reporter:  Andy Chosak  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Cache system)  |  Version:  3.2
 Severity:  Normal   |   Resolution:
 Keywords:  cache| Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.544a6af3d7a3790e620296a52ed5140a%40djangoproject.com.