Re: [Django] #28358: LazyObject defines attribute that don't exist on wrapped object

2023-02-10 Thread Django 
#28358: LazyObject defines attribute that don't exist on wrapped object
-+-
 Reporter:  Andrey Fedoseev  |Owner:  Theofilos
 |  Alexiou
 Type:  Bug  |   Status:  closed
Component:  Utilities|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Collin Anderson):

 * cc: Collin Anderson (added)


Comment:

 the `object.__getattribute__(self, name)` workaround mentioned above fixed
 the issue for me running pure-python coverage.

 I made a basic PR but don't plan on pushing it through to the end. I'll
 opt for actually installing coverage rather than running it straight from
 a git checkout but at least wanted to report that the workaround does
 work.

 https://github.com/django/django/pull/16541

 For testing, somehow running a pure-python version of coverage as part of
 continuous integration would show the issue, though ideally you want to
 test both with and without c-speedups.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863e7209cd-02e54cd3-8d87-437c-8ccc-d9899a225102-00%40eu-central-1.amazonses.com.

Re: [Django] #32172: Adapt signals to allow async handlers

2023-02-10 Thread Django 
#32172: Adapt signals to allow async handlers
-+-
 Reporter:  Carlton Gibson   |Owner:
 |  Konstantin Volkov
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  async| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jon Janzen):

 * cc: Jon Janzen (added)


Comment:

 I hope I'm not spamming this ticket, but I posted on the Forum about
 asyncifying the auth app which would involve this ticket so I thought it
 would be a good idea to CC the ticket on this issue:
 https://forum.djangoproject.com/t/asyncifying-django-contrib-auth-and-
 signals-and-maybe-sessions/18770

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863d9f1e86-43f113aa-ae55-4d42-a0f5-7b88a53fc052-00%40eu-central-1.amazonses.com.

Re: [Django] #31920: ASGI/ASYNC SessionMiddleware - SynchronousOnlyOperation exception if request.user is not unwrapped in sync code

2023-02-10 Thread Django 
#31920: ASGI/ASYNC SessionMiddleware - SynchronousOnlyOperation exception if
request.user is not unwrapped in sync code
--+
 Reporter:  Michael Galler|Owner:  lirontb
 Type:  New feature   |   Status:  assigned
Component:  contrib.sessions  |  Version:  3.1
 Severity:  Normal|   Resolution:
 Keywords:  async | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Jon Janzen):

 Should `auser` cache the results of the DB query? AIUI that's how
 `SimpleLazyObject` works right now so it should probably be conistent.

 For myself, I know there are certain codepaths in my personal installation
 that read the equivalent of `request.user` several times during a request.

 If it doesn't need to be cached, I see this as a fairly trivial and I'd be
 happy to do it. But I'll wait for guidance on my question before moving
 forward.

 Also, while I'm commenting here: I posted about a larger issue about
 asyncifying the auth app overall which touches on this ticket if anyone is
 interested in that: https://forum.djangoproject.com/t/asyncifying-django-
 contrib-auth-and-signals-and-maybe-sessions/18770

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863d9df853-333d44bb-5231-4e5f-9bcf-36c226b9455f-00%40eu-central-1.amazonses.com.

Re: [Django] #33548: Use -> operator to implement KeyTransform on SQLite 3.38+

2023-02-10 Thread Django 
#33548: Use -> operator to implement KeyTransform on SQLite 3.38+
-+-
 Reporter:  Sage Abdullah|Owner:
 Type:   |  rajdesai24
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  sqlite jsonfield | Triage Stage:  Accepted
  keytransform   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by rajdesai24):

 I am quite new to this topic but based on what I can understand how about
 we put a simple version check and return the value accordingly
 something like the following which checks the version and returns the
 value accordingly.
 {{{
 if connection.sqlite_version >= '3.38':
 return (
 "(CASE WHEN JSON_TYPE(%s, %%s) IN (%s) "
 "THEN JSON_TYPE(%s, %%s) ELSE (%s ->> %%s) END)"
 ) % (lhs, datatype_values, lhs, lhs), (tuple(params) +
 (json_path,)) * 3

 else:
 return (
 "(CASE WHEN JSON_TYPE(%s, %%s) IN (%s) "
 "THEN JSON_TYPE(%s, %%s) ELSE JSON_EXTRACT(%s, %%s) END)"
 ) % (lhs, datatype_values, lhs, lhs), (tuple(params) +
 (json_path,)) * 3


 }}}
 This might make it redundant but please let me know of any suggestions.
 Till then I will dive deeper

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863d083ebe-9452f15f-9e82-48ff-bc55-3c4d4da5f5a0-00%40eu-central-1.amazonses.com.

Re: [Django] #34140: Format python code blocks in documentation files

2023-02-10 Thread Django 
#34140: Format python code blocks in documentation files
-+-
 Reporter:  Paolo Melchiorre |Owner:  Joseph V
 Type:   |  Zammit
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  format,black,snippet,example   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"b784768eef75afb32f6d2ce7166551a528bce0ec" b784768e]:
 {{{
 #!CommitTicketReference repository=""
 revision="b784768eef75afb32f6d2ce7166551a528bce0ec"
 [4.2.x] Refs #34140 -- Applied rst code-block to non-Python examples.

 Thanks to J.V. Zammit, Paolo Melchiorre, and Mariusz Felisiak for
 reviews.

 Backport of 534ac4829764f317cf2fbc4a18354fcc998c1425 from main.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863cf63406-461a8e16-d96b-40a3-8962-3fc2a44ac81d-00%40eu-central-1.amazonses.com.

Re: [Django] #34140: Format python code blocks in documentation files

2023-02-10 Thread Django 
#34140: Format python code blocks in documentation files
-+-
 Reporter:  Paolo Melchiorre |Owner:  Joseph V
 Type:   |  Zammit
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  format,black,snippet,example   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"534ac4829764f317cf2fbc4a18354fcc998c1425" 534ac482]:
 {{{
 #!CommitTicketReference repository=""
 revision="534ac4829764f317cf2fbc4a18354fcc998c1425"
 Refs #34140 -- Applied rst code-block to non-Python examples.

 Thanks to J.V. Zammit, Paolo Melchiorre, and Mariusz Felisiak for
 reviews.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863cf0bd2d-ee09d309-fc96-41dc-b9de-a1877292415e-00%40eu-central-1.amazonses.com.

Re: [Django] #34221: Plural-Forms in .po files break Django's translation precedence.

2023-02-10 Thread Django 
#34221: Plural-Forms in .po files break Django's translation precedence.
-+-
 Reporter:  Stefano Parmesan |Owner:
 |  rajdesai24
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  4.1
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:  i18n | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by rajdesai24):

 will figure out what can we add to the current patch

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863ce1e8b8-2da3452d-894b-490b-af75-1a8e54236103-00%40eu-central-1.amazonses.com.

Re: [Django] #34221: Plural-Forms in .po files break Django's translation precedence.

2023-02-10 Thread Django 
#34221: Plural-Forms in .po files break Django's translation precedence.
-+-
 Reporter:  Stefano Parmesan |Owner:
 |  rajdesai24
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  4.1
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:  i18n | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by rajdesai24):

 hey Claude, I tested the patch with the test project that Stefano has
 provided but it did not work.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863cdb2623-a8a33cf0-caba-4a5c-8ffa-d8a2051512a2-00%40eu-central-1.amazonses.com.

Re: [Django] #34330: QuerySet of a model having Meta.ordering, returns the sortable field in values_list() and values()

2023-02-10 Thread Django 
#34330: QuerySet of a model having Meta.ordering, returns the sortable field in
values_list() and values()
-+-
 Reporter:  r_valeev |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 As far as I'm aware it's a duplicate of #14357, fixed in Django 3.1+.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863ca6d8f6-8c6a1f90-0a78-4784-97af-c1d6f4b017e5-00%40eu-central-1.amazonses.com.

Re: [Django] #34325: Clarify PercentRank() description.

2023-02-10 Thread Django 
#34325: Clarify PercentRank() description.
-+-
 Reporter:  dennisvang   |Owner:
 Type:   |  dennisvang
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  4.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"4a89aa25c91e520c247aee428782274dcf10ffd0" 4a89aa25]:
 {{{
 #!CommitTicketReference repository=""
 revision="4a89aa25c91e520c247aee428782274dcf10ffd0"
 [4.2.x] Fixed #34325 -- Corrected wording in PercentRank() docs.

 This is consistent with the terminology used for the percent_rank()
 function in SQLite docs and PostgreSQL docs.

 Backport of 7bb741d787ba360a9f0d490db92e22e0d28204ed from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863c82f53f-be3173f9-c829-47a8-b3ad-7693fb840642-00%40eu-central-1.amazonses.com.

Re: [Django] #34325: Clarify PercentRank() description.

2023-02-10 Thread Django 
#34325: Clarify PercentRank() description.
-+-
 Reporter:  dennisvang   |Owner:
 Type:   |  dennisvang
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:  4.1
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7bb741d787ba360a9f0d490db92e22e0d28204ed" 7bb741d7]:
 {{{
 #!CommitTicketReference repository=""
 revision="7bb741d787ba360a9f0d490db92e22e0d28204ed"
 Fixed #34325 -- Corrected wording in PercentRank() docs.

 This is consistent with the terminology used for the percent_rank()
 function in SQLite docs and PostgreSQL docs.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863c82c9c9-f4b0e75c-b4ef-4431-a0a1-1ad2ee4c83e4-00%40eu-central-1.amazonses.com.

Re: [Django] #34330: QuerySet of a model having Meta.ordering, returns the sortable field in values_list() and values()

2023-02-10 Thread Django 
#34330: QuerySet of a model having Meta.ordering, returns the sortable field in
values_list() and values()
-+-
 Reporter:  r_valeev |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by r_valeev):

 * component:  Uncategorized => Database layer (models, ORM)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863c366505-ed2532f7-47fe-4846-acfc-a17145f32333-00%40eu-central-1.amazonses.com.

Re: [Django] #25706: Support CSP default-src 'self' on Django Admin GIS

2023-02-10 Thread Django 
#25706: Support CSP default-src 'self' on Django Admin GIS
-+-
 Reporter:  Thomas Grainger  |Owner:  Claude
 Type:   |  Paroz
  Cleanup/optimization   |   Status:  assigned
Component:  GIS  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  CSP inline   | Triage Stage:  Accepted
  javascript |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Claude Paroz):

 Absolutely, the challenge here is to remove any JS code from
 `contrib/gis/templates/gis/openlayers.html` (and `openlayers-osm.html`),
 which is currently defining the base map layer and instanciating the
 MapWidget (with that layer in initializer options).

 Any suggestion on how to proceed without losing customization capabilities
 is warmly welcome!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863bffb1ac-a8e72b34-9311-4376-974a-fea537f35597-00%40eu-central-1.amazonses.com.

Re: [Django] #34322: ManifestStaticFilesStorage crashes on commented JavaScript import statements

2023-02-10 Thread Django 
#34322: ManifestStaticFilesStorage crashes on commented JavaScript import
statements
-+
 Reporter:  Adam Johnson |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  4.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by Claude Paroz):

 I wouldn't be shocked if we would document that imports in comments are
 currently not supported in  ManifestStaticFilesStorage. Is the situation
 worse than when the import directive wasn't supported at all?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863bf652c3-b92512b0-726a-4458-95e4-ce74394f8ebb-00%40eu-central-1.amazonses.com.

Re: [Django] #34325: Clarify PercentRank() description.

2023-02-10 Thread Django 
#34325: Clarify PercentRank() description.
-+-
 Reporter:  dennisvang   |Owner:
 Type:   |  dennisvang
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  nobody => dennisvang
 * status:  new => assigned
 * has_patch:  0 => 1
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863b72a078-378b4796-131b-4822-a0a6-b65649bf3f55-00%40eu-central-1.amazonses.com.

[Django] #34330: QuerySet of a model having Meta.ordering, returns the sortable field in values_list() and values()

2023-02-10 Thread Django 
#34330: QuerySet of a model having Meta.ordering, returns the sortable field in
values_list() and values()
-+
   Reporter:  r_valeev   |  Owner:  nobody
   Type:  Bug| Status:  new
  Component:  Uncategorized  |Version:  2.2
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 If you pass a Queryset to Subquery(), whose model has Meta.ordering, then
 the fields declared in ordering will be added to the result of values() or
 values_list() imperceptibly, then the error "Subquery returns more than 1
 row" is raised

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863b469caf-bfcb536a-fac3-4e5c-834a-a67798224c10-00%40eu-central-1.amazonses.com.

Re: [Django] #34325: Clarify PercentRank() description.

2023-02-10 Thread Django 
#34325: Clarify PercentRank() description.
--+
 Reporter:  dennisvang|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Documentation |  Version:  4.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by dennisvang):

 Replying to [comment:5 Mariusz Felisiak]:
 > Agreed, "relative rank" is less confusing. Would you like to prepare a
 patch?

 Certainly. Please have a look at
 https://github.com/django/django/pull/16539

 I also replaced "Percent Rank" in the corresponding *table* by "Relative
 Rank," but I'm not sure if that's necessary. An alternative would be to
 use "PercentRank," without the space, to match the name of the function.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863b1c24f8-5eb2ef8f-963f-460b-af14-0f08705799a0-00%40eu-central-1.amazonses.com.

Re: [Django] #34328: Class-based async-only middleware not detected as coroutine in MiddlewareMixin

2023-02-10 Thread Django 
#34328: Class-based async-only middleware not detected as coroutine in
MiddlewareMixin
-+-
 Reporter:  Sergei   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Uncategorized|  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:  middleware async | Triage Stage:
  asyncio MiddlewareMixin|  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Sergei):

 I've been thinking a bit more about it and going through Django code.
 `MiddlewareMixin` checks passed `get_response` callable for being async.
 It may be preferable to use `inspect.isawaitable` on the '''result''' of
 `get_response` (more robust).

 But with this approach I'm unsure how the example from
 [https://docs.djangoproject.com/en/4.1/topics/http/middleware
 /#asynchronous-support the docs] would look:

 {{{
 #!python

 import asyncio
 from django.utils.decorators import sync_and_async_middleware

 @sync_and_async_middleware
 def simple_middleware(get_response):
 # One-time configuration and initialization goes here.
 if asyncio.iscoroutinefunction(get_response):
 async def middleware(request):
 # Do something here!
 response = await get_response(request)
 return response

 else:
 def middleware(request):
 # Do something here!
 response = get_response(request)
 return response

 return middleware
 }}}

 Right now it returns function which is semantically sync or async. With
 `inspect.isawaitable` approach it would be only one function all the time.

 

 Possible alternative: check for `get_response.__call__` attribute and run
 `asgiref.sync.iscoroutinefunction` on it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863b0e387b-af983cf7-0c6a-4a6d-8890-f97cbdfbecc4-00%40eu-central-1.amazonses.com.

Re: [Django] #34250: Duplicate model names in M2M relationship causes RenameModel migration failure

2023-02-10 Thread Django 
#34250: Duplicate model names in M2M relationship causes RenameModel migration
failure
-+
 Reporter:  Zac Miller   |Owner:  Bhuvnesh
 Type:  Bug  |   Status:  assigned
Component:  Migrations   |  Version:  4.1
 Severity:  Normal   |   Resolution:
 Keywords:  RenameModel  | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


Comment:

 Per
 [https://github.com/django/django/pull/16532#pullrequestreview-1292487861
 Simon's comment].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863a98d496-ac974dcb-4fde-463f-af9e-0752311d96a2-00%40eu-central-1.amazonses.com.

Re: [Django] #32813: Display development server address after server bind

2023-02-10 Thread Django 
#32813: Display development server address after server bind
-+-
 Reporter:  fmwviormv|Owner:  Dhanush
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  development server,  | Triage Stage:  Ready for
  automatic port |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"a0623b117c2fc74a4eea46f8adb914182a5670b5" a0623b11]:
 {{{
 #!CommitTicketReference repository=""
 revision="a0623b117c2fc74a4eea46f8adb914182a5670b5"
 [4.2.x] Fixed #32813 -- Made runserver display port after binding.

 Thanks Florian Apolloner for the review.

 Backport of a18d20ca97e6799152c1e0b6f007fde943053dcb from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863a89edd9-2b4468a4-28ea-4888-a42c-6e911e3b4371-00%40eu-central-1.amazonses.com.

Re: [Django] #32813: Display development server address after server bind

2023-02-10 Thread Django 
#32813: Display development server address after server bind
-+-
 Reporter:  fmwviormv|Owner:  Dhanush
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  dev
  commands)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  development server,  | Triage Stage:  Ready for
  automatic port |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a18d20ca97e6799152c1e0b6f007fde943053dcb" a18d20c]:
 {{{
 #!CommitTicketReference repository=""
 revision="a18d20ca97e6799152c1e0b6f007fde943053dcb"
 Fixed #32813 -- Made runserver display port after binding.

 Thanks Florian Apolloner for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863a897afb-cfea0b83-d783-438e-897b-47178a3e9b8f-00%40eu-central-1.amazonses.com.

Re: [Django] #33586: Cannot delete object (A) referenced by another object (B) if said object (A) has a foreign key to a custom user.

2023-02-10 Thread Django 
#33586: Cannot delete object (A) referenced by another object (B) if said object
(A) has a foreign key to a custom user.
---+
 Reporter:  Jeremy Poulin  |Owner:  (none)
 Type:  Bug|   Status:  new
Component:  Migrations |  Version:  4.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by madhuri2):

 Replying to [comment:25 Mariusz Felisiak]:
 > > Is this issue fixed?
 >
 > No.

 okay, may I know how this file **0002_create_sample_objects.py** is
 created during the migration

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701863a6f16f8-72984a95-60e0-4355-adbd-95d91e8deb40-00%40eu-central-1.amazonses.com.