Re: [Django] #10608: Support RequestSite along with Sites.objects.get_current() in contrib

[Django]

#10608: Support RequestSite along with Sites.objects.get_current() in contrib
---+
  Reporter:  hvendelbo | Owner:  nobody
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  1.1   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Comment (by floledermann):

 Btw the bug for the "View on site" issue is #8960 - also still not
 resolved, and much older than this issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10608: Support RequestSite along with Sites.objects.get_current() in contrib

[Django]

#10608: Support RequestSite along with Sites.objects.get_current() in contrib
---+
  Reporter:  hvendelbo | Owner:  nobody
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  1.1   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Changes (by floledermann):

  * version:  1.0 => 1.1

Comment:

 I would classify this as a bug, not a feature. Without using sites the
 "View on site" link is generated in the admin, but fails with an error
 when clicked - isn't that a bug?

 However this should probably be broken down into several bugs dealing with
 each contrib app, then the consequences of this bug could also be
 discussed in more detail. Too late for 1.2 anyway, probably.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10608: Support RequestSite along with Sites.objects.get_current() in contrib

[Django]

#10608: Support RequestSite along with Sites.objects.get_current() in contrib
---+
  Reporter:  hvendelbo | Owner:  nobody
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Changes (by ubernostrum):

  * milestone:  1.2 =>

Comment:

 1.2 is feature-frozen, moving this feature request off the milestone.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10608: Support RequestSite along with Sites.objects.get_current() in contrib

[Django]

#10608: Support RequestSite along with Sites.objects.get_current() in contrib
---+
  Reporter:  hvendelbo | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Comment (by arthurk):

 veena, please see my second patch in #10235. It adds a `get_current`
 method that will return the appropriate object.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10608: Support RequestSite along with Sites.objects.get_current() in contrib

[Django]

#10608: Support RequestSite along with Sites.objects.get_current() in contrib
---+
  Reporter:  hvendelbo | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Comment (by veena):

 The management of the "if statements" in applications will be annoying,
 don't you think?

 Shouldn't there be a Site class not inherited from django.db.models.Model
 but provide API for getting data? Then if site app is installed it can use
 database as a storage for site data. If site app is not installed, it will
 use RequestSite class. Of course, request object is need to be passed.

 It forces not to use construction like "current_site.flatpage_set.all()"
 but "Flatpage.objects.filter(sites=site)" and also "if statements" don't
 need to be used.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10608: Support RequestSite along with Sites.objects.get_current() in contrib

[Django]

#10608: Support RequestSite along with Sites.objects.get_current() in contrib
---+
  Reporter:  hvendelbo | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Comment (by arthurk):

 Even if the request would be in scope, it wouldn't work correctly for some
 methods. For example the FlatPageSitemap method returns
 current_site.flatpage_set.all(). It would result in an error if the Sites
 framework wouldn't be installed, because the Request object doesn't have a
 flatpage_set.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10608: Support RequestSite along with Sites.objects.get_current() in contrib

[Django]

#10608: Support RequestSite along with Sites.objects.get_current() in contrib
---+
  Reporter:  hvendelbo | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Changes (by Alex):

  * needs_better_patch:  0 => 1

Comment:

 There are a number of places where this patch will do nothing more than
 raise a NameError since request isn't in scope.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10608: Support RequestSite along with Sites.objects.get_current() in contrib

[Django]

#10608: Support RequestSite along with Sites.objects.get_current() in contrib
---+
  Reporter:  hvendelbo | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by arikon):

 * cc: arikon (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10608: Support RequestSite along with Sites.objects.get_current() in contrib

[Django]

#10608: Support RequestSite along with Sites.objects.get_current() in contrib
---+
  Reporter:  hvendelbo | Owner:  nobody
Status:  new   | Milestone:  1.2   
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Accepted  | Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by jacob):

  * stage:  Unreviewed => Accepted
  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #10608: Support RequestSite along with Sites.objects.get_current() in contrib

[Django]

#10608: Support RequestSite along with Sites.objects.get_current() in contrib
---+
  Reporter:  hvendelbo | Owner:  nobody
Status:  new   | Milestone:
 Component:  Contrib apps  |   Version:  1.0   
Resolution:|  Keywords:
 Stage:  Unreviewed| Has_patch:  1 
Needs_docs:  0 |   Needs_tests:  0 
Needs_better_patch:  0 |  
---+
Changes (by hvendelbo):

  * needs_better_patch:  => 0
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 In admindocs views there is a similar switch which defaults to
 GenericSite().
 It looks like it can be replaced by the same code that I added in the
 other spots

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #10608: Support RequestSite along with Sites.objects.get_current() in contrib

[Django]

#10608: Support RequestSite along with Sites.objects.get_current() in contrib
--+-
 Reporter:  hvendelbo |   Owner:  nobody
   Status:  new   |   Milestone:
Component:  Contrib apps  | Version:  1.0   
 Keywords:|   Stage:  Unreviewed
Has_patch:  1 |  
--+-
 Most contrib apps assume that the Site model from contrib.sites is used.
 The login function from auth does a test to see if the Site model is
 installed, and otherwise
 resolves the site using django.contrib.sites.models.RequestSite

 This patch duplicates the login function behaviour in
 auth.forms, comments.feeds, contenttypes.views, gis.sitemaps.views,
 sitemaps, and sitemaps.views

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---