Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  George Song  |Owner:  Jonatas
 Type:   |  CD
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  proxy model  | Triage Stage:  Accepted
  app_label  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jonatas CD):

 * has_patch:  0 => 1


Comment:

 Fixed with https://github.com/django/django/pull/7310

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.920ba1e971d14b173c94958984a7c7c2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  George Song  |Owner:  Jonatas
 Type:   |  CD
  Cleanup/optimization   |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  proxy model  | Triage Stage:  Accepted
  app_label  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jonatas CD):

 * owner:  nobody => Jonatas CD
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.f143ce792ed38d0cd2c192fb64bb077f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  George Song  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  proxy model  | Triage Stage:  Accepted
  app_label  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 Sure.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.6bf15f27e405956179ff86205f07d4fb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  George Song  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  proxy model  | Triage Stage:  Accepted
  app_label  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jonatas CD):

 So, I'd say that, for now, it's better to document the current behavior
 and then set to discussion if it's still the expected behavior or not.
 Based on that eventually open or not a new ticket to change that. Correct?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.e0af5ba6bd0a0a5d76b7e1a71d53494e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  gsong|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  proxy model  | Triage Stage:  Accepted
  app_label  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  closed => new
 * has_patch:  1 => 0
 * resolution:  fixed =>


Comment:

 Agreed.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.c6018990f970fd145d07d0a60b8d92df%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  gsong|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  proxy model  | Triage Stage:  Accepted
  app_label  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by tyrion):

 I don't think we fixed this correctly. The doc was indeed wrong about
 inheriting "**any** Meta options", but the 'ordering' and 'get_latest_by'
 meta attributes are still copied to the new model.

 This is why I think this behaviour should be either documented or removed.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.0bfe54ed52c01dd2211977cd2ae34467%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  gsong|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  proxy model  | Triage Stage:  Accepted
  app_label  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"276f760eaa0554d3ea5219e64d23767bc9a2fcdb" 276f760]:
 {{{
 #!CommitTicketReference repository=""
 revision="276f760eaa0554d3ea5219e64d23767bc9a2fcdb"
 [1.7.x] Fixed #11078 -- Removed inaccurate docs about proxy models Meta.

 Backport of bae72bdd2aa93472617ed28fc3d5a01f0920ea6e from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.7048c6799517666e7b61a1fd3f787436%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  gsong|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  proxy model  | Triage Stage:  Accepted
  app_label  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"1e0bf2cab9d8f52ddf564da8851bb1082b0120d1" 1e0bf2c]:
 {{{
 #!CommitTicketReference repository=""
 revision="1e0bf2cab9d8f52ddf564da8851bb1082b0120d1"
 [1.8.x] Fixed #11078 -- Removed inaccurate docs about proxy models Meta.

 Backport of bae72bdd2aa93472617ed28fc3d5a01f0920ea6e from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.a766fbec1e59d133646090ecdff8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  gsong|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  proxy model  | Triage Stage:  Accepted
  app_label  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Marco Santamaria ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"bae72bdd2aa93472617ed28fc3d5a01f0920ea6e" bae72bd]:
 {{{
 #!CommitTicketReference repository=""
 revision="bae72bdd2aa93472617ed28fc3d5a01f0920ea6e"
 Fixed #11078 -- documentation update.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.7d7cf943bdb375df79d94019fe923020%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  gsong|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  proxy model  | Triage Stage:  Accepted
  app_label  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Florian Apolloner ):

 In [changeset:"cc493d3c061e876d56152c9e951effb9f330fcfe" cc493d3c]:
 {{{
 #!CommitTicketReference repository=""
 revision="cc493d3c061e876d56152c9e951effb9f330fcfe"
 Merge pull request #4531 from marco-santamaria/ticket11078

 Fixed #11078 -- documentation update.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.a239a1940112d841a3820a6f1cebaacc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  gsong|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  proxy model  | Triage Stage:  Accepted
  app_label  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by marco-santamaria):

 * has_patch:  0 => 1
 * type:  Bug => Cleanup/optimization


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.00917ca45470e8bc2087326e016c2776%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  gsong|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  proxy model  | Triage Stage:  Accepted
  app_label  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by marco-santamaria):

 Only the 'ordering' and 'get_latest_by' meta attributes get copied in the
 __new__ method of ModelBase.

 Therefore, if a meta attribute is not in ['ordering', 'get_latest_by'], it
 will not be inherited by the Meta class in the proxy model.

 A pull request that removes that statement from the documentation has been
 proposed. See https://github.com/django/django/pull/4531

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.ca2527bf8d7c6319ef6e3a05ebddd9b4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
-+-
 Reporter:  gsong|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  proxy model  |  Needs documentation:  0
  app_label  |  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by aaugustin):

 This still happens after the app-loading refactor.

 I couldn't locate the code that copies the original model's meta
 attributes to the proxy's meta. It looks like it could be
 `Options.setup_proxy` but that method only deals with a few attributes.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.47f79dc0bc78f1f7d2b3e74810df0ec4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #11078: Proxy models do not inherit META.app_label

[Django]

#11078: Proxy models do not inherit META.app_label
--+-
 Reporter:  gsong |   Owner:  nobody
   Status:  new   |   Milestone:
Component:  Database layer (models, ORM)  | Version:  SVN   
 Keywords:  proxy model app_label |   Stage:  Unreviewed
Has_patch:  0 |  
--+-
 According to the [http://docs.djangoproject.com/en/dev/topics/db/models
 /#base-class-restrictions proxy model documentation]:
 "Proxy models inherit any `Meta` options that they don't define from their
 non-abstract model parent (the model they are proxying for)."

 In the case of `app_label`, this is not true.

 {{{
 #!python

 from django.db import models

 class Book(models.Model):
 name = models.CharField(max_length=50)

 class Meta:
 app_label = 'core'

 class Book1(Book):
 class Meta:
 proxy = True

 >>> from django.db import models
 >>> for model in models.get_models(): print model._meta
 ...
 core.book
 proxy.book1
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---