Re: [Django] #22977: No validation error when ForeignKey related_name clashes with manager name.

[Django]

#22977: No validation error when ForeignKey related_name clashes with manager 
name.
-+-
 Reporter:  Russell Keith-Magee  |Owner:  Aman
 Type:   |  Pandey
  Cleanup/optimization   |   Status:  assigned
Component:  Core (System |  Version:  dev
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Aman Pandey):

 * owner:  (none) => Aman Pandey
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070183a7c7fa06-e9b57c7f-fab9-483c-9a87-b929aa0c4a9b-00%40eu-central-1.amazonses.com.

Re: [Django] #22977: No validation error when ForeignKey related_name clashes with manager name.

[Django]

#22977: No validation error when ForeignKey related_name clashes with manager 
name.
--+
 Reporter:  Russell Keith-Magee   |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (System checks)  |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * owner:  Davide Ceretti => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.32f79ea606ecf7bf009f770c3b28dc24%40djangoproject.com.

Re: [Django] #22977: No validation error when ForeignKey related_name clashes with manager name.

[Django]

#22977: No validation error when ForeignKey related_name clashes with manager 
name.
-+-
 Reporter:  russellm |Owner:  davide-
 Type:   |  ceretti
  Cleanup/optimization   |   Status:  assigned
Component:  Core (System |  Version:  master
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by davide-ceretti):

 Given loic's comment at
 https://github.com/django/django/pull/3359#issuecomment-59642918, what
 would be the correct implementation of this validation check? Adding it to
 BaseManager.check method?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ad8e58671b89becfb9ce1b41f1f213e6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22977: No validation error when ForeignKey related_name clashes with manager name.

[Django]

#22977: No validation error when ForeignKey related_name clashes with manager 
name.
-+-
 Reporter:  russellm |Owner:  davide-
 Type:   |  ceretti
  Cleanup/optimization   |   Status:  assigned
Component:  Core (System |  Version:  master
  checks)|
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by davide-ceretti):

 * owner:   => davide-ceretti
 * status:  new => assigned
 * version:  1.6 => master


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d7ed9236faed91fd8413c5a7bbdb40e7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22977: No validation error when ForeignKey related_name clashes with manager name.

[Django]

#22977: No validation error when ForeignKey related_name clashes with manager 
name.
--+
 Reporter:  russellm  |Owner:
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (System checks)  |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by kswiat):

 * owner:  kswiat =>
 * status:  assigned => new


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cd9d68661c6ac460375cfbe1f66802b8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22977: No validation error when ForeignKey related_name clashes with manager name.

[Django]

#22977: No validation error when ForeignKey related_name clashes with manager 
name.
--+
 Reporter:  russellm  |Owner:  kswiat
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (System checks)  |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1


Comment:

 As Loic noted on the PR, we should revisit this after the `_meta` factor
 is merged.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ebea85f3b563143788230ae3b5522a3f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22977: No validation error when ForeignKey related_name clashes with manager name.

[Django]

#22977: No validation error when ForeignKey related_name clashes with manager 
name.
--+
 Reporter:  russellm  |Owner:  kswiat
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (System checks)  |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by kswiat):

 * has_patch:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c2e1ee35c0084bcdc24ac2abe1f43b34%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #22977: No validation error when ForeignKey related_name clashes with manager name.

[Django]

#22977: No validation error when ForeignKey related_name clashes with manager 
name.
--+
 Reporter:  russellm  |Owner:  kswiat
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Core (System checks)  |  Version:  1.6
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by kswiat):

 * status:  new => assigned
 * owner:  nobody => kswiat


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1ef207a46047a4a72d1da2436e81a95f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #22977: No validation error when ForeignKey related_name clashes with manager name.

[Django]

#22977: No validation error when ForeignKey related_name clashes with manager 
name.
+
   Reporter:  russellm  |  Owner:  nobody
   Type:  Cleanup/optimization  | Status:  new
  Component:  Core (System checks)  |Version:  1.6
   Severity:  Normal|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Consider the following model definition:
 {{{
 class Author(models.Model):
 authors = models.Manager()

 name = models.CharField(max_length=100)

 mentor = models.ForeignKey('self', related_name='authors')
 }}}

 The related name on the the foreign key clashes with the manager, so when
 you try to issue a query:
 {{{
 Author.authors.filter(name__startswith='Douglas')
 }}}

 you get an error because "Author.authors has no attribute 'filter'".

 The problem is order dependent; if you define the manager *after* the
 foreign key, you get different errors.

 I haven't checked what errors you get if you just have the default
 Manager, and a related_name of 'objects'.

 There may also be problems if you have a field named 'objects'.

 I suspect this class of problem could be picked up by the system check
 framework.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.3a6fba0e7221cc7e490f7926d26e7e98%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.