Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:  felixxm
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/8895 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.d26f4302dc1ee019965b7dfc1c144ac0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:  felixxm
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => assigned
 * needs_better_patch:  1 => 0
 * has_patch:  1 => 0
 * version:  1.7 => master
 * owner:  (none) => felixxm


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.ae818875212847e7e3fe00a01868a5b7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 If you'd like to help, please update the old pull request for the
 comments.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.c24875c1f82770fa9a99d0f1bce0f307%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by theromulanz):

 Is this patch still being considered for release?
 I have the same use-case as the ticket description(cx_Oracle
 keywordParameters).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.41a1c0bb459b2f275a14ae75211064f3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * owner:  averybigant =>
 * status:  assigned => new


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.83d7421f6055dad80d32d29d624a2d20%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |  averybigant
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * easy:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.6ed9400e908da5777b6d83b454e3278f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |  averybigant
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by shaib):

 I've added some Notes on the PR, and opened a related
 [https://groups.google.com/d/msg/django-
 developers/v3AhQhJFhGM/TScISVjLBQoJ mailing list discussion].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.08d3e185c19272c390ebfa567b29bfe3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |  averybigant
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by averybigant):

 * needs_better_patch:  1 => 0


Comment:

 Replying to [comment:9 manfre]:
 > Implementation needs a DatabaseFeature (e.g.
 {{{callproc_supports_kwargs}}}) to explicitly enable support for kparams
 for a backend. The current patch will pass along kparams to the underlying
 backend as long as they are provided to callproc, which will raise a
 confusing exception to the user. It should probably raise
 {{{django.db.utils.NotSupportedError}}}.

 Thanks. Made the changes you suggested.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.862c06aa2b698258fd399958c4484fae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |  averybigant
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by manfre):

 * needs_better_patch:  0 => 1


Comment:

 Implementation needs a DatabaseFeature (e.g.
 {{{callproc_supports_kwargs}}} to explicitly enable support for kparams
 for a backend. The current patch will pass along kparams to the underlying
 backend as long as they are provided to callproc, which will raise a
 confusing exception to the user. It should probably raise
 {{{NotSupportedError}}}.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.88c9efb529673d832471f84fa824e218%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |  averybigant
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by averybigant):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0


Comment:

 Replying to [comment:7 shaib]:
 > Hi,
 >
 > I made some notes on the PR. Additionally, documentation needed. I
 suggested making the feature more general, less Oracle-specific, but even
 if this path is not taken, the new behavior needs to be documented.
 Currently, callproc is not documented at all, which is a shame, but
 forgivable considering that the function is as defined in PEP 249;
 deviating from the PEP justifies adding explicit documentation, probably
 in `docs/topics/db/sql.txt`; whether or not that is done, the addition
 should be mentioned in the release notes (`docs/releases/1.8.txt`).

 Thanks for your detailed comments. New commit pushed. I also replied your
 comments on github.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e1c4fe19a5511926876d2ea36ad83831%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |  averybigant
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by shaib):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


Comment:

 Hi,

 I made some notes on the PR. Additionally, documentation needed. I
 suggested making the feature more general, less Oracle-specific, but even
 if this path is not taken, the new behavior needs to be documented.
 Currently, callproc is not documented at all, which is a shame, but
 forgivable considering that the function is as defined in PEP 249;
 deviating from the PEP justifies adding explicit documentation, probably
 in `docs/topics/db/sql.txt`; whether or not that is done, the addition
 should be mentioned in the release notes (`docs/releases/1.8.txt`).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.8585c6007aabcdb95a0872a98e1bcdb7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |  averybigant
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by shaib):

 Thanks for the patch. I'll take a look at it tonight (UTC+3)

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e65b6009d8d6ccf886d847803fda9bcd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |  averybigant
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by averybigant):

 * needs_tests:  1 => 0


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.184a2c780a0cc126b3808bdd8f4fee4b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |  averybigant
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by averybigant):

 * has_patch:  0 => 1


Comment:

 pull request created
 https://github.com/django/django/pull/3342
 already tested on ubuntu 12.04 server(amd64) with oracle XE 11g

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.239cadcd2dbd8c8142b2509635b2fb89%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:
 Type:  New feature  |  averybigant
Component:  Database layer   |   Status:  assigned
  (models, ORM)  |  Version:  1.7
 Severity:  Normal   |   Resolution:
 Keywords:  oracle   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by averybigant):

 * owner:  nobody => averybigant
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.d88920e4507bbbc9ea6100225917fd52%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  oracle   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by aaugustin):

 * needs_docs:  1 => 0
 * stage:  Unreviewed => Accepted


Comment:

 [http://legacy.python.org/dev/peps/pep-0249/#cursor-methods PEP 249] says
 that callproc only accept positional arguments.

 That said, since we're just forwarding arguments to the underlying
 library, this small deviation seems acceptable, with a comment explaining
 it.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b8351610c6f40f8a91ee377f2589c985%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
-+-
 Reporter:  fatal10110   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  1.7
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:  oracle   |  Unreviewed
Has patch:  0|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by shaib):

 * keywords:   => oracle
 * needs_better_patch:   => 0
 * needs_tests:   => 1
 * needs_docs:   => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.f318116163525923dcd117d966b3e73d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #23546: callproc **kwargs or *args parameter

[Django]

#23546: callproc **kwargs or *args parameter
--+
 Reporter:  fatal10110|  Owner:  nobody
 Type:  New feature   | Status:  new
Component:  Database layer (models, ORM)  |Version:  1.7
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  1 |  UI/UX:  0
--+
 I think it will be useful to add kwargs or args parameters to callproc
 method for those backends that support more parameters for callproc method
 (e.g cx_oracle)

 I can not use named parameters for my procedures with django db module.
 =\\

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.5db7638ae8cd2128d27d8000532c55bd%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.