Re: [Django] #27153: HttpResponseBase should check for valid HTTP status code

2016-08-30 Thread Django 
#27153: HttpResponseBase should check for valid HTTP status code
-+-
 Reporter:  ryangallen   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  HTTP handling|  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"190d2ff4a7a392adfe0b12552bd71871791d87aa" 190d2ff4]:
 {{{
 #!CommitTicketReference repository=""
 revision="190d2ff4a7a392adfe0b12552bd71871791d87aa"
 Fixed #27153 -- Added validation for HttpResponse status.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.81b4f90070e35c49624605eefa17f019%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27153: HttpResponseBase should check for valid HTTP status code

2016-08-30 Thread Django 
#27153: HttpResponseBase should check for valid HTTP status code
-+-
 Reporter:  ryangallen   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  HTTP handling|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.879ca8cd449b74783bdd0a4ad7739722%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27153: HttpResponseBase should check for valid HTTP status code

2016-08-30 Thread Django 
#27153: HttpResponseBase should check for valid HTTP status code
--+
 Reporter:  ryangallen|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  HTTP handling |  Version:  1.10
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:  0 => 1
 * easy:  1 => 0
 * stage:  Unreviewed => Accepted


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.6862c1544bb3250a86d112a80429d94a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27153: HttpResponseBase should check for valid HTTP status code

2016-08-30 Thread Django 
#27153: HttpResponseBase should check for valid HTTP status code
-+-
 Reporter:  ryangallen   |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  HTTP handling|  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by ryangallen):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Github PR: https://github.com/django/django/pull/7165

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.57db763e69e771737b15fb6f294621a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #27153: HttpResponseBase should check for valid HTTP status code

2016-08-30 Thread Django 
#27153: HttpResponseBase should check for valid HTTP status code
--+
 Reporter:  ryangallen|  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  HTTP handling |Version:  1.10
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  1
Easy pickings:  1 |  UI/UX:  0
--+
 Currently, the HttpResponseBase class does not check for Type or Value
 Error on the HTTP status code. If a bad value such as a string is passed
 it, an exception is not thrown until it reaches:

 {{{
 File "django/http/utils.py", line 17, in conditional_content_removal
 if 100 <= response.status_code < 200 or response.status_code in (204,
 304):
 TypeError: unorderable types: int() <= str()
 }}}

 Proposed fix:
 - Valid status values in the form of a string should be coerced to an
 integer if possible.
 - Integer values less than 100 or greater than 599 should also be rejected
 based on [https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html W3C
 Status Code Definitions RFC 2612]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/053.84e6f643a7c642a11f764e851d1b0131%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.