Re: [Django] #27362: Omitting default_app_config in __init__.py happens too easily.

[Django]

#27362: Omitting default_app_config in __init__.py happens too easily.
-+-
 Reporter:  Thomas Güttler   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  1.10
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Thomas Güttler):

 We use this test to unsure that the same error does happen again:

 {{{

 def test_app_config_registered(self):
 for app_config in apps.get_app_configs():
 if not app_config.__module__=='django.apps.config':
 # This app has an own AppConfig class registered: ok
 continue
 apps_module_path='%s.apps' % app_config.name
 try:
 import_module(apps_module_path)
 except ImportError:
 # No module called "apps": ok
 continue
 raise AssertionError('%s exists, but the registry
 (apps.get_app_configs()) contains the base class. Please use dotted python
 path to AppConfig in INSTALLED_APPS or use default_app_config in
 __init__.py' %
  (apps_module_path))

 }}}

 I  guess this can't be integrated into django.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4b3d4cfc7dd16d150054ff07cb0498ff%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27362: Omitting default_app_config in __init__.py happens too easily.

[Django]

#27362: Omitting default_app_config in __init__.py happens too easily.
-+-
 Reporter:  Thomas Güttler   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  1.10
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Aymeric Augustin):

 Historically this ticket would have been kept open in the "design decision
 needed" stage. We started closing tickets with no clear way forwards a
 couple years ago to keep open tickets actionable.

 I believe that the documentation is clear is it stands and (unfortunately)
 not a good solution here because a programmer debugging such a problem is
 unlikely to be perusing the documentation of apps.

 Perhaps we could add a check to raise a warning if there's an AppConfig
 subclass defined in an `apps` submodule -- the conventional location? That
 seems quite prone to false positives...

 Other arguments or ideas welcome...

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e9cea81c80ac57cf26e66e30e8422750%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27362: Omitting default_app_config in __init__.py happens too easily.

[Django]

#27362: Omitting default_app_config in __init__.py happens too easily.
-+-
 Reporter:  Thomas Güttler   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  1.10
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 A proposed solution.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.00bacc392e0df1705d3b58012d8f5783%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27362: Omitting default_app_config in __init__.py happens too easily.

[Django]

#27362: Omitting default_app_config in __init__.py happens too easily.
-+-
 Reporter:  Thomas Güttler   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  1.10
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Thomas Güttler):

 What kind of info is needed?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f593b5cac495756d9550907950d57cd9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27362: Omitting default_app_config in __init__.py happens too easily. (was: Omitting default_app_config in __init__.py happens to easily.)

[Django]

#27362: Omitting default_app_config in __init__.py happens too easily.
-+-
 Reporter:  Thomas Güttler   |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  1.10
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * type:  Uncategorized => Cleanup/optimization
 * component:  Uncategorized => Core (Other)
 * resolution:   => needsinfo


Comment:

 There was #25356 in which it was suggested that `default_app_config` is
 discouraged and shouldn't be in the default app template.

 Closing as needsinfo absent a way to move forward with the ticket. Feel
 free to reopen if anyone thinks of actionable items.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.ddd2d35edd477571afa51f5b08628dd6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27362: Omitting default_app_config in __init__.py happens to easily.

[Django]

#27362: Omitting default_app_config in __init__.py happens to easily.
+--
 Reporter:  Thomas Güttler  |Owner:  nobody
 Type:  Uncategorized   |   Status:  new
Component:  Uncategorized   |  Version:  1.10
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Aymeric Augustin):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Yes, I can see the problem.

 That's one of the reasons why I'm against `default_app_config`. It's only
 there for backwards compatibility and should only be used by pluggable
 apps that predate Django 1.7, need a custom app config and don't want to
 ask their users to update their `INSTALLED_APPS` setting.

 Unfortunately, even if `default_app_config` was removed, we'd still be
 stuck with two kinds of apps: those that provide a custom AppConfig and
 those that don't. This results in a mixed style in `INSTALLED_APPS`, and
 then it's easy to reference an app by its package name and load it with
 the base `AppConfig` class instead of its custom `MyAppConfig` class.

 Like you I'm not really coming up with great ideas to improve the
 situation...

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.f103feb7f70227488520d11fa72b585f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #27362: Omitting default_app_config in __init__.py happens to easily.

[Django]

#27362: Omitting default_app_config in __init__.py happens to easily.
+
 Reporter:  Thomas Güttler  |  Owner:  nobody
 Type:  Uncategorized   | Status:  new
Component:  Uncategorized   |Version:  1.10
 Severity:  Normal  |   Keywords:
 Triage Stage:  Unreviewed  |  Has patch:  0
Easy pickings:  0   |  UI/UX:  0
+
 Up to now it is likely that the programmer forgets to add
 "default_app_config = 'myapp.apps.AppConfig" in `__init__.py`.

 It took too much time to debug why the signal handled of a reusable app
 was not called on one system (INSTALLED_APPS=[... 'myapp'])
 and called on another system (INSTALLED_APPS=[...,
 'myapp.apps.AppConfig']).

 I have no clue how to solve this at the moment.

 But I hope you can understand that "pain".

 What can be done to assist the programmer?

 Related docs: https://docs.djangoproject.com/en/1.10/ref/applications
 /#configuring-applications

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/050.b1a7b55df8b28a4e593e4abe621a5f81%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.