Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * has_patch:  1 => 0
 * resolution:  fixed => wontfix
 * stage:  Ready for checkin => Unreviewed


Comment:

 Patch was reverted, it's probably not worth complexity.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e9b0c2f-916cd9ed-c4f0-4159-b038-263bd3a78ca6-00%40eu-central-1.amazonses.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"82e9e19ebe6bc920f1cfffc42d86648644fd4a78" 82e9e19]:
 {{{
 #!CommitTicketReference repository=""
 revision="82e9e19ebe6bc920f1cfffc42d86648644fd4a78"
 [4.1.x] Fixed #33893 -- Reverted "Fixed #28889 -- Prevented double
 submission of admin forms."

 Regression in fe7dbef5867c577995f0fc849d8dfdb8f2e6bbfa.

 Backport of 0756c61f2ada56e4ae625589099c0141a77737eb from main
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e998c69-c936acc7-fa63-470a-8421-0c65576f40d7-00%40eu-central-1.amazonses.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"0756c61f2ada56e4ae625589099c0141a77737eb" 0756c61f]:
 {{{
 #!CommitTicketReference repository=""
 revision="0756c61f2ada56e4ae625589099c0141a77737eb"
 Fixed #33893 -- Reverted "Fixed #28889 -- Prevented double submission of
 admin forms."

 Regression in fe7dbef5867c577995f0fc849d8dfdb8f2e6bbfa.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701826e992195-4f6b7421-9c17-4263-a5bf-4fa7c20088b7-00%40eu-central-1.amazonses.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  closed
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"fe7dbef5867c577995f0fc849d8dfdb8f2e6bbfa" fe7dbef]:
 {{{
 #!CommitTicketReference repository=""
 revision="fe7dbef5867c577995f0fc849d8dfdb8f2e6bbfa"
 Fixed #28889 -- Prevented double submission of admin forms.

 Added a JavaScript confirm() to catch double-submissions, when the
 change form has already been submitted.

 Thanks to Adam Johnson, Claude Paroz, Keryn Knight, and Thibaud Colas
 for review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1738e493ca224a429f12eae27330164f%40djangoproject.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.b2575953651042eb8bad0f7805023abf%40djangoproject.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Marcelo Galigniana):

 Is there anything I can do to move this forward?

 Should I create a conversation at the django-developers google group?

 IMO the 2nd approach: "Disable buttons while submitting" it's simpler and
 works well!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bd6250963c212cdbd8ba4d78de9427b1%40djangoproject.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Marcelo Galigniana):

 For this issue there are currently 2 approaches:

 - [https://github.com/django/django/pull/15217 Trigger an alert when
 submitting twice]

 - [https://github.com/django/django/pull/15229 Disable buttons while
 submitting]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.53a8ecc061ad6da9c098d31f69f3b3a9%40djangoproject.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.72452f0da2846956a8403e4397dc3a06%40djangoproject.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Marcelo Galigniana):

 * has_patch:  0 => 1
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bb2cb84f67859c3b6c0c4de81b0ed478%40djangoproject.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Marcelo
 Type:   |  Galigniana
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Marcelo Galigniana):

 * owner:  (none) => Marcelo Galigniana
 * status:  new => assigned
 * has_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.9625efc3aaf70f3b13eb9010c3ef5c5f%40djangoproject.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
--+
 Reporter:  Manuel Saelices   |Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Mariusz Felisiak):

 * owner:  Karan Bedi => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2ac541944c8ea349efd0ffab3bddf7af%40djangoproject.com.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Karan
 Type:   |  Bedi
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Karan Bedi):

 Hi Carlton,

 - I am unable to reproduce the behavior, probably because till now, I am
 serving on localhost.
 - In the article, there are different methods of implementing the same.
 One improvement can be changing the label of the submit button after a
 click.
 - From the point of usability, there is just a comment by someone, which
 also doesn't seem concrete.

 Please guide me on how to proceed further.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5ee440849109fa5572be8349bf1e5702%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Karan
 Type:   |  Bedi
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Hi Karan,

 Thanks for the input. Your fix includes the changes Nick suggested from
 the original PR. (Great.)

 To get this merged we need to address Tim's concerns.

 * Can we add some selenium tests, to exercise the behaviour?
 * What's your assessment of the article Tim linked to? Do we need to do
 this?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.36b22c592dd26f76c5d751a3a3c576e5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Karan
 Type:   |  Bedi
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Karan Bedi):

 I have created a PR. Please guide me how to proceeding further.
 [https://github.com/django/django/pull/9608 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.430fd4b825919436c1eee0596b50f9a0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
-+-
 Reporter:  Manuel Saelices  |Owner:  Karan
 Type:   |  Bedi
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.11
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Karan Bedi):

 * owner:  nobody => Karan Bedi
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1fa114f199445a6f89d4da95da1fdcac%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #28889: Use JavaScript to prevent double submission of admin forms (was: Prevent double submission on admin forms)

[Django]

#28889: Use JavaScript to prevent double submission of admin forms
--+
 Reporter:  Manuel Saelices   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  1.11
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Tim Graham):

 * has_patch:  0 => 1
 * type:  Bug => Cleanup/optimization
 * needs_tests:  0 => 1


Comment:

 I found an article titled [http://www.the-art-of-
 web.com/javascript/doublesubmit/ JavaScript: Preventing Double Form
 Submission] which might be worth reviewing. In particular, it points out
 "Rather than simply disabling the button, we can also change the text so
 that people don't get confused."

 Did you consider trying to add some tests for the patch?

 I share Nick's concern on the pull request that this may have a good
 chance of causing some regression in unconsidered edge cases. I'm not sure
 if it's considered a best practice these days. The article suggests that
 some browsers (e.g. IE11) treat a double click as a single click.  It
 seems unfortunate if every project has to add something like this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.322bf1c01024d1883de2c58d5da7f27f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.