Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
-+-
 Reporter:  CHI Cheng|Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  closed
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson ):

 In [changeset:"999891bd80b3d02dd916731a7a239e1036174885" 999891bd]:
 {{{
 #!CommitTicketReference repository=""
 revision="999891bd80b3d02dd916731a7a239e1036174885"
 Refs #29379 -- Moved autocomplete attribute to UsernameField.

 Moving the autocomplete attribute into UsernameField allows this to work
 for custom forms making use of UsernameField, removes some duplication
 in the code, and keeps consistency with the autocapitalize attribute
 that is already defined on UsernameField.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.27e9e31c3d6bc2662ae14ea13e5ae879%40djangoproject.com.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
-+-
 Reporter:  CHI Cheng|Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  closed
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Nick Pope):

 [https://github.com/django/django/pull/11623 PR] moving `autocomplete`
 attribute into `UsernameField`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.be3b6d90da4db075ca6fe1cef3cb18e5%40djangoproject.com.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
-+-
 Reporter:  CHI Cheng|Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  closed
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"dcb8f00d06eec99072b78d54215c9a3dc04acb99" dcb8f00]:
 {{{
 #!CommitTicketReference repository=""
 revision="dcb8f00d06eec99072b78d54215c9a3dc04acb99"
 Fixed #29379 -- Added autocomplete attribute to contrib.auth.forms fields.

 Thank you to Nick Pope for review.

 Co-authored-by: CHI Cheng 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.60d100ff61a4e959229e7a282d6f4280%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
-+-
 Reporter:  CHI Cheng|Owner:  Hasan
 |  Ramezani
 Type:  New feature  |   Status:  assigned
Component:  contrib.auth |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.05178dacbe752b6e64aaa9aead56f848%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
--+--
 Reporter:  CHI Cheng |Owner:  Hasan Ramezani
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Hasan Ramezani):

 * needs_tests:  1 => 0


Comment:

 Tests added to PR!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cc7b305271fa66edc5cac0488a038d72%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
--+--
 Reporter:  CHI Cheng |Owner:  Hasan Ramezani
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--

Comment (by Hasan Ramezani):

 @Johannes Hoppe , I did your requested changes on the PR.
 Any suggestion for the tests?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.de5e906c37c00286660fd1fa7c62363c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
--+--
 Reporter:  CHI Cheng |Owner:  Hasan Ramezani
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Nick Pope):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.91fe03178defd47dc7ee2076f74c5a02%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
--+--
 Reporter:  CHI Cheng |Owner:  Hasan Ramezani
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Johannes Hoppe):

 * needs_docs:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.30fd07d68d2854931cd9982eca58d082%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
--+--
 Reporter:  CHI Cheng |Owner:  Hasan Ramezani
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  1
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Johannes Hoppe):

 * needs_docs:  0 => 1
 * needs_better_patch:  1 => 0


Comment:

 Since this is marked as a new feature, you might want to add a line or two
 to the 3.0 release notes. I don't think you need to add anything to the
 documentation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.77ab1c7cfabac5e573cd2d2f5ceb431c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
--+--
 Reporter:  CHI Cheng |Owner:  Hasan Ramezani
 Type:  New feature   |   Status:  assigned
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Hasan Ramezani):

 * status:  new => assigned
 * owner:  nobody => Hasan Ramezani


Comment:

 PR [https://github.com/django/django/pull/11070]

 Just a little change in https://github.com/django/django/pull/9921 so
 tests are passed.
 Do we need to add tests for it? how?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6c3761e3dde4f2bd6e55002ec75148c3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
--+
 Reporter:  CHI Cheng |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz):

 After months of inactivity, feel free to take over the patch (crediting
 the original author), and polish it so as it can get in the review queue
 again.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7460195abf66864876f632cbf4cf3585%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
--+
 Reporter:  CHI Cheng |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+

Comment (by sedrubal):

 Hi, what is the status of this pull request? I just wanted to open the
 same pull request and then I found this ticket...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.f21d7dfb8a93c0ae3d92907c0537cbaa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
--+
 Reporter:  CHI Cheng |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Jeff):

 * cc: Jeff (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.1afe3cac950431727c0f9b56f22b7d93%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
--+
 Reporter:  CHI Cheng |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2787a32531f43be55d01134f31e96831%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
--+--
 Reporter:  CHI Cheng |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  0 |UI/UX:  0
--+--
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


Comment:

 This seems OK/good in theory. We're a bit ahead of the curve in terms of
 current browser support so there's a question about when (and whether)
 this gets adopted.

 [https://github.com/django/django/pull/9921 PR] has failures that need
 addressing.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6e89d980f2fb4472260654193fe624c0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
--+--
 Reporter:  CHI Cheng |Owner:  nobody
 Type:  New feature   |   Status:  new
Component:  contrib.auth  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Unreviewed
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+--
Description changed by CHI Cheng:

Old description:

> Add autocomplete=username/email/current-password/new-password to
> contrib.auth builtin forms.
>
> The most useful one is autocomplete=new-password, which prevents browsers
> prefill with current password, Chrome will also suggest a random strong
> password for users who turned on account sync.
>
> Related docs:
> https://html.spec.whatwg.org/multipage/form-control-
> infrastructure.html#autofill
> https://www.chromium.org/developers/design-documents/form-styles-that-
> chromium-understands
> https://developer.mozilla.org/en-
> US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#The_autocomplete_attribute_and_login_fields

New description:

 Add autocomplete=username/email/current-password/new-password to
 contrib.auth builtin forms.

 Pull request: https://github.com/django/django/pull/9921

 The most useful one is autocomplete=new-password, which prevents browsers
 prefill with current password, Chrome will also suggest a random strong
 password for users who turned on account sync.

 Related docs:
 https://html.spec.whatwg.org/multipage/form-control-
 infrastructure.html#autofill
 https://www.chromium.org/developers/design-documents/form-styles-that-
 chromium-understands
 https://developer.mozilla.org/en-
 
US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#The_autocomplete_attribute_and_login_fields

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3b7de9d1a68492042fcc58a2a56bb7f2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29379: Add autocomplete attribute to contrib.auth fields

[Django]

#29379: Add autocomplete attribute to contrib.auth fields
+
   Reporter:  CHI Cheng |  Owner:  nobody
   Type:  New feature   | Status:  new
  Component:  contrib.auth  |Version:  master
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+
 Add autocomplete=username/email/current-password/new-password to
 contrib.auth builtin forms.

 The most useful one is autocomplete=new-password, which prevents browsers
 prefill with current password, Chrome will also suggest a random strong
 password for users who turned on account sync.

 Related docs:
 https://html.spec.whatwg.org/multipage/form-control-
 infrastructure.html#autofill
 https://www.chromium.org/developers/design-documents/form-styles-that-
 chromium-understands
 https://developer.mozilla.org/en-
 
US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#The_autocomplete_attribute_and_login_fields

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.de12ffbb2bef4183a0f70b916b3dd036%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.