Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  closed
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f63f3cdf0969c23fd0c05de0f4a2a1df0cd5112e" f63f3cdf]:
 {{{
 #!CommitTicketReference repository=""
 revision="f63f3cdf0969c23fd0c05de0f4a2a1df0cd5112e"
 Fixed #29712 -- Made makemessages warn if locales have hyphens and skip
 them.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.bc521916a5e2e7f318edf75c271f7061%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.929e3bcb4d2d3abc5965656a64835941%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Manav Agarwal):

 As per the
 [https://github.com/django/django/pull/13615#issuecomment-726174242
 comment by felixxm] on [https://github.com/django/django/pull/13615 PR], I
 have created a check for the valid locales to not have hyphens.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.f304e1a905789ce22af959a1122e739d%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.7b4fd651aa191d0d1f0c4b669c3dfbbf%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.b38ec9a049f8d88b1aeeb2b5cccfef34%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.9cda8d5d420d07f505ed537c504d286d%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Manav Agarwal):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.3b78ca2611e94429a35d0dfcbb21f266%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Manav Agarwal):

 If the patch in [https://github.com/django/django/pull/13615 PR] seems
 fine then please update me so that I may start working on tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.84935dbc140429f7e52d0616e03724ce%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Manav Agarwal):

 [https://github.com/django/django/pull/13615 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.fa53c40fd08450a289ae41bdff2c2772%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Manav
 Type:   |  Agarwal
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Claude Paroz):

 The problem with using `LANG_INFO` is that you exclude some extra
 languages added specifically for a project.

 You can try to use `language_code_re`, but you'll have to take into
 account the language code vs locale code difference.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.9c27880679ecb265d87338deaeb001da%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Aniket118
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Hi Manav, please do, no need to ask (but can I advise that you take just
 one at a time to begin :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.c5cfc3ddde29a85eae17fdc22ada345e%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Aniket118
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Manav Agarwal):

 Can I claim this? I think I can move this forward

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.ed6bb89d71f4f9c51eae9ffa46b03a51%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Aniket118
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Aniket118):

 * owner:  (none) => Aniket118
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.e8a5ea9477e8bea9e796243c13bcdf15%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Rohit Jha
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Rohit Jha):

 * owner:  (none) => Rohit Jha
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.797814512f1cece50155e15146cbbec4%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
--+
 Reporter:  Sanyam Khurana|Owner:  dk
 Type:  Cleanup/optimization  |   Status:  assigned
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by dk):

 * owner:  (none) => dk
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.e055705c85cf4dc795257c75da148d32%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
--+
 Reporter:  Sanyam Khurana|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Ashish Mohite):

 * status:  assigned => new
 * owner:  Ashish Mohite => (none)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.00f8bf9f55e1dad11687f4ec2470f792%40djangoproject.com.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Ashish
 Type:   |  Mohite
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Ashish Mohite):

 * status:  new => assigned
 * owner:  (none) => Ashish Mohite


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.234e25eb7be34f708540dfc2c51e8744%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:
 Type:   |  mdsheerazaziz
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by mdsheerazaziz):

 * owner:  (none) => mdsheerazaziz
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.4d8cd43667951e0dbbb762733b155db4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
--+
 Reporter:  Sanyam Khurana|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Carlton Gibson):

 * owner:  Mark Dawson => (none)
 * status:  assigned => new


Comment:

 I'm going to de-assign this because there's been progress, so that someone
 looking can pick it up.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.f42f2d80ecf55aa520c48556d28c40a4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Mark
 Type:   |  Dawson
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Herbert Fortes):

 I forgot to say that the regrex I sent fails to:

 {{{
 ja_JP_JP
 no_NO_NY
 th_TH_TH
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.c4798ce72288058e5c46c306248c01dc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Mark
 Type:   |  Dawson
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Herbert Fortes):

 Hi,

 Here my thoughts:

 language_code_re gets 'pt_BR'. And it does not get 'ZH-CN'. I did this:
 {{{ r'[a-z]{2}(_[A-Z]{2})?' }}}

 It seems to work. But one test prints:
 {{{
 System check identified no issues (0 silenced).
 Invalid locale d
 Invalid locale e
 .
 --
 Ran 49 tests in 1.425s

 OK
 }}}

 I did a check and there is only one line - 740 - that's use
 {{{locale=LOCALE}}}. All
 others use {{{ locale=[LOCALE]}}}.

 What do you think Mark?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.2a5c03b941fcc7bd373effc2d908ea1d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Mark
 Type:   |  Dawson
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Herbert Fortes):

 * cc: Herbert Fortes (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.e45c77cbdb410a54cecf2ace6cd5636a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Mark
 Type:   |  Dawson
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mark Dawson):

 * owner:  (none) => Mark Dawson
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.aa9288972405d66ef60f1faab54f0360%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
--+
 Reporter:  Sanyam Khurana|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Abhith Krishna):

 * owner:  Abhith Krishna => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.0467c0c3e7c683b89611319f94fa890e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Abhith
 Type:   |  Krishna
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Abhith Krishna):

 * owner:  (none) => Abhith Krishna
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.97ab799c47546c314e230a5a6c11e837%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
--+
 Reporter:  Sanyam Khurana|Owner:  (none)
 Type:  Cleanup/optimization  |   Status:  new
Component:  Internationalization  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Vishvajit Pathak):

 * status:  assigned => new
 * cc: Vishvajit Pathak (removed)
 * owner:  Vishvajit Pathak => (none)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.c0b607290a98bdc1028066c81efd6785%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Vishvajit Pathak):

 Hi Sanyam,

 Yes, I am working on this ticket but your help would be very appreciated.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.abfaf739c7c41068d874974c33a509c5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Sanyam Khurana):

 Hi Vishvajit!

 Are you still working on the bug? Do you need any help?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.76a78d48afafaf736607c48c2e5550a1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * needs_better_patch:  0 => 1


Comment:

 As commented on the pull request, you cannot use the `all_locales`
 variable as a reference as it does not contain new (valid) language codes.
 The modified test in your patch shows a `'Invalid locale en'` message
 which is obviously wrong, isn't it?
 You may try using the
 `django.utils.translation.trans_real.language_code_re` to check the locale
 code syntax.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.7ea63f987fdb0a19a0f57188afc51d69%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Vishvajit Pathak):

 Tim,

 I would like to understand better what needs to be done next ?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.e1213e2cd5f243e6a589d3fb0f47499a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.cb78bf4d2366b5e757a9917909253e88%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Vishvajit Pathak):

 Tim

 Current implementation involved just adding the warning message. We are
 not normalizing locale now.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.2e0ef9d1268dcef71ad41abf4c1aba26%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.6d35191e926c40d3a18aa9a6192b73ed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Vishvajit Pathak):

 Now I am thinking more to avoid the coercing and to put just a warning
 message.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.ccf60c603e2c5593c2f2a677a9b704eb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Nick Pope):

 Replying to [comment:13 Claude Paroz]:
 > Improving documentation is welcome, but silently accepting a wrong
 language code also look a bit suspicious. I think I would be happy with a
 warning without coercing anything.

 I agree. I think a warning would make sense, without coercion.

 It is still possible to provide a locale to {{{makemessages}}} where there
 are no actual message catalogs in any of the paths in
 `settings.LOCALE_PATHS`.
 We should probably scrap all the normalization stuff and just output a
 warning message if a locale specified by the user is not in
 {{{all_locales}}}.
 At the moment we output a {{{"processing locale xx_XX"}}} message if
 {{{verbosity > 0}}} which should be fixed to only happen for valid,
 existing locales.

 As an aside, this is checking {{{--locale}}} for {{{makemessages}}}, but
 what about {{{compilemessages}}}? (And are their any others?)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.45fd2dc23214b16640bb068455284cf5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Vishvajit Pathak):

 We definitely need to improve the documentations. Coercing the language
 code is something we have to take call on.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.5de3a925c58d73a3e3acdd387f5e8079%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Claude Paroz):

 Improving documentation is welcome, but silently accepting a wrong
 language code also look a bit suspicious. I think I would be happy with a
 warning without coercing anything.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.5e9e128a64598bb3363f0a04aef2475b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Nick Pope):

 Trying to coerce ''any'' input to something like a
 [https://www.w3.org/International/articles/language-tags/ language tag]
 only to hack it back to a
 [https://www.gnu.org/software/libc/manual/html_node/Locale-Names.html
 locale] using {{{to_locale()}}} feels like a kludge. It would be better to
 improve documentation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.138d6373831e54501f9b80fb70f45559%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Vishvajit Pathak):

 Warning added when a language code is normalized.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.cd29dba7688e72450c442785e66a4c15%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Claude Paroz):

 I think I would still output a warning when a language code is normalized,
 just to inform the user that its input has been corrected.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.c18e75466798ce63e00dd4f26cfec151%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Vishvajit Pathak):

 * needs_tests:  1 => 0


Comment:

 [https://github.com/django/django/pull/10365 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.bde141a40940ac354acdcc2a27b712d5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Vishvajit Pathak):

 [https://github.com/django/django/pull/10365]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.eec3f40f8392beb249145d4d6dc14756%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Vishvajit
 Type:   |  Pathak
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Vishvajit Pathak):

 * cc: Vishvajit Pathak (added)
 * owner:  Matt Segal => Vishvajit Pathak


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.98999dcf930f66b7c77e56d1e1866c49%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  Matt
 Type:   |  Segal
  Cleanup/optimization   |   Status:  assigned
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Matt Segal):

 PR Ready

 [https://github.com/django/django/pull/10345]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.d29ceb858d20037a7b7a8c605dcb3f61%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  MattSegal
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:   |  Version:  master
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * has_patch:  0 => 1
 * version:  2.1 => master
 * type:  Bug => Cleanup/optimization
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.6fd916b89f3cda2f4f843536cad2b9e6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  MattSegal
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  2.1
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by MattSegal):

 * owner:  (none) => MattSegal
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.d52682a9bb0588db1413923da3879a2b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
--+
 Reporter:  Sanyam Khurana|Owner:  (none)
 Type:  Bug   |   Status:  new
Component:  Internationalization  |  Version:  2.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Description changed by Sanyam Khurana:

Old description:

> The translations only work when the locale involving  region code is
> generated as this:
>
> `zh_CN` for Simplified Chinese
>
> Notice here that the region code should be in capital letters for the
> `django.po` file in the directory to correctly work.
>
> If we do `makemessages` as
>
> `python manage.py makemessages -l zh_cn`
> OR
> `python manage.py makemessages -l zh-cn`
>
> It wouldn't work and no error is produced even after running
> compilemessages, which can leave people baffled for a while.
>
> I would suggest adding a warning/error messages if the locale is used
> incorrectly. That would certainly be a great help.
>
> I can make a patch for this as well.

New description:

 Hey Calude,

 What about normalizing the directory name to something that would just
 work.

 For example,

 No matter, if the developer is doing all these:

 `python manage.py makemessages -l zh_cn`
 `python manage.py makemessages -l zh_CN`
 `python manage.py makemessages -l ZH_CN`
 `python manage.py makemessages -l ZH-CN`

 etc.

 we, just normalize the directory name to `zh_CN` and it would work.

 I'm still about to read the code of `makemessages` command and probably if
 there are any more checks than just this, then we'll have to figure out
 another way all together.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.e386c9593b286a14b38ac1b0cdc2542f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
--+
 Reporter:  Sanyam Khurana|Owner:  (none)
 Type:  Bug   |   Status:  new
Component:  Internationalization  |  Version:  2.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by David):

 * owner:  David => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.a2ab9bd3af9f48622db985b25d9654a2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
--+
 Reporter:  Sanyam Khurana|Owner:  darvid7
 Type:  Bug   |   Status:  assigned
Component:  Internationalization  |  Version:  2.1
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Claude Paroz):

 * stage:  Unreviewed => Accepted


Comment:

 We have to be careful in deciding what is a "good" and a "bad" code.
 However I agree that we can avoid some mistakes, notably the confusion
 between IETF language tags [1] and ISO/IEC 15897 (Posix) [2] codes
 generally expected by Django.

 [1] https://en.wikipedia.org/wiki/IETF_language_tag
 [2] https://en.wikipedia.org/wiki/Locale_(computer_software)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.982808e7cbd4a0b0c77bc521d4e1599b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
-+-
 Reporter:  Sanyam Khurana   |Owner:  darvid7
 Type:  Bug  |   Status:  assigned
Component:   |  Version:  2.1
  Internationalization   |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by darvid7):

 * owner:  nobody => darvid7
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/072.8e7d2e9113d9fcdaef1e1867d0c1ef15%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #29712: Add warning in makemessages command if the localecode with `l` flag is not correct

[Django]

#29712: Add warning in makemessages command if the localecode with `l` flag is 
not
correct
+
   Reporter:  Sanyam Khurana|  Owner:  nobody
   Type:  Bug   | Status:  new
  Component:  Internationalization  |Version:  2.1
   Severity:  Normal|   Keywords:
   Triage Stage:  Unreviewed|  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  0 |
+
 The translations only work when the locale involving  region code is
 generated as this:

 `zh_CN` for Simplified Chinese

 Notice here that the region code should be in capital letters for the
 `django.po` file in the directory to correctly work.

 If we do `makemessages` as

 `python manage.py makemessages -l zh_cn`
 OR
 `python manage.py makemessages -l zh-cn`

 It wouldn't work and no error is produced even after running
 compilemessages, which can leave people baffled for a while.

 I would suggest adding a warning/error messages if the locale is used
 incorrectly. That would certainly be a great help.

 I can make a patch for this as well.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/057.81474f0a46ace8d045fde1391c5360a8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.