Re: [Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
 Reporter:  Tobias Kunze |Owner:  Tobias
 |  Kunze
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"e8de1cc94c9a251ba7c569468f1e94faf9a05671" e8de1cc9]:
 {{{
 #!CommitTicketReference repository=""
 revision="e8de1cc94c9a251ba7c569468f1e94faf9a05671"
 [2.2.x] Fixed #30325 -- Reverted "Fixed #29725 -- Removed unnecessary join
 in QuerySet.count() and exists() on a many-to-many relation."

 This reverts commit 1299421cadc4fcf63585f2f88337078e43e660e0 due to
 a regression with custom managers.

 Backport of 5f7991c42cff73b6278106d499d719b726f85ead from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.d1355b4717d96315a52c47135c07940d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
 Reporter:  Tobias Kunze |Owner:  Tobias
 |  Kunze
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"5289d4faec5ddc7592c719825914fe430003f724" 5289d4f]:
 {{{
 #!CommitTicketReference repository=""
 revision="5289d4faec5ddc7592c719825914fe430003f724"
 [2.2.x] Refs #30325 -- Added tests for using count()/exists() with custom
 managers and reverse M2M relations.

 Backport of 9ac8520fcde29840a1345be19d80dbda53aa6d03 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.9928ca17900c37503fbc6fad3e0748b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
 Reporter:  Tobias Kunze |Owner:  Tobias
 |  Kunze
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5f7991c42cff73b6278106d499d719b726f85ead" 5f7991c4]:
 {{{
 #!CommitTicketReference repository=""
 revision="5f7991c42cff73b6278106d499d719b726f85ead"
 Fixed #30325 -- Reverted "Fixed #29725 -- Removed unnecessary join in
 QuerySet.count() and exists() on a many-to-many relation."

 This reverts commit 1299421cadc4fcf63585f2f88337078e43e660e0 due to
 a regression with custom managers.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.1bc0f8b41af423bb213a7d38374f98c1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
 Reporter:  Tobias Kunze |Owner:  Tobias
 |  Kunze
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"9ac8520fcde29840a1345be19d80dbda53aa6d03" 9ac8520]:
 {{{
 #!CommitTicketReference repository=""
 revision="9ac8520fcde29840a1345be19d80dbda53aa6d03"
 Refs #30325 -- Added tests for using count()/exists() with custom managers
 and reverse M2M relations.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.e7fe2cdcc39308045091bbf12ef930bf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
 Reporter:  Tobias Kunze |Owner:  Tobias
 |  Kunze
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * owner:  nobody => Tobias Kunze
 * status:  new => assigned
 * has_patch:  0 => 1
 * stage:  Accepted => Ready for checkin


Comment:

 [https://github.com/django/django/pull/11205 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.9580ab94c71adc166a186f049a0e2a0d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
 Reporter:  Tobias Kunze |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tobias Kunze):

 As per discussion at DjangoCon Europe, the patch in question will probably
 be reverted, closing this issue (and re-opening #29725, potentially). I've
 submitted regression tests: https://github.com/django/django/pull/11205

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.7ca4723d544275538e27aac4b5929398%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
 Reporter:  Tobias Kunze |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Marten Kenbeek):

 Regression caused by [changeset:"1299421cadc4fcf63585f2f88337078e43e660e0"
 1299421] (#29725). `.count()` and `.exists()` on a many-to-many relation
 now use the through model's base manager instead of the related model's
 default manager.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.088c6dff0ec95901e9c44a8e2ae7d226%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
 Reporter:  Tobias Kunze |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tobias Kunze):

 > This is not a bug!

 Could you elaborate on this? As it is changed behaviour from Django 2.1
 and previous versions, it's either a bug/regression, or a documentation
 bug by not mentioning this changed behaviour in the release notes, in my
 opinion. Up until now I've assumed that `something.related.count()` and
 `something.related.all().count()` will yield the same result, and if this
 is not true, it should be documented. (Or is it documented? Could you
 point me at the right place to look?)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.69cba39f1c89f8031331be178117dd05%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
 Reporter:  Tobias Kunze |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  closed => new
 * resolution:  invalid =>


Comment:

 PizzolatoDavide Please do not shout.

 `a.books.count() != a.books.all().count()` for me it is a bug, moreover
 this behavior has changed in Django 2.2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.52630e0fb6acce93236b8e1722700baf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
 Reporter:  Tobias Kunze |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:  invalid
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by PizzolatoDavide):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 This is not a bug!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.b11db78a02188cdf18ad715546b3df56%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
 Reporter:  Tobias Kunze |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  closed => new
 * resolution:  invalid =>
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted


Comment:

 Reproduced at 1ffddfc233e2d5139cc6ec31a4ec6ef70b10f87f and works in Django
 2.1.

 Thanks for the report. Can you bisect to check which commit change this
 behavior?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.e432f48f0167672c53c6117beb41829d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
 Reporter:  Tobias Kunze |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  2.2
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by PizzolatoDavide):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 a.books.all() is managed by the BookManager so it exclude the 'deleted'
 book b1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.3c90750bc41f5ee9076758cb0d3a0673%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager

[Django]

#30325: Inconsistent count() behaviour on reverse relations in ManyToManyFields
with custom model manager
-+-
   Reporter:  Tobias |  Owner:  nobody
  Kunze  |
   Type:  Bug| Status:  new
  Component:  Database   |Version:  2.2
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 When looking up a reverse relation on a ManyToManyField that uses a custom
 model manager, not using `all()` before calling `count()` will not use the
 custom model manager. This results in `obj.m2m_lookup.count()` yielding a
 different result than `obj.m2m_lookup.all().count`, which is new behaviour
 in 2.2, and unexpected (at least to me).

 I've written up a [https://github.com/rixx/django-22-issue minimal test
 case] to showcase the issue. Inlining here:

 {{{
 #!python
 from django.db import models


 class Author(models.Model):
 name = models.CharField(max_length=100)


 class BookManager(models.Manager):
 def get_queryset(self):
 return super().get_queryset().exclude(state='deleted')


 class Book(models.Model):
 title = models.CharField(max_length=100)
 authors = models.ManyToManyField(to=Author, related_name='books')
 state = models.CharField(choices=(('regular', 'regular'), ('deleted',
 'deleted')), default='regular', max_length=100)

 objects = BookManager()

 a = Author.objects.create(name='Bill')
 b1 = Book.objects.create(title='Sonnets', state='deleted')
 b2 = Book.objects.create(title='Hamlet')
 b1.authors.add(a)
 b2.authors.add(a)
 a.books.count()  # Returns 2
 a.books.all().count()  # Returns 1
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/047.7c653ce8d7d4ac9e30ddc1b844aa0f4a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.