Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
-+-
   Reporter:  ddurham|  Owner:  ddurham
   Type:  New| Status:  closed
  feature|  Component:  contrib.formtools
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  session wizard
 Resolution:  fixed  |  forms
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
-+-
Changes (by jezdez):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [16307]:
 {{{
 #!CommitTicketReference repository="" revision="16307"
 Fixed #9200 -- Added new form wizard to formtools based on class based
 views. Many thanks to Stephan Jäkel, ddurham and ElliottM for their work.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
-+-
   Reporter:  ddurham|  Owner:  ddurham
   Type:  New| Status:  new
  feature|  Component:  contrib.formtools
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  session wizard
 Resolution: |  forms
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
-+-
Changes (by jezdez):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
-+-
   Reporter:  ddurham|  Owner:  ddurham
   Type:  New| Status:  new
  feature|  Component:  contrib.formtools
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  session wizard
 Resolution: |  forms
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-

Comment (by jezdez):

 FYI, https://github.com/jezdez/django/compare/feature/formwizard has the
 latest code (similar to the newly attached patch).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
-+-
   Reporter:  ddurham|  Owner:  ddurham
   Type:  New| Status:  new
  feature|  Component:  contrib.formtools
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  session wizard
 Resolution: |  forms
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-

Comment (by aaugustin):

 Note that work on this ticket is happening in a branch :
 https://github.com/stephrdev/django-
 formwizard/commits/feature%2Fcbv_refactor

 There is a discussion on the mailing list :
 https://groups.google.com/group/django-
 developers/browse_thread/thread/185be65b47bd304b?pli=1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
-+-
   Reporter:  ddurham|  Owner:  ddurham
   Type:  New| Status:  new
  feature|  Component:  contrib.formtools
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  session wizard
 Resolution: |  forms
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-
Changes (by d0ugal):

 * cc: dougal85@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
-+-
   Reporter:  ddurham|  Owner:  ddurham
   Type:  New| Status:  new
  feature|  Component:  contrib.formtools
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  session wizard
 Resolution: |  forms
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-
Changes (by jezdez):

 * type:  Uncategorized => New feature


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
-+-
   Reporter:  ddurham|  Owner:  ddurham
   Type: | Status:  new
  Uncategorized  |  Component:  contrib.formtools
  Milestone: |   Severity:  Normal
Version:  SVN|   Keywords:  session wizard
 Resolution: |  forms
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
-+-
Changes (by patchhammer):

 * needs_better_patch:  0 => 1
 * type:   => Uncategorized
 * severity:   => Normal
 * easy:   => 0


Comment:

 session_wizard_patch.diff fails to apply cleanly on to trunk

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  ddurham
 
Status:  new   | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by anonymous):

 * cc: flo...@gmail.com (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  ddurham
 
Status:  new   | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by shauncutts):

 * cc: sh...@cuttshome.net (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  ddurham
 
Status:  new   | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by steph):

 my implementation works with ManyToMany and FormSet too. you may give it a
 try. I'm working on a proposal to get it into django 1.3 too..
 [http://github.com/stephrdev/django-formwizard django-formwizard] docs are
 missing (basicly same as current formwizard), but feel free to contact me
 or open issues on github.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  ddurham
 
Status:  new   | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by danaspiegel):

 This code unfortunately also doesn't support ManyToMany relationships
 where you need to present an inline FormSet. I think that actually, the
 functionality of this code isn't much beyond the existing FormWizard
 shipping with 1.2, and though its cleaner, if there's going to be an
 upgrade to the FormWizard functionality, I think that there needs to be
 some rethinking about how it should work.

 At the very least, it should provide over-rideable methods for getting the
 forms for a step, so that you can provide multiple forms (to support
 inline formsets) and their related instances, and actually support
 multiple forms per step.

 If someone takes this on, I'd be happy to provide some complex use-cases
 and code to help figure out the right architecture.

 I vote for "Patch Needs Improvement" (though I won't change the setting on
 this ticket since I'm not a core developer for Django)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  ddurham
 
Status:  new   | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by ckd):

  * status:  reopened => new

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  ddurham
 
Status:  reopened  | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by ckd):

  * status:  closed => reopened
  * resolution:  fixed =>

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  ddurham
 
Status:  closed| Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:  fixed |  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by ckd):

 * cc: ckd (added)
  * status:  assigned => closed
  * resolution:  => fixed

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  ddurham
 
Status:  assigned  | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by danaspiegel):

 I haven't had time to put together a patch (nor am I sure this is the best
 way to do this) but here's the code:

 {{{
 def GET(self, request, page_key):
 """
 Initialize a form if necessary, and display the form/page
 identified by
 page_key.
 """
 page_data = self._get_cleaned_data(request, page_key)
 if page_data is None:
 form = self._get_form_classes(request)[page_key]()
 else:
 form_class = self._get_form_classes(request)[page_key]
 if issubclass(form_class, forms.ModelForm):
 # We need to manually create a new instance of the form's
 model, since we need to specially handle ManyToMany fields
 instance = form_class.Meta.model()
 for attribute_name, attribute_value in page_data.items():
 if hasattr(instance, attribute_name):
 setattr(instance, attribute_name, attribute_value)
 if isinstance(attribute_value, base.Model):
 # when the related object is a model object,
 we need to explicitly set the form field's value
 page_data[attribute_name] = attribute_value.pk
 elif isinstance(getattr(form_class.Meta.model,
 attribute_name), fields.related.ReverseSingleRelatedObjectDescriptor):
 page_data[attribute_name] = attribute_value.pk
 elif isinstance(getattr(form_class.Meta.model,
 attribute_name), fields.related.ReverseManyRelatedObjectsDescriptor):
 page_data[attribute_name] = [value.pk for value in
 attribute_value]
 form = form_class(instance=instance, initial=page_data)
 else:
 form = form_class(initial=page_data)

 return self._show_form(request, page_key, form)

 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  ddurham
 
Status:  assigned  | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by ddurham):

  * owner:  nobody => ddurham
  * status:  new => assigned

Comment:

 Replying to [comment:23 danaspiegel]:
 > In implementing this code (ddurham, thanks for providing it!), I ran
 into an issue where the usage of ModelForms doesn't work properly when
 stepping back to previous pages. Specifically, when using either
 ForeignKey or ManyToMany relationships, you cannot use the cleaned data to
 re-create new versions of the model instance since the representation of
 the form data for these two field types is different from the way you set
 __init__ data. I've fixed the code to work for my usage, and will try to
 post the changes (though I don't know if they cover all cases or are
 implemented appropriately.
 >
 > I believe this issue must be fixed before this patch is accepted.

 I think I ran into this issue as well.  You can see in the GET method
 where I check if the form is a model form and do things a little
 differently.

 333 if issubclass(form_class, forms.ModelForm):
 334 form =
 form_class(instance=form_class.Meta.model(**page_data))
 335 else:
 336 form = form_class(initial=page_data)


 Where page_data is the cleaned_data.  If you had to do something
 different, could you post your code?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by danaspiegel):

 In implementing this code (ddurham, thanks for providing it!), I ran into
 an issue where the usage of ModelForms doesn't work properly when stepping
 back to previous pages. Specifically, when using either ForeignKey or
 ManyToMany relationships, you cannot use the cleaned data to re-create new
 versions of the model instance since the representation of the form data
 for these two field types is different from the way you set __init__ data.
 I've fixed the code to work for my usage, and will try to post the changes
 (though I don't know if they cover all cases or are implemented
 appropriately.

 I believe this issue must be fixed before this patch is accepted.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by ubernostrum):

  * milestone:  1.2 =>

Comment:

 1.2 is feature-frozen, moving this feature request off the milestone.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody 
 
Status:  new   | Milestone:  1.2
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by ddurham):

 Replying to [comment:20 danaspiegel]:
 > Seeing as 1.2 is almost ready to be released, is there any chance that
 this patch will see the light of day in 1.2? I know its on the low-
 priority list, but I would love to know whether I should wait for it, or
 just forge ahead with my own solution.

 You can just take the code and use it outside of the django namespace,
 since this feature won't make it into the 1.2 release.  Or forge ahead
 with your own of course.

 > Also, is there any indication about solving this issue for ModelForms,
 and not just regular Forms?

 The patch that I submitted works with ModelForms.  At least the model
 forms I tested it with.  Someone else had a pickling error with field
 sets, but I was not able to reproduce that problem.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody 
 
Status:  new   | Milestone:  1.2
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by danaspiegel):

 Seeing as 1.2 is almost ready to be released, is there any chance that
 this patch will see the light of day in 1.2? I know its on the low-
 priority list, but I would love to know whether I should wait for it, or
 just forge ahead with my own solution.

 Also, is there any indication about solving this issue for ModelForms, and
 not just regular Forms?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody 
 
Status:  new   | Milestone:  1.2
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by iElectric):

 * cc: do...@dev.si (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody 
 
Status:  new   | Milestone:  1.2
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by iElectric):

 Note about my usage of Nate's Session based Wizard:

 I needed option to not fill all forms until the last one, so I had to
 change the following parts:
 - in finish() form validation, force is_bound=True to override django
 default behaviour making empty forms not valid
 - add request parameter to is_last() function in order to inspect
 unexpected wizard finish

 Also note the following, which is very imporatant:
 - django upload handlers use cStringIO object which is NOT pickle-able.
 Use StringIO.StringIO instead.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody 
 
Status:  new   | Milestone:  1.2
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Accepted  | Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by jezdez):

  * stage:  Design decision needed => Accepted
  * milestone:  => 1.2

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Design decision needed| Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by Nate):

 * cc: n...@natesoares.com (added)

Comment:

 I rolled one of these for myself a while back, and noticed that it was on
 the 1.1 wishlist. I see there's already a patch here, but you guys may
 find this implementation helpful. You can find a copy
 [http://natesoares.com/media/uploads/wizard.html here]. I'd upload it
 here, but I'm not sure it will be useful and I don't want to add clutter.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Design decision needed| Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by anonymous):

 It fails with PicklingError if there are any formsets in the forms

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Design decision needed| Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by ddurham):

 Replying to [comment:11 jacob]:
 > There's a fair bit of duplicate code here. A better approach would be an
 abstract wizard base class and concrete hidden-form and session-based
 subclasses.

 Can you give me some more pointers to any methods you have in mind.  I'm
 happy to make the changes, just don't immediately specific enough
 commonality.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Design decision needed| Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Comment (by jacob):

 There's a fair bit of duplicate code here. A better approach would be an
 abstract wizard base class and concrete hidden-form and session-based
 subclasses.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody 
 
Status:  new   | Milestone: 
 
 Component:  django.contrib.formtools  |   Version:  SVN
 
Resolution:|  Keywords:  session wizard 
forms
 Stage:  Design decision needed| Has_patch:  1  
 
Needs_docs:  0 |   Needs_tests:  0  
 
Needs_better_patch:  0 |  
---+
Changes (by donspaulding):

 * cc: [EMAIL PROTECTED] (added)

Comment:

 I haven't fully looked over the approach you've taken here, but I thought
 I might share what I've done here at work along these lines.  I've put my
 [http://www.djangosnippets.org/snippets// SessionFormWizard up on
 DjangoSnippets.org], in case there are any ideas to be taken from it.
 I'll give this a more thorough look soon though and leave comments when
 appropriate.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.formtools  |   Version:  SVN   
Resolution:|  Keywords:  session wizard
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Changes (by [EMAIL PROTECTED]):

 * cc: [EMAIL PROTECTED] (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.formtools  |   Version:  SVN   
Resolution:|  Keywords:  session wizard
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Comment (by ddurham):

 That's a nice feature, so I'm working on adding it along side the current
 list init.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.formtools  |   Version:  SVN   
Resolution:|  Keywords:  session wizard
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  0 
Needs_better_patch:  1 |  
---+
Changes (by edcrypt):

  * needs_better_patch:  0 => 1
  * needs_tests:  1 => 0

Comment:

 Instead of passing a list of forms (the form_list argument on
 SessionWizard.__init__()), would be nice if we could pass a sequence in
 the format:

 {{{
 (('step_slug', Form), ...)
 }}}

 Instead of {{{r'wizard/(?P\d+)/$'}}}, that'd be
 {{{r'wizard/(?P\w+)/$'}}}.
 The form_list can be tuned on a dict ({{{ {'step_slug': Form, ...} }}})
 doing {{{ form_dict = dict(form_list) }}}, as you need to get the form
 given the url argument.

 This change would allow us to have wizards with named pages, not just
 numbered.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.formtools  |   Version:  SVN   
Resolution:|  Keywords:  session wizard
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  1 
Needs_better_patch:  0 |  
---+
Comment (by [EMAIL PROTECTED]):

 I'm certainly interested; I've hacked the normal form wizard a bit to
 allow previews by putting the final POST into the session and redirecting
 to a new page with a submit-button and a dump of the data. (Oh and wizards
 which can take ModelForms with instances of course... can't have a wizard
 to change anything without that.)

 What would be really nice is to allow each page/slide of the wizard to
 have its own url, then supporting forward/back would be trivially easy.
 Not needed for simple survey-things of course but handy when the wizard is
 "windows"-style, used to configure something.

 I've yet to see a need to dynamically change a wizard too.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

Re: [Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
---+
  Reporter:  ddurham   | Owner:  nobody
Status:  new   | Milestone:
 Component:  django.contrib.formtools  |   Version:  SVN   
Resolution:|  Keywords:  session wizard
 Stage:  Design decision needed| Has_patch:  1 
Needs_docs:  1 |   Needs_tests:  1 
Needs_better_patch:  0 |  
---+
Changes (by edcrypt):

 * cc: [EMAIL PROTECTED] (added)
  * needs_better_patch:  => 0
  * stage:  Unreviewed => Design decision needed
  * needs_tests:  => 1
  * needs_docs:  => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---

[Django] #9200: Add a session based form wizard

[Django]

#9200: Add a session based form wizard
--+-
 Reporter:  ddurham   |   Owner:  nobody
   Status:  new   |   Milestone:
Component:  django.contrib.formtools  | Version:  SVN   
 Keywords:  session wizard|   Stage:  Unreviewed
Has_patch:  1 |  
--+-
 The provided patch adds a class that can be extended to create form
 wizards that:

 1) Use GETs for form displays (except in the case of validation errors)
 and POSTs for form submissions.
 2) Successful POSTs are redirected to GET the next page in the wizard.
 This removes the POST from browser history so that back and refresh pretty
 much just work.

 I have provided plenty of methods that can be overridden for customization
 purposes.  Right now, I think I'm probably storing too much info in the
 session scope, in particular request.POST data, cleaned_data, and other
 things.  I have not tested with multipart form data.  I do not have
 documentation or tests, just wanted to see if you're interested in having
 this in contrib.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~--~~~~--~~--~--~---