Re: [Django] #30237: django.contrib.admin checks for django.contrib.auth.middleware.AuthenticationMiddleware, breaking custom authentication middleware from 2.1

2019-03-05 Thread Django 
#30237: django.contrib.admin checks for
django.contrib.auth.middleware.AuthenticationMiddleware, breaking custom
authentication middleware from 2.1
-+
 Reporter:  Alek Ratzloff|Owner:  hermansc
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by Simon Charette):

 * severity:  Normal => Release blocker
 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * has_patch:  0 => 1
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the PR. I left a few comments for improvements on the PR.
 Please uncheck ''patch needs improvement'' and ''needs tests'' once they
 are addressed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c10370bf7ead56a4c6ffab30d6007941%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30237: django.contrib.admin checks for django.contrib.auth.middleware.AuthenticationMiddleware, breaking custom authentication middleware from 2.1

2019-03-05 Thread Django 
#30237: django.contrib.admin checks for
django.contrib.auth.middleware.AuthenticationMiddleware, breaking custom
authentication middleware from 2.1
---+--
 Reporter:  Alek Ratzloff  |Owner:  hermansc
 Type:  Uncategorized  |   Status:  assigned
Component:  contrib.admin  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by hermansc):

 * owner:  nobody => hermansc
 * status:  new => assigned


Comment:

 I created a pull request with a possible solution to this issue.
 Reproduced the issue and tested that the patch worked for me:
 https://github.com/django/django/pull/11057

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1eea3f15a103a3d71af9c2bddfe3915f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30237: django.contrib.admin checks for django.contrib.auth.middleware.AuthenticationMiddleware, breaking custom authentication middleware from 2.1

2019-03-05 Thread Django 
#30237: django.contrib.admin checks for
django.contrib.auth.middleware.AuthenticationMiddleware, breaking custom
authentication middleware from 2.1
---+--
 Reporter:  Alek Ratzloff  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  contrib.admin  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Simon Charette):

 Agreed, `import_string` should  be used to perform `issubclass` checks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7d7e98f6436bbce21145f97b174ce2d0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30237: django.contrib.admin checks for django.contrib.auth.middleware.AuthenticationMiddleware, breaking custom authentication middleware from 2.1

2019-03-05 Thread Django 
#30237: django.contrib.admin checks for
django.contrib.auth.middleware.AuthenticationMiddleware, breaking custom
authentication middleware from 2.1
---+--
 Reporter:  Alek Ratzloff  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  contrib.admin  |  Version:  2.2
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--

Comment (by Tim Graham):

 The check is new in Django 2.2 (371ece2f0682e51f2f796854d3e091827a7cea63).
 It might be possible to modify it so that it detects
 `AuthenticationMiddleware` subclasses. You could also simply add that
 error to your `SILENCED_SYSTEM_CHECKS` setting.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d839c41baa14ce0d4fbe2babac261c87%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30237: django.contrib.admin checks for django.contrib.auth.middleware.AuthenticationMiddleware, breaking custom authentication middleware from 2.1

2019-03-05 Thread Django 
#30237: django.contrib.admin checks for
django.contrib.auth.middleware.AuthenticationMiddleware, breaking custom
authentication middleware from 2.1
-+
   Reporter:  Alek Ratzloff  |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  contrib.admin  |Version:  2.2
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 I am attempting an upgrade from 2.1 to 2.2b1. I have a custom middleware
 in place for authentication which essentially wraps around the base
 AuthenticationMiddleware and sets/unsets a cookie upon login and logout.
 This was working with Django 2.1 as my authentication middleware.

 Now, when I attempt to start my application, the check fails with
 admin.E408:

 ?: (admin.E408) 'django.contrib.auth.middleware.AuthenticationMiddleware'
 must be in MIDDLEWARE in order to use the admin application.

 Is this a bug/regression, or have I been using the middleware incorrectly
 this whole time?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.e96493efff558d8c3a0b61fb871d2129%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.