Re: [Django] #30245: Run tests matching a filter (Python 3.7 -k option)

[Django]

#30245: Run tests matching a filter (Python 3.7 -k option)
-+-
 Reporter:  François Freitag |Owner:  François
 |  Freitag
 Type:  New feature  |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
  test,unittest,filter   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"568eed9e79470b9ddf3e1b3bbad9123ada45eae8" 568eed9]:
 {{{
 #!CommitTicketReference repository=""
 revision="568eed9e79470b9ddf3e1b3bbad9123ada45eae8"
 Fixed #30245 -- Added -k option to DiscoverRunner.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.4e81070dfdc2ffcb8c21ed8b6a2ca496%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30245: Run tests matching a filter (Python 3.7 -k option)

[Django]

#30245: Run tests matching a filter (Python 3.7 -k option)
-+-
 Reporter:  François Freitag |Owner:  François
 |  Freitag
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
  test,unittest,filter   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jon Dufresne):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.04eb00ad7a74834019c686ff8b4a9576%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30245: Run tests matching a filter (Python 3.7 -k option)

[Django]

#30245: Run tests matching a filter (Python 3.7 -k option)
-+-
 Reporter:  François Freitag |Owner:  François
 |  Freitag
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  test,unittest,filter   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by François Freitag):

 * needs_better_patch:  1 => 0


Comment:

 Following mailing list consensus to remove the `-k` shorthand for
 `--keepdb` without replacement, the
 [https://github.com/django/django/pull/11067 PR] has been updated and uses
 `-k` to select tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.c62a31bf8de1c42be40abdf395265e71%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30245: Run tests matching a filter (Python 3.7 -k option)

[Django]

#30245: Run tests matching a filter (Python 3.7 -k option)
-+-
 Reporter:  François Freitag |Owner:  François
 |  Freitag
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  test,unittest,filter   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by François Freitag):

 Mailing list thread: https://groups.google.com/forum/#!topic/django-
 developers/6NcMRULpBYw

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.179a0a14a3d2e885b208b8d3939be239%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30245: Run tests matching a filter (Python 3.7 -k option)

[Django]

#30245: Run tests matching a filter (Python 3.7 -k option)
-+-
 Reporter:  François Freitag |Owner:  François
 |  Freitag
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  test,unittest,filter   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


Comment:

 Marking "Patch needs improvement" until we hear back from the mailing list
 discussion.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.74ad06070657010e6d4134a87592726b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30245: Run tests matching a filter (Python 3.7 -k option)

[Django]

#30245: Run tests matching a filter (Python 3.7 -k option)
-+-
 Reporter:  François Freitag |Owner:  François
 |  Freitag
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  test,unittest,filter   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by François Freitag):

 Hi Carlton,

 Thank you for looking into this ticket. I'll present the case to the
 mailing list today or tomorrow.

 Cheers,

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.5f8e5ac0c14a0d52caa4c1c355541edc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30245: Run tests matching a filter (Python 3.7 -k option)

[Django]

#30245: Run tests matching a filter (Python 3.7 -k option)
-+-
 Reporter:  François Freitag |Owner:  François
 |  Freitag
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  test,unittest,filter   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Unreviewed => Accepted


Comment:

 Hi François. Yes, this seems a good addition to me.

 > ... `-k` is already the short-hand for ...

 My initial thought here would be to ''re-take'' `-k` to match `unittest`.
 I'm pretty sure us having contrary flags is just going to be a royal-pain
 forever.
 A small-BC change there is preferably.

 "We're adding `-k` to mean ... following `unittest`. Use long `--keepdb`
 flag instead." — but maybe people want a short flag too. (???)

 I guess we need to ask on the DevelopersMailingList. Can I ask you to post
 there to begin the discussion? (I can do it if you don't have a moment.)

 Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.f23ca2c2b91368d98261c91e4422bcc1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30245: Run tests matching a filter (Python 3.7 -k option)

[Django]

#30245: Run tests matching a filter (Python 3.7 -k option)
-+-
 Reporter:  François Freitag |Owner:  François
 |  Freitag
 Type:  New feature  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
  test,unittest,filter   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by François Freitag):

 [https://github.com/django/django/pull/11067 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/073.94bcbd89b2f8de105f79ad379d0ae2e5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

[Django] #30245: Run tests matching a filter (Python 3.7 -k option)

[Django]

#30245: Run tests matching a filter (Python 3.7 -k option)
-+-
   Reporter:  François   |  Owner:  François Freitag
  Freitag|
   Type:  New| Status:  assigned
  feature|
  Component:  Testing|Version:  master
  framework  |   Keywords:
   Severity:  Normal |  test,unittest,filter
   Triage Stage: |  Has patch:  1
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 With Python 3.7, the `unittest` module got a `-k` option (as in keyword),
 to run tests matching a given keyword. Corresponding entry in the
 [https://docs.python.org/3.7/whatsnew/3.7.html#unittest Python 3.7
 unittest release note entry]. Associated python issue:
 https://bugs.python.org/issue32071.

 The feature seems to be coming from the `py.test` project feature
 [https://docs.pytest.org/en/latest/usage.html#specifying-tests-selecting-
 tests running tests by keyword expression]. The feature is also available
 in other testing frameworks, such as `PHPUnit`'s
 [https://phpunit.de/manual/6.5/en/textui.html --filter] option.

 Adding a similar feature to Django would facilitate test selection. Since
 `-k` is already the short-hand for `--keepdb`, it may make more sense to
 implement another flag, maybe `--filter`?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/058.9f7d118fca4442817af55492c18c7047%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.