Re: [Django] #31623: timesince 'depth' parameter

[Django]

#31623: timesince 'depth' parameter
-+-
 Reporter:  Toby Such|Owner:  Tim Park
 Type:  New feature  |   Status:  closed
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  timesince| Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8fa9a6d29efe2622872b4788190ea7c1bcb92019" 8fa9a6d]:
 {{{
 #!CommitTicketReference repository=""
 revision="8fa9a6d29efe2622872b4788190ea7c1bcb92019"
 Fixed #31623 -- Allowed specifying number of adjacent time units in
 timesince()/timeuntil().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.1917c9ea44cbd084fd058cd49c422bd6%40djangoproject.com.

Re: [Django] #31623: timesince 'depth' parameter

[Django]

#31623: timesince 'depth' parameter
-+-
 Reporter:  Toby Such|Owner:  Tim Park
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  timesince| Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 Refactoring (if necessary) can be done in a separate PR/ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.bd7c67e1721dfb132c9e11758955867b%40djangoproject.com.

Re: [Django] #31623: timesince 'depth' parameter

[Django]

#31623: timesince 'depth' parameter
-+
 Reporter:  Toby Such|Owner:  Tim Park
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  timesince| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9508ee80dc11ed9015faf70b2a8a8b1c%40djangoproject.com.

Re: [Django] #31623: timesince 'depth' parameter

[Django]

#31623: timesince 'depth' parameter
-+
 Reporter:  Toby Such|Owner:  Tim Park
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  timesince| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by David Smith):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/13145 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cc6e8593ac2bdcaf92e07f5583fdf2ba%40djangoproject.com.

Re: [Django] #31623: timesince 'depth' parameter

[Django]

#31623: timesince 'depth' parameter
-+
 Reporter:  Toby Such|Owner:  Tim Park
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  timesince| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by Tim Park):

 * owner:  Toby Such => Tim Park


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f6a7b344a722b6b56ff1cc79d46adc53%40djangoproject.com.

Re: [Django] #31623: timesince 'depth' parameter

[Django]

#31623: timesince 'depth' parameter
-+-
 Reporter:  Toby Such|Owner:  Toby Such
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  timesince| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Tim Park):

 Replying to [comment:1 Toby Such]:

 Hey Toby!

 I started writing some of the core functionality needed for us to
 implement a depth feature. I'm happy to either (1) touch base with you
 before going any further or (2) take over this ticket completely.

 Let me know.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.0f8a2b9de9c7e467c6518bc8a642e896%40djangoproject.com.

Re: [Django] #31623: timesince 'depth' parameter

[Django]

#31623: timesince 'depth' parameter
-+-
 Reporter:  Toby Such|Owner:  Toby Such
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  timesince| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Description changed by Toby Such:

Old description:

> The timesince function is a bit limiting as it is right now. A `depth`
> parameter should be added to configure how many values are shown. The
> depth parameter should be defaulted to 2 as this is how the current
> implementation behaves. The existing rule of values having to be adjacent
> to one another should still remain.
>
> The logic for calculating the time since, before formatting should also
> be pulled out of the function and placed in its own so that custom
> implementations can be created.
>
> For example:
> With a depth of one it should always display as "1 week" or "3 years"
> etc.
> With a depth of two: "1 week, 3 days" or "3 years, 7 months"
> With a depth of three: "1 week, 3 days, 5 hours" or "3 years, 7 months, 2
> weeks"

New description:

 Discussed [https://groups.google.com/forum/#!topic/django-developers
 /pEaX5X-wpWo here]. The timesince function is a bit limiting as it is
 right now. A `depth` parameter should be added to configure how many
 values are shown. The depth parameter should be defaulted to 2 as this is
 how the current implementation behaves. The existing rule of values having
 to be adjacent to one another should still remain.

 The logic for calculating the time since, before formatting should also be
 pulled out of the function and placed in its own so that custom
 implementations can be created.

 For example:
 With a depth of one it should always display as "1 week" or "3 years" etc.
 With a depth of two: "1 week, 3 days" or "3 years, 7 months"
 With a depth of three: "1 week, 3 days, 5 hours" or "3 years, 7 months, 2
 weeks"

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7e754b641b9946568c03ea99a288e5a3%40djangoproject.com.

Re: [Django] #31623: timesince 'depth' parameter

[Django]

#31623: timesince 'depth' parameter
-+-
 Reporter:  Toby Such|Owner:  Toby Such
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  timesince| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * stage:  Unreviewed => Accepted


Comment:

 As discussed on the ML, the most important thing is to make it easily
 customizable.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8467e4b56f24c888cdf09a0c1be21a29%40djangoproject.com.

[Django] #31623: timesince 'depth' parameter

[Django]

#31623: timesince 'depth' parameter
---+---
   Reporter:  Toby Such|  Owner:  nobody
   Type:  New feature  | Status:  new
  Component:  Utilities|Version:  master
   Severity:  Normal   |   Keywords:  timesince
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  1
  UI/UX:  0|
---+---
 The timesince function is a bit limiting as it is right now. A `depth`
 parameter should be added to configure how many values are shown. The
 depth parameter should be defaulted to 2 as this is how the current
 implementation behaves. The existing rule of values having to be adjacent
 to one another should still remain.

 The logic for calculating the time since, before formatting should also be
 pulled out of the function and placed in its own so that custom
 implementations can be created.

 For example:
 With a depth of one it should always display as "1 week" or "3 years" etc.
 With a depth of two: "1 week, 3 days" or "3 years, 7 months"
 With a depth of three: "1 week, 3 days, 5 hours" or "3 years, 7 months, 2
 weeks"

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/051.8e306e84c894decb1fee5f34eba34955%40djangoproject.com.

Re: [Django] #31623: timesince 'depth' parameter

[Django]

#31623: timesince 'depth' parameter
-+--
 Reporter:  Toby Such|Owner:  Toby Such
 Type:  New feature  |   Status:  assigned
Component:  Utilities|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  timesince| Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--
Changes (by Toby Such):

 * owner:  nobody => Toby Such
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f765088dc7c051a06d441f186f10cab2%40djangoproject.com.