Re: [Django] #35173: DisallowedModelAdminLookup raised when filtering with __isnull on a ForeignKey not listed in list_filters

2024-02-15 Thread Django
#35173: DisallowedModelAdminLookup raised when filtering with __isnull on a
ForeignKey not listed in list_filters
-+-
 Reporter:  Stian Jensen |Owner:  Hisham
 |  Mahmood
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Natalia <124304+nessita@…>):

 In [changeset:"3a54e64ef7c14946dd072ddc2f4ab9551fe0" 3a54e64e]:
 {{{#!CommitTicketReference repository=""
 revision="3a54e64ef7c14946dd072ddc2f4ab9551fe0"
 [5.0.x] Fixed #35173 -- Fixed ModelAdmin.lookup_allowed() for lookups on
 foreign keys when not included in ModelAdmin.list_filter.

 Regression in f80669d2f5a5f1db9e9b73ca893fefba34f955e7.

 Thanks Sarah Boyce for the review.
 Backport of 8db593de05c3516c939b7d4b9eb91e8791f4c79a from main
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dac7e0522-df26e8cc-6bd9-4212-b520-9c7d639ed50c-00%40eu-central-1.amazonses.com.


Re: [Django] #35173: DisallowedModelAdminLookup raised when filtering with __isnull on a ForeignKey not listed in list_filters

2024-02-15 Thread Django
#35173: DisallowedModelAdminLookup raised when filtering with __isnull on a
ForeignKey not listed in list_filters
-+-
 Reporter:  Stian Jensen |Owner:  Hisham
 |  Mahmood
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dac7a69e7-78e73a3a-c73d-4a3d-a465-a10582c0b423-00%40eu-central-1.amazonses.com.


Re: [Django] #35173: DisallowedModelAdminLookup raised when filtering with __isnull on a ForeignKey not listed in list_filters

2024-02-14 Thread Django
#35173: DisallowedModelAdminLookup raised when filtering with __isnull on a
ForeignKey not listed in list_filters
-+-
 Reporter:  Stian Jensen |Owner:  Hisham
 |  Mahmood
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed

Comment:

 In [changeset:"8db593de05c3516c939b7d4b9eb91e8791f4c79a" 8db593de]:
 {{{#!CommitTicketReference repository=""
 revision="8db593de05c3516c939b7d4b9eb91e8791f4c79a"
 Fixed #35173 -- Fixed ModelAdmin.lookup_allowed() for lookups on foreign
 keys when not included in ModelAdmin.list_filter.

 Regression in f80669d2f5a5f1db9e9b73ca893fefba34f955e7.

 Thanks Sarah Boyce for the review.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018daa6272f6-8a3e0905-f58a-48de-b1be-96a26011d6c3-00%40eu-central-1.amazonses.com.


Re: [Django] #35173: DisallowedModelAdminLookup raised when filtering with __isnull on a ForeignKey not listed in list_filters

2024-02-11 Thread Django
#35173: DisallowedModelAdminLookup raised when filtering with __isnull on a
ForeignKey not listed in list_filters
-+-
 Reporter:  Stian Jensen |Owner:  Hisham
 |  Mahmood
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Hisham Mahmood):

 * needs_better_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d991b7a1d-bf58550d-6fc0-4420-b06b-1012e026e748-00%40eu-central-1.amazonses.com.


Re: [Django] #35173: DisallowedModelAdminLookup raised when filtering with __isnull on a ForeignKey not listed in list_filters

2024-02-09 Thread Django
#35173: DisallowedModelAdminLookup raised when filtering with __isnull on a
ForeignKey not listed in list_filters
-+-
 Reporter:  Stian Jensen |Owner:  Hisham
 |  Mahmood
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * needs_better_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d8eef21b6-7dfdee57-dd01-4a25-8dd4-4e957e0274d8-00%40eu-central-1.amazonses.com.


Re: [Django] #35173: DisallowedModelAdminLookup raised when filtering with __isnull on a ForeignKey not listed in list_filters

2024-02-09 Thread Django
#35173: DisallowedModelAdminLookup raised when filtering with __isnull on a
ForeignKey not listed in list_filters
-+-
 Reporter:  Stian Jensen |Owner:  Hisham
 |  Mahmood
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Hisham Mahmood):

 * needs_docs:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d8e18d883-91b46482-9af5-40fb-86c6-7327fd881395-00%40eu-central-1.amazonses.com.


Re: [Django] #35173: DisallowedModelAdminLookup raised when filtering with __isnull on a ForeignKey not listed in list_filters

2024-02-09 Thread Django
#35173: DisallowedModelAdminLookup raised when filtering with __isnull on a
ForeignKey not listed in list_filters
-+-
 Reporter:  Stian Jensen |Owner:  Hisham
 |  Mahmood
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Hisham Mahmood):

 * needs_docs:  0 => 1
 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d8dd77cf3-a87baaa7-184c-480b-aecd-f6668eea0f15-00%40eu-central-1.amazonses.com.


Re: [Django] #35173: DisallowedModelAdminLookup raised when filtering with __isnull on a ForeignKey not listed in list_filters

2024-02-09 Thread Django
#35173: DisallowedModelAdminLookup raised when filtering with __isnull on a
ForeignKey not listed in list_filters
-+-
 Reporter:  Stian Jensen |Owner:  Hisham
 |  Mahmood
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Hisham Mahmood):

 [https://github.com/django/django/pull/17844 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d8dd48246-0f0d8a35-490e-4a7d-b22d-26ab427a23b4-00%40eu-central-1.amazonses.com.


Re: [Django] #35173: DisallowedModelAdminLookup raised when filtering with __isnull on a ForeignKey not listed in list_filters

2024-02-08 Thread Django
#35173: DisallowedModelAdminLookup raised when filtering with __isnull on a
ForeignKey not listed in list_filters
-+-
 Reporter:  Stian Jensen |Owner:  Hisham
 |  Mahmood
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Hisham Mahmood):

 * owner:  nobody => Hisham Mahmood
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d88caba71-c5d56a98-4438-44d7-abc7-663ac9e4a4ea-00%40eu-central-1.amazonses.com.


Re: [Django] #35173: DisallowedModelAdminLookup raised when filtering with __isnull on a ForeignKey not listed in list_filters

2024-02-07 Thread Django
#35173: DisallowedModelAdminLookup raised when filtering with __isnull on a
ForeignKey not listed in list_filters
-+
 Reporter:  Stian Jensen |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  5.0
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Mariusz Felisiak):

 * cc: Sarah Boyce (added)
 * type:  Uncategorized => Bug
 * component:  Uncategorized => contrib.admin
 * severity:  Normal => Release blocker
 * stage:  Unreviewed => Accepted

Comment:

 Thanks for the report.

 Regression in f80669d2f5a5f1db9e9b73ca893fefba34f955e7 (Django 5.0.1)
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d87219684-d508f291-76d9-4bb9-96ac-90de2ead888d-00%40eu-central-1.amazonses.com.


[Django] #35173: DisallowedModelAdminLookup raised when filtering with __isnull on a ForeignKey not listed in list_filters

2024-02-07 Thread Django
#35173: DisallowedModelAdminLookup raised when filtering with __isnull on a
ForeignKey not listed in list_filters
-+
   Reporter:  Stian Jensen   |  Owner:  nobody
   Type:  Uncategorized  | Status:  new
  Component:  Uncategorized  |Version:  5.0
   Severity:  Normal |   Keywords:
   Triage Stage:  Unreviewed |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+
 A regression in Django 5.0 was previously reported and fixed, relating to
 filtering foreign keys in django-admin in the URL, when not manually
 declared in list_filters:
 https://code.djangoproject.com/ticket/35087

 There is at least one more issue I'm still having, that is still
 problematic in Django 5.0.2:

 Filtering by whether or not a foreign key value is set also used to work
 for any foreign key on the model.
 `/admin/core/invoice/?client__isnull=True`

 In Django 5.0.2 this provides an error similar to the error reported in
 35087.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d831ec465-dd5ef578-1288-4498-a3f6-bd9a6e7d8982-00%40eu-central-1.amazonses.com.