Re: [Django] #35222: Update tablespaces tests

[Django]

#35222: Update tablespaces tests
-+-
 Reporter:  bcail|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:  invalid
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by bcail):

 * resolution:   => invalid
 * status:  new => closed

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc2e33449-3b1204f8-8247-44c7-bb57-8661ea36454f-00%40eu-central-1.amazonses.com.

Re: [Django] #35222: Update tablespaces tests

[Django]

#35222: Update tablespaces tests
-+-
 Reporter:  bcail|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by bcail):

 * resolution:  needsinfo =>
 * status:  closed => new

Comment:

 I opened a [https://github.com/django/django/pull/17882 draft PR]. It
 removes the need for having to change models from unmanaged to managed,
 and tests with and without the DEFAULT_INDEX_TABLESPACE being set.

 If we use these changes, we could also add tests for the
 DEFAULT_TABLESPACE, and update tests in `tests/model_indexes/tests.py`.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dc26ca206-a6991499-d87b-475a-b6df-5894e2c0b53c-00%40eu-central-1.amazonses.com.

Re: [Django] #35222: Update tablespaces tests

[Django]

#35222: Update tablespaces tests
-+-
 Reporter:  bcail|Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Core (Other) |  Version:  dev
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * component:  Database layer (models, ORM) => Core (Other)
 * resolution:   => needsinfo
 * status:  new => closed

Comment:

 As far as I'm aware, you think that these tests should be improved but
 without any concrete proposition. I don't think it's really worth spending
 time on it, but I'm happy to review your patch.

 We can reconsider this decision if you (someone) provide PoC.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018db280ec51-44fb8612-09a9-4df2-b678-0fadf1d68360-00%40eu-central-1.amazonses.com.

Re: [Django] #35222: Update tablespaces tests

[Django]

#35222: Update tablespaces tests
-+-
 Reporter:  bcail|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by bcail:

Old description:

> Tablespaces tests currently have a note saying that DEFAULT_TABLESPACE
> and DEFAULT_INDEX_TABLESPACE can't be tested. The test models are marked
> as unmanaged, then changed to managed, ...
>
> Couldn't we re-write these tests using models defined in the test, so
> these issues would go away? I'm thinking of something like in the schema
> tests.
>
> I came across this issue when working on ticket #20960.
>
> (Note: I had to take out the URLs because they're being rejected as
> "potential spam.")

New description:

 Tablespaces tests currently have a note saying that DEFAULT_TABLESPACE and
 DEFAULT_INDEX_TABLESPACE can't be tested. The test models are marked as
 unmanaged, then changed to managed, ...

 Couldn't we re-write these tests using models defined in the test, so
 these issues would go away? I'm thinking of something like what's used in
 the schema tests.

 I came across this issue when working on ticket #20960.

 (Note: I had to take out the URLs because they're being rejected as
 "potential spam.")

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018db24abdfa-0cc12fb2-5fbf-4bbd-a888-680cf3a50c76-00%40eu-central-1.amazonses.com.

Re: [Django] #35222: Update tablespaces tests

[Django]

#35222: Update tablespaces tests
-+-
 Reporter:  bcail|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Description changed by bcail:

Old description:

> Tablespaces tests currently have a note saying that DEFAULT_TABLESPACE
> and DEFAULT_INDEX_TABLESPACE can't be tested. The test models are marked
> as unmanaged, then changed to managed, ...
>
> Couldn't we re-write these tests using models defined in the test, so
> these issues would go away? I'm thinking of something like in the schema
> tests.
>
> I came across this issue when working on ticket #20960.

New description:

 Tablespaces tests currently have a note saying that DEFAULT_TABLESPACE and
 DEFAULT_INDEX_TABLESPACE can't be tested. The test models are marked as
 unmanaged, then changed to managed, ...

 Couldn't we re-write these tests using models defined in the test, so
 these issues would go away? I'm thinking of something like in the schema
 tests.

 I came across this issue when working on ticket #20960.

 (Note: I had to take out the URLs because they're being rejected as
 "potential spam.")

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018db249e521-a6986d91-57f1-48b2-b43c-53a73ff459b3-00%40eu-central-1.amazonses.com.

[Django] #35222: Update tablespaces tests

[Django]

#35222: Update tablespaces tests
-+-
   Reporter:  bcail  |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |
  Component:  Database   |Version:  dev
  layer (models, ORM)|
   Severity:  Normal |   Keywords:
   Triage Stage: |  Has patch:  0
  Unreviewed |
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
 Tablespaces tests currently have a note saying that DEFAULT_TABLESPACE and
 DEFAULT_INDEX_TABLESPACE can't be tested. The test models are marked as
 unmanaged, then changed to managed, ...

 Couldn't we re-write these tests using models defined in the test, so
 these issues would go away? I'm thinking of something like in the schema
 tests.

 I came across this issue when working on ticket #20960.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018db2479542-2c7ffeac-1f02-4e30-97cf-925bf49f42a0-00%40eu-central-1.amazonses.com.