Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  Mitchina
|
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  modelformset inlineformset |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * needs_better_patch:  0 => 1

Comment:

 Left a small review, please update "Patch needs improvement" to False when
 these changes are applied and I will review more deeply 
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f3da34035-cfbce87b-10e1-4f8a-be0b-05ea1757465c-00%40eu-central-1.amazonses.com.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  Mitchina
|
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  modelformset inlineformset |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mitchina):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0
 * needs_tests:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018e06d2cc07-8cce42bb-2b7b-435a-ac9c-1f0e6f8c7200-00%40eu-central-1.amazonses.com.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  Mitchina
|
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  modelformset inlineformset |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Mitchina):

 I opened a PR (still in draft) to continue the work initiated by Parth
 Patil on: https://github.com/django/django/pull/17905
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ddf03cebf-2adbc0aa-2df6-48b2-b52f-3c72959cb8bb-00%40eu-central-1.amazonses.com.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  Mitchina
|
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  modelformset inlineformset |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mitchina):

 * owner:  Parth Patil => Mitchina

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d3c3d24d9-85fff56a-dfce-4527-adab-d7002f19d630-00%40eu-central-1.amazonses.com.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  Parth
|  Patil
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  modelformset inlineformset |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Asif Saifuddin Auvi):

 Parth, are you willing to complete this for 3.1?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/102.092f4638e3f86667c5f6dc11ec0b7bb6%40djangoproject.com.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  Parth
|  Patil
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  modelformset inlineformset |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Parth Patil):

 Here is a link to the pull request. This is the first iteration of the
 patch so may require some critical review.
 https://github.com/django/django/pull/11481

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/102.72065711effb1ca332536fb438b0acd7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  Parth
|  Patil
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  modelformset inlineformset |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Parth Patil):

 * owner:  nobody => Parth Patil
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/102.2f05ee7fb28df8431e541ed691fd4726%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  auvipy
    |
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  modelformset inlineformset |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by auvipy):

 Replying to [comment:10 timgraham]:
 > I don't know that deprecating the factory functions (at least
 immediately) is a good idea. This could cause a lot of annoying churn for
 large projects.

 Then I should keep them [factory function/s] for this patch in WIP

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/102.8959c31f5b19707cd32bebc1ae6c0d5c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  auvipy
    |
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  modelformset inlineformset |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 I don't know that deprecating the factory functions (at least immediately)
 is a good idea. This could cause a lot of annoying churn for large
 projects.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/102.522602e88eb16c7556938418904035fa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  auvipy
    |
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  modelformset inlineformset |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by auvipy):

 Replying to [comment:4 bpeschier]:
 > Ok, so I missed this one O:)
 >
 > I disagree with the implementation in the patch, no !MetaClass is needed
 and just simple additions to the class definitions to make it work, maybe
 with the exception of !InlineFormSet. Will attach a patch later on.

 I saw your patch, and willing to implement it cleanly against master
 branch with a pull request.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/102.3a9eaefefc2acc707ad2538a6244021c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  auvipy
    |
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  modelformset inlineformset |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by auvipy):

 will restart work on the ticket. the attached patch need some clean up to
 work on master. I'm targeting this to be completed before 1.10 features
 freeze.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/102.5a6a9595afad54cdc17727594de6fd9a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  auvipy
    |
 Type:  New feature  |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
  modelformset inlineformset |
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by auvipy):

 * owner:  nobody => auvipy
 * status:  new => assigned


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/102.9348397e6842d6854834ff0f2e27c07c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  nobody
    |   Status:  new
 Type:  New feature  |  Version:  master
Component:  Forms|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  formset  |  Needs documentation:  1
  modelformset inlineformset |  Patch needs improvement:  1
Has patch:  1|UI/UX:  0
  Needs tests:  1|
Easy pickings:  0|
-+-
Changes (by carljm):

 * stage:  Design decision needed => Accepted


Comment:

 The current factory-function implementation of formsets is unnecessarily
 confusing to new users, and unlike anything else in Django. It can also
 cause obscure issues with things that should "just work" (see e.g.
 http://stackoverflow.com/questions/622982/django-passing-custom-form-
 parameters-to-formset/624013#624013). It's ironic that we provide
 declarative syntax for things like models and forms where it requires
 metaclass magic, but in the case of formsets where a declarative syntax is
 a simple matter of normal Python subclassing, we don't :-)

 Haven't reviewed the latest patch in depth, but the broad strokes look
 correct to me.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
 Reporter:  Koen Biermans|Owner:  nobody
    |   Status:  new
 Type:  New feature  |  Version:  master
Component:  Forms|   Resolution:
 Severity:  Normal   | Triage Stage:  Design
 Keywords:  formset  |  decision needed
  modelformset inlineformset |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by rasca):

 Adding a comment from #16289:

 > This would be very useful for a nicer implementation of the formset
 derived cbv #16256.
 >
 > The BaseInlineFormSet? is the only tricky one with the
 _get_foreign_key() and the max_num override when fk.unique=True .
 >
 > I'd also move the defaults (e.g. extra=3) to the BaseFormSet? and make
 the factories only pass dict keys whose value isn't None to type().

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
   Reporter:  Koen   |  Owner:  nobody
  Biermans  | Status:  new
   Type:  New|  Component:  Forms
  feature|   Severity:  Normal
  Milestone: |   Keywords:  formset
Version:  SVN|  modelformset inlineformset
 Resolution: |  Has patch:  1
   Triage Stage:  Design |Needs tests:  1
  decision needed|  Easy pickings:  0
Needs documentation:  1  |
Patch needs improvement:  1  |
  UI/UX:  0  |
-+-

Comment (by bpeschier):

 Ok, so I missed this one O:)

 I disagree with the implementation in the patch, no !MetaClass is needed
 and just simple additions to the class definitions to make it work, maybe
 with the exception of !InlineFormSet. Will attach a patch later on.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #10403: provide declarative syntax to define FormSets - including ModelFormSet and InlineFormSet (was: provide declarative syntax to define ModelFormSet and InlineFormSet)

[Django]

#10403: provide declarative syntax to define FormSets - including ModelFormSet 
and
InlineFormSet
-+-
   Reporter:  Koen   |  Owner:  nobody
  Biermans  | Status:  new
   Type:  New|  Component:  Forms
  feature|   Severity:  Normal
  Milestone: |   Keywords:  formset
Version:  SVN|  modelformset inlineformset
 Resolution: |  Has patch:  1
   Triage Stage:  Design |Needs tests:  1
  decision needed|  Easy pickings:  0
Needs documentation:  1  |
Patch needs improvement:  1  |
  UI/UX:  0  |
-+-
Changes (by melinath):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * easy:   => 0
 * keywords:  modelformset inlineformset => formset modelformset
   inlineformset
 * needs_docs:  0 => 1
 * ui_ux:   => 0


Comment:

 Closed #16289 as a duplicate - it proposed essentially the same thing as
 this ticket, but included all !FormSets, not just !ModelFormSets. Hence
 I'm widening the scope of this a little. (Also marking as needs tests
 since the tests in the patch are doctests.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.