Re: [Django] #16063: Problem with searching in m2m fields in inherited model

[Django]

#16063: Problem with searching in m2m fields in inherited model
-+-
 Reporter:  Evgeny Sizikov   |Owner:  Jacob
 Type:   |  Walls
  Cleanup/optimization   |   Status:  assigned
Component:  contrib.admin|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * owner:  nobody => Jacob Walls
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.51b7c40e15ff02bd76e1851bb36db502%40djangoproject.com.

Re: [Django] #16063: Problem with searching in m2m fields in inherited model

[Django]

#16063: Problem with searching in m2m fields in inherited model
--+
 Reporter:  Evgeny Sizikov|Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.admin |  Version:  1.2
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  1 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by goblinJoel):

 * cc: goblinJoel (added)


Comment:

 This is old, but I think it's a good idea. It's still a problem in Django
 1.11, and I didn't see any changes in the 2.x code that looked relevant.
 It can end up devouring storage space larger than the db itself and suck
 up CPU to the point where the database system becomes unresponsive or runs
 out of storage.

 I'm not sure whether I should be making unilateral edits, so I suggest
 renaming to something like:
 **Multi-word admin searches hang with foreign keys in search_fields**

 Related:
 * https://github.com/django/django/pull/7277 with a similar solution
 * https://groups.google.com/forum/#!topic/django-developers/V8M49P326dI
 thread related to above PR
 * https://code.djangoproject.com/ticket/27864 more recent attempt to
 mitigate by limiting how many search terms you can use

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.26377d5b87fa0f63a5f44011633c041e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16063: Problem with searching in m2m fields in inherited model

[Django]

#16063: Problem with searching in m2m fields in inherited model
-+-
   Reporter:  esizikov   |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |  Component:  contrib.admin
  Milestone: |   Severity:  Normal
Version:  1.2|   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  1
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
-+-

Comment (by esizikov):

 I have checked with Django 1.3 and can now confirm that the problem is
 still there. Django's ORM in 1.3 still generates SELECT with JOIN's for
 each {{{ qs = qs.filter(...) }}} call, which is going to be made per term
 in a search query.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16063: Problem with searching in m2m fields in inherited model

[Django]

#16063: Problem with searching in m2m fields in inherited model
-+-
   Reporter:  esizikov   |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |  Component:  contrib.admin
  Milestone: |   Severity:  Normal
Version:  1.2|   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  1
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
-+-
Changes (by aaugustin):

 * type:  Bug => Cleanup/optimization


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16063: Problem with searching in m2m fields in inherited model

[Django]

#16063: Problem with searching in m2m fields in inherited model
+---
   Reporter:  esizikov  |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  1.2   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  1
Patch needs improvement:  0 |  Easy pickings:  0
+---
Changes (by aaugustin):

 * needs_tests:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Looking at the code, the part that is modified by the patch is not
 modified in current trunk. The problematic pattern is still there:
 {{{
 for bit in self.query.split():
 ...
 qs = qs.filter(...)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16063: Problem with searching in m2m fields in inherited model

[Django]

#16063: Problem with searching in m2m fields in inherited model
--+---
   Reporter:  esizikov|  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  contrib.admin
Version:  1.2 |   Severity:  Normal
 Resolution:  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  1
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
--+---
Changes (by julien):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 This seems related to #13902 and #15819. Are you able to test if this gets
 fixed by using Django 1.3 or trunk?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.