Re: [Django] #26166: Accessing a widget via an index on a BoundField results in unnecessary iteration

[Django]

#26166: Accessing a widget via an index on a BoundField results in unnecessary
iteration
--+
 Reporter:  seddonym  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Forms |  Version:  1.9
 Severity:  Normal|   Resolution:  fixed
 Keywords:  forms, boundfield | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Please reopen if not.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c89028718b6bb9ce5dca984b7d5317ca%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26166: Accessing a widget via an index on a BoundField results in unnecessary iteration

[Django]

#26166: Accessing a widget via an index on a BoundField results in unnecessary
iteration
--+
 Reporter:  seddonym  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:  forms, boundfield | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by timgraham):

 Does the patch for #27002 solve this?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4bcac4aa9cdb791b8ee6b973b959b8f3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26166: Accessing a widget via an index on a BoundField results in unnecessary iteration

[Django]

#26166: Accessing a widget via an index on a BoundField results in unnecessary
iteration
--+
 Reporter:  seddonym  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:  forms, boundfield | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by bmispelon):

 It might be worth it to effectively cache `BoundField.__iter__()` but in
 your case, can't you use `zip` as a workaround:

 {{{#!python
 for widget, instance in zip(bound_field,
 bound_field.field.queryset.all()):
 instance_widgets.append((instance, copy(widget)))
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.018d350918c6ede6cb0bcc4a4386719b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26166: Accessing a widget via an index on a BoundField results in unnecessary iteration

[Django]

#26166: Accessing a widget via an index on a BoundField results in unnecessary
iteration
--+
 Reporter:  seddonym  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  1.9
 Severity:  Normal|   Resolution:
 Keywords:  forms, boundfield | Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 I'm not sure about this either, but if we have a tested patch we can
 evaluate it.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.fc5e4d5c7ea534fb8df678d31b845701%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.