Re: [Django] #26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage doesn't

[Django]

#26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage 
doesn't
-+
 Reporter:  Seán Hayes   |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Comment (by Adam Zapletal):

 I'm not sure what that would look like since the current behavior seems to
 be expected. Do you want a test showing that the leading slash typo gives
 the expected error message in the `static` templatetag tests? I'm happy to
 help, but I need some guidance.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018db8d928d2-2c0459b1-feed-44a1-b7f8-8d9a4564dc49-00%40eu-central-1.amazonses.com.

Re: [Django] #26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage doesn't

[Django]

#26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage 
doesn't
-+
 Reporter:  Seán Hayes   |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Comment (by Mariusz Felisiak):

 Adam, Can you submit PR with a regression test to prove it's fixed?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018db5f98fa3-365bf574-137a-4174-ba1d-51ac914a2d00-00%40eu-central-1.amazonses.com.

Re: [Django] #26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage doesn't

[Django]

#26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage 
doesn't
-+
 Reporter:  Seán Hayes   |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Adam Zapletal):

 * cc: Adam Zapletal (added)

Comment:

 I tested this in Django v5.0.2, and the error message now takes this form:
 `ValueError: Missing staticfiles manifest entry for '/test.css'`.

 The error message seems plenty clear to me, so I wonder if a change is
 even needed here. Also, it makes sense to me that this only happens with
 `ManifestStaticFilesStorage` since `StaticFilesStorage` doesn't have a
 manifest. The inconsistency between the two storage classes is expected.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018db4509eff-7028b1e9-b442-4fcb-b964-d99645168441-00%40eu-central-1.amazonses.com.

Re: [Django] #26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage doesn't

[Django]

#26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage 
doesn't
-+
 Reporter:  Seán Hayes   |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Matt Deacalion Stevens):

 * owner:  Matt Deacalion Stevens => (none)
 * status:  assigned => new


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e8b560f126a0f2efb69e4f977d8ea28c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage doesn't

[Django]

#26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage 
doesn't
-+-
 Reporter:  SeanHayes|Owner:  Deacalion
 Type:  Bug  |   Status:  assigned
Component:  contrib.staticfiles  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by dsanders11):

 If no one knows of a legitimate use case for absolute paths being passed
 to the static templatetag, it seems like this could be fixed fairly easily
 by raising a `ValueError` in the StaticFileStorage `url` method if the
 path has a leading slash.

 However, while we're on the topic there are some other inconsistencies
 such as for `CachedFileStorage` leading spaces (but no initial slash) in
 DEBUG returns the path with a leading space, where as not in DEBUG chomps
 the leading space. For `StaticFileStorage`  the leading space is always
 URL encoded.

 Seems like a general 'clean_url' method for StaticFileStorage would be
 useful, that strips spaces and raises a `ValueError` for a leading slash.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.2b2ef347c753867dc881493e133ce7af%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage doesn't

[Django]

#26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage 
doesn't
-+-
 Reporter:  SeanHayes|Owner:  Deacalion
 Type:  Bug  |   Status:  assigned
Component:  contrib.staticfiles  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Deacalion):

 * status:  new => assigned
 * cc: matt@… (added)
 * owner:  nobody => Deacalion


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.69774d589cbc62cd89700ff3c2637049%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage doesn't

[Django]

#26329: StaticFilesStorage permits leading slash, CachedStaticFilesStorage 
doesn't
-+
 Reporter:  SeanHayes|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  1.8
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by timgraham):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * component:  Uncategorized => contrib.staticfiles
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 As a note to anyone tackling this, it only happens with `DEBUG = False`.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6c511acf81365c1572bb20e6af6af545%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.