Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:  Accepted
  count annotate aggreagate  |
  order_by   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.47dfa3938205ca4fcf198fe538348e55%40djangoproject.com.

Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:  Accepted
  count annotate aggreagate  |
  order_by   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Can Sarıgöl):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a0b90267cf4c33f280b7f498691a7603%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:  Accepted
  count annotate aggreagate  |
  order_by   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Can Sarıgöl):

 I want to discuss when collecting group by columns why are order by
 columns added into extensions.

 For example:
 Model.objects.values("col_a").annotate(max=Max("col_b")).order_by('col_c')
 current query:


 {{{
 select col_a, MAX(col_b) as max
 from Model
 group by col_a, col_c
 order by col_c
 }}}

 I think the expected behavior has should be like that:
 django.db.utils.ProgrammingError: column "Model.col_c" must appear in the
 GROUP BY clause or be used in an aggregate function

 Because this behavior changes my group by and result. if I'm lucky, my
 result doesn't change.

 If we check test_annotation_with_value, 'name' column is being added into
 group_by because Book model has Meta.ordering.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.cd6042641a66b7aea9cc347fa7e8548a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:  Accepted
  count annotate aggreagate  |
  order_by   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * has_patch:  1 => 0
 * version:  1.9 => master


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.6a78b0f5854288162b9a450f8dabaeed%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:  Accepted
  count annotate aggreagate  |
  order_by   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Can Sarıgöl):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/11454 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.8511a923a87d2845e8c1268154e3d125%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:  Accepted
  count annotate aggreagate  |
  order_by   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by kamandol):

 I will change the branch as requested.

 You're right, the faulty behavior was detected on PostgreSQL, but on MySQL
 worked correctly so the test should pass. Could not test other db engines
 though. I will remove that extra piece of code.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.3c955c1159d4276675bd3ae9450b06a1%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:  Accepted
  count annotate aggreagate  |
  order_by   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


Comment:

 If you could put the tests on a branch of you fork other than "master"
 that seems a bit safer. There is probably no need for `skipUnlessDBEngine`
 - is there a reason the queries shouldn't also work on other databases?
 Anyway, the usual way to skip tests is based on database features.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d1bbe3658d1982df59d7220e92506859%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:
  count annotate aggreagate  |  Unreviewed
  order_by   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by kamandol):

 Updated test comments and clearer test names

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4c9bf6958ddc4deaa5c1d1bb962acd56%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:
  count annotate aggreagate  |  Unreviewed
  order_by   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by kamandol):

 Replying to [comment:3 yakky]:
 > Tests looks legitimate, but I don't get this one https://github.com/sp-
 ricard-valverde/django/commit/c50afafdb02880e4c941c2a72a215bee80de3aed
 #diff-ce9b52a66d03e851a9828377263dc04bR3864 ; or rather I don't get why is
 labeled  as 'OK' as it the concatenation of the previous ones

 Sorry, my bad, it's a bad choice for a test title. What it demonstrates is
 that the second assert in that test is '''successful''' even though a new
 QuerySet is built and, according to the other failed tests it should fail
 too.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9e1d82a5a4857af42883075d215784f9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:
  count annotate aggreagate  |  Unreviewed
  order_by   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by yakky):

 * cc: github@… (added)


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.edc3fa98935122f87b56a772c35d7cfa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:
  count annotate aggreagate  |  Unreviewed
  order_by   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by yakky):

 Tests looks legitimate, but I don't get this one https://github.com/sp-
 ricard-valverde/django/commit/c50afafdb02880e4c941c2a72a215bee80de3aed
 #diff-ce9b52a66d03e851a9828377263dc04bR3864 ; or rather I don't get why is
 labeled  as 'OK' as it the concatenation of the previous ones

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.4a9a9d5c1a5facef839b028410c3e6d2%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:
  count annotate aggreagate  |  Unreviewed
  order_by   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by kamandol):

 Replying to [comment:1 timgraham]:
 > Could you provide a test for Django's test suite in
 `tests/queries/tests.py` that demonstrates the issue?

 Here is the commit with the demonstration:

 https://github.com/sp-ricard-
 valverde/django/commit/c50afafdb02880e4c941c2a72a215bee80de3aed

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7e48a6194b69be672d65c20dde7cd104%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #26434: Inconsistent results of QuerySet count() method using PostgreSQL backend prior and post the QuerySet evaluation

[Django]

#26434: Inconsistent results of QuerySet count() method using PostgreSQL backend
prior and post the QuerySet evaluation
-+-
 Reporter:  kamandol |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.9
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  postgresql queryset  | Triage Stage:
  count annotate aggreagate  |  Unreviewed
  order_by   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Could you provide a test for Django's test suite in
 `tests/queries/tests.py` that demonstrates the issue?

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.3d87ddee0ecab9e76f41ba9e68032766%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.