Re: [Django] #27119: full_clean() called too many times during formset validation

[Django]

#27119: full_clean() called too many times during formset validation
-+-
 Reporter:  Claude Paroz |Owner:  Karol
 Type:   |  Sztajerwald
  Cleanup/optimization   |   Status:  closed
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by GitHub ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"d49551bc261666fad753b0f55f1150467190e3f7" d49551bc]:
 {{{
 #!CommitTicketReference repository=""
 revision="d49551bc261666fad753b0f55f1150467190e3f7"
 Fixed #27119 -- Cached BaseFormSet.management_form property

 Thanks Tim Graham for the review.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2ffbfe71081e72df8bbbc213bb2b1b59%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27119: full_clean() called too many times during formset validation

[Django]

#27119: full_clean() called too many times during formset validation
-+-
 Reporter:  Claude Paroz |Owner:  Karol
 Type:   |  Sztajerwald
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e7277c3ef4fc83d4a62d1d7e5ced617d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27119: full_clean() called too many times during formset validation

[Django]

#27119: full_clean() called too many times during formset validation
-+-
 Reporter:  Claude Paroz |Owner:  Karol
 Type:   |  Sztajerwald
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * needs_tests:  1 => 0


Comment:

 Tests added in that [https://github.com/django/django/pull/7644 PR].

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e38e68f5343beaa03133de4bbba9b4d8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27119: full_clean() called too many times during formset validation

[Django]

#27119: full_clean() called too many times during formset validation
-+-
 Reporter:  Claude Paroz |Owner:  Karol
 Type:   |  Sztajerwald
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * needs_tests:  0 => 1


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3014390c39b892b7f9a73ecf2e1bdf50%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27119: full_clean() called too many times during formset validation

[Django]

#27119: full_clean() called too many times during formset validation
-+-
 Reporter:  Claude Paroz |Owner:  Karol
 Type:   |  Sztajerwald
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Karol Sztajerwald):

 * has_patch:  0 => 1


Comment:

 PR here: https://github.com/django/django/pull/7496

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a23375204acd839739a8effe11da2429%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27119: full_clean() called too many times during formset validation

[Django]

#27119: full_clean() called too many times during formset validation
-+-
 Reporter:  Claude Paroz |Owner:  Karol
 Type:   |  Sztajerwald
  Cleanup/optimization   |   Status:  assigned
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Karol Sztajerwald):

 * owner:  DavidFozo => Karol Sztajerwald


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.7709a720f3f4464f7c2c1b74ff718b7d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27119: full_clean() called too many times during formset validation

[Django]

#27119: full_clean() called too many times during formset validation
-+-
 Reporter:  claudep  |Owner:  DavidFozo
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by DavidFozo):

 * status:  new => assigned
 * owner:  nobody => DavidFozo


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4e1aea087c3f6245f1f7315493ec52ce%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27119: full_clean() called too many times during formset validation

[Django]

#27119: full_clean() called too many times during formset validation
--+
 Reporter:  claudep   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Forms |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by timgraham):

 * stage:  Unreviewed => Accepted


Comment:

 Making `BaseFormSet.management_form` a `@cached_property` seems to help
 (not sure if it fully resolves the issue).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5b852d4c2a2424c16496379b9a5268e9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27119: full_clean() called too many times during formset validation

[Django]

#27119: full_clean() called too many times during formset validation
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by claudep):

 I think this affects all sort of formsets. The problem might rather affect
 the `full_clean()` methods of included subforms (notably for the
 management form).

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.80e94192dc25b01110b3a17eae405be5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27119: full_clean() called too many times during formset validation

[Django]

#27119: full_clean() called too many times during formset validation
-+-
 Reporter:  claudep  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by timgraham):

 I think I'm lacking some details to understand this. Is this for plain
 formsets and/or model formsets? Are the duplicated calls to
 `BaseFormSet.full_clean()` and/or some other `full_clean()`? For example,
 I added some debugging in Django's `test_basic_formset` but only saw
 `BaseFormSet.full_clean()` called once.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a78b097e842dd109cc70948c1be64c84%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.