Re: [Django] #27200: Provide makemigrations router.allow_migrate() with a model_name

2016-11-08 Thread Django
#27200: Provide makemigrations router.allow_migrate() with a model_name
-+-
 Reporter:  Joseph Kahn  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Migrations   |  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  makemigrations,  | Triage Stage:  Accepted
  router, allow_migrate  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I created a new ticket: #27461.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fd6efc417b92aeeb1620f214932ac36b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27200: Provide makemigrations router.allow_migrate() with a model_name

2016-11-08 Thread Django
#27200: Provide makemigrations router.allow_migrate() with a model_name
-+-
 Reporter:  Joseph Kahn  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.10
 Severity:  Release blocker  |   Resolution:
 Keywords:  makemigrations,  | Triage Stage:  Accepted
  router, allow_migrate  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 I created a new ticket: #27461.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.f39bed28bfef88a1577595014731de91%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27200: Provide makemigrations router.allow_migrate() with a model_name

2016-11-08 Thread Django
#27200: Provide makemigrations router.allow_migrate() with a model_name
-+-
 Reporter:  Joseph Kahn  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.10
 Severity:  Release blocker  |   Resolution:
 Keywords:  makemigrations,  | Triage Stage:  Accepted
  router, allow_migrate  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Joseph Kahn):

 Sure, and sorry I wasn't sure what the right thing to do was.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.803a582cdf77d236162cf8f855306766%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27200: Provide makemigrations router.allow_migrate() with a model_name

2016-11-08 Thread Django
#27200: Provide makemigrations router.allow_migrate() with a model_name
-+-
 Reporter:  Joseph Kahn  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.10
 Severity:  Release blocker  |   Resolution:
 Keywords:  makemigrations,  | Triage Stage:  Accepted
  router, allow_migrate  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * severity:  Normal => Release blocker
 * needs_tests:  0 => 1


Comment:

 Can you add a regression test? For future reference, since the fix is
 already released, it would be more appropriate to open a new ticket, but
 whatever.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.bbf9de965f1c42d8af2d2f23f323050b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27200: Provide makemigrations router.allow_migrate() with a model_name

2016-11-08 Thread Django
#27200: Provide makemigrations router.allow_migrate() with a model_name
-+-
 Reporter:  Joseph Kahn  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Migrations   |  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  makemigrations,  | Triage Stage:  Accepted
  router, allow_migrate  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Joseph Kahn):

 * type:  Cleanup/optimization => Bug


--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.dade189da348ee5f8333e3f3a794fb98%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27200: Provide makemigrations router.allow_migrate() with a model_name

2016-11-08 Thread Django
#27200: Provide makemigrations router.allow_migrate() with a model_name
-+-
 Reporter:  Joseph Kahn  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Migrations   |  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  makemigrations,  | Triage Stage:  Accepted
  router, allow_migrate  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Joseph Kahn):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 There's a bug in the code. I was on vacation, sorry it took so long for me
 to get back. It was getting all the models rather than the models for each
 app. It broke the router I use because it was passing invalid combinations
 for shards since not all shards have the same models.

 https://github.com/django/django/pull/7530

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.118185cb7c9a58300be143bccefe7b5e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27200: Provide makemigrations router.allow_migrate() with a model_name

2016-10-13 Thread Django
#27200: Provide makemigrations router.allow_migrate() with a model_name
-+-
 Reporter:  Joseph Kahn  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Migrations   |  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  makemigrations,  | Triage Stage:  Accepted
  router, allow_migrate  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"91cc5fd4cce58361aab9554a6bb695c854df641a" 91cc5fd]:
 {{{
 #!CommitTicketReference repository=""
 revision="91cc5fd4cce58361aab9554a6bb695c854df641a"
 [1.10.x] Fixed #27200 -- Provided makemigration's allow_migrate() with
 model_name.

 Backport of cd09524f27b83c0ca9dabafa81265e8d8abd252a from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.5d6b0b22285526ba92ce8e325218f8ae%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27200: Provide makemigrations router.allow_migrate() with a model_name

2016-10-13 Thread Django
#27200: Provide makemigrations router.allow_migrate() with a model_name
-+-
 Reporter:  Joseph Kahn  |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Migrations   |  Version:  1.10
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  makemigrations,  | Triage Stage:  Accepted
  router, allow_migrate  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"cd09524f27b83c0ca9dabafa81265e8d8abd252a" cd09524f]:
 {{{
 #!CommitTicketReference repository=""
 revision="cd09524f27b83c0ca9dabafa81265e8d8abd252a"
 Fixed #27200 -- Provided makemigration's allow_migrate() with model_name.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.cfa5416100aa44e4144b361a6f8bd116%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.


Re: [Django] #27200: Provide makemigrations router.allow_migrate() with a model_name (was: router.allow_migrate without a model/hint, what is it supposed to do? Does it make sense to make that call?)

2016-10-12 Thread Django
#27200: Provide makemigrations router.allow_migrate() with a model_name
-+-
 Reporter:  Joseph Kahn  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Migrations   |  Version:  1.10
 Severity:  Normal   |   Resolution:
 Keywords:  makemigrations,  | Triage Stage:  Accepted
  router, allow_migrate  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted
 * type:  Bug => Cleanup/optimization


Comment:

 [https://github.com/django/django/pull/7377 PR]

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.9b52f6375866397dea1a53cd51922db8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.