Re: [Django] #27558: Setting db_index=False on existing ForeignKey causes constraint to be recreated on MySQL

[Django]

#27558: Setting db_index=False on existing ForeignKey causes constraint to be
recreated on MySQL
-+-
 Reporter:  Ed Morley|Owner:  Ed Morley
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  db-indexes, mysql| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"4086ff9ecbf4824cc5c0cc94e4c13ef474a22b9b" 4086ff9e]:
 {{{
 #!CommitTicketReference repository=""
 revision="4086ff9ecbf4824cc5c0cc94e4c13ef474a22b9b"
 [1.10.x] Refs #27558 -- Isolated indexes test on MySQL.

 MySQL schema changes must be done in TransactionTestCase.

 Backport of f94475e5262abe78d9771bc353f741b20cc3c725 from master
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.c18ea30f3be5e69ed5382a8e985b5b8c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27558: Setting db_index=False on existing ForeignKey causes constraint to be recreated on MySQL

[Django]

#27558: Setting db_index=False on existing ForeignKey causes constraint to be
recreated on MySQL
-+-
 Reporter:  Ed Morley|Owner:  Ed Morley
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  db-indexes, mysql| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"f94475e5262abe78d9771bc353f741b20cc3c725" f94475e]:
 {{{
 #!CommitTicketReference repository=""
 revision="f94475e5262abe78d9771bc353f741b20cc3c725"
 Refs #27558 -- Isolated indexes test on MySQL.

 MySQL schema changes must be done in TransactionTestCase.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.81751b2faa11caca6ddad4c52542b6b4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27558: Setting db_index=False on existing ForeignKey causes constraint to be recreated on MySQL

[Django]

#27558: Setting db_index=False on existing ForeignKey causes constraint to be
recreated on MySQL
-+-
 Reporter:  Ed Morley|Owner:  Ed Morley
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  db-indexes, mysql| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"dd2e4d7b5d6f24f33c2805b0bfb97a08e27b2125" dd2e4d7b]:
 {{{
 #!CommitTicketReference repository=""
 revision="dd2e4d7b5d6f24f33c2805b0bfb97a08e27b2125"
 Refs #27558 -- Added test for no index on InnoDB ForeignKey.

 The refactor in 3f76d1402dac9c2993d588f996dc1c331edbc9a7 fixed the
 creation
 of redundant indexes.

 Forwardport of 82ce55dbbe2d96e8b5d1fcb4a1d52b73e08e7929 from stable/1.10.x
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2db40eb50a75a8dd86969ed50a99737e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27558: Setting db_index=False on existing ForeignKey causes constraint to be recreated on MySQL

[Django]

#27558: Setting db_index=False on existing ForeignKey causes constraint to be
recreated on MySQL
-+-
 Reporter:  Ed Morley|Owner:  Ed Morley
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  db-indexes, mysql| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"82ce55dbbe2d96e8b5d1fcb4a1d52b73e08e7929" 82ce55d]:
 {{{
 #!CommitTicketReference repository=""
 revision="82ce55dbbe2d96e8b5d1fcb4a1d52b73e08e7929"
 [1.10.x] Fixed #27558 -- Prevented redundant index on InnoDB ForeignKey.

 The MySQL backend overrides _field_should_be_indexed() so that it skips
 index creation for ForeignKeys when using InnoDB.
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.69cb65b22e3535b20815353627019553%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27558: Setting db_index=False on existing ForeignKey causes constraint to be recreated on MySQL

[Django]

#27558: Setting db_index=False on existing ForeignKey causes constraint to be
recreated on MySQL
-+-
 Reporter:  Ed Morley|Owner:  Ed Morley
 Type:  Bug  |   Status:  assigned
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  db-indexes, mysql| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ed Morley):

 * status:  new => assigned
 * owner:  nobody => Ed Morley


Comment:

 I have a reduced testcase for master + 1.10.x branch, and a 1 liner to fix
 the issue on 1.10.x.
 Will clean up soon and open PRs.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.799cea75f395e41c967557a896ff2807%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #27558: Setting db_index=False on existing ForeignKey causes constraint to be recreated on MySQL (was: Setting db_index=False on existing ForeignKey causes constraint to be recreated)

[Django]

#27558: Setting db_index=False on existing ForeignKey causes constraint to be
recreated on MySQL
-+-
 Reporter:  Ed Morley|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.10
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:  db-indexes, mysql| Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Comment:

 A less invasive fix for 1.10 is probably needed as the changing and adding
 of methods in that commit looks a bit risky for a stable release. The
 regression test can also be added to master.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7343a74c9243a10d0c79872ac03c3209%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.