Re: [Django] #29184: TabularInline read-only fields ignore ModelForm Meta.labels and help_texts

[Django]

#29184: TabularInline read-only fields ignore ModelForm Meta.labels and 
help_texts
-+-
 Reporter:  David Sanders|Owner:  Danil
 |  Kozyatnikov
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  readonly,| Triage Stage:  Accepted
  help_texts, labels |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"274e3e27f366bddbf1bb13b40c3c7b95195c496e" 274e3e2]:
 {{{
 #!CommitTicketReference repository=""
 revision="274e3e27f366bddbf1bb13b40c3c7b95195c496e"
 Fixed #29184 -- Made TabularInline respect model form's Meta.labels and
 help_texts.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.081975c822ad8978ea55d093649f3f02%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29184: TabularInline read-only fields ignore ModelForm Meta.labels and help_texts

[Django]

#29184: TabularInline read-only fields ignore ModelForm Meta.labels and 
help_texts
-+-
 Reporter:  David Sanders|Owner:  Danil
 |  Kozyatnikov
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  readonly,| Triage Stage:  Accepted
  help_texts, labels |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


Comment:

 Overall patch in PR looks good.

 Just a few adjustments needed (comments on PR). Please uncheck ''Patch
 needs improvement'' when these are addressed.

 Thanks Danil.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.167b350d72d184fb0aa50b16851ebdee%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29184: TabularInline read-only fields ignore ModelForm Meta.labels and help_texts

[Django]

#29184: TabularInline read-only fields ignore ModelForm Meta.labels and 
help_texts
-+-
 Reporter:  David Sanders|Owner:  Danil
 |  Kozyatnikov
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  readonly,| Triage Stage:  Accepted
  help_texts, labels |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_tests:  1 => 0


Comment:

 [https://github.com/django/django/pull/9767 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.355a0dd4d2357d5860f7112f3eb5d0bf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29184: TabularInline read-only fields ignore ModelForm Meta.labels and help_texts

[Django]

#29184: TabularInline read-only fields ignore ModelForm Meta.labels and 
help_texts
-+-
 Reporter:  David Sanders|Owner:  Danil
 |  Kozyatnikov
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  readonly,| Triage Stage:  Accepted
  help_texts, labels |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Danil Kozyatnikov):

 * owner:  nobody => Danil Kozyatnikov
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.82f586429353f5e9a70183e19074a36b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29184: TabularInline read-only fields ignore ModelForm Meta.labels and help_texts

[Django]

#29184: TabularInline read-only fields ignore ModelForm Meta.labels and 
help_texts
-+-
 Reporter:  David Sanders|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  readonly,| Triage Stage:  Accepted
  help_texts, labels |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by David Sanders):

 Tweaked the patch a little bit to fix a situation it broke with pure form
 fields (no model field).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.0303c8866ee3172678d7f017fbc7dcb9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29184: TabularInline read-only fields ignore ModelForm Meta.labels and help_texts

[Django]

#29184: TabularInline read-only fields ignore ModelForm Meta.labels and 
help_texts
-+-
 Reporter:  David Sanders|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  readonly,| Triage Stage:  Accepted
  help_texts, labels |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Sanders):

 * Attachment "tabularinline_label_and_help_text_2.patch" added.

 Fixed patch

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e0719c6292596ffe276ce2eb1d60e197%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29184: TabularInline read-only fields ignore ModelForm Meta.labels and help_texts (was: TabularInline Read-only Fields Ignore ModelForm._meta Label and Help Text Overrides)

[Django]

#29184: TabularInline read-only fields ignore ModelForm Meta.labels and 
help_texts
-+-
 Reporter:  David Sanders|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  2.0
 Severity:  Normal   |   Resolution:
 Keywords:  readonly,| Triage Stage:  Accepted
  help_texts, labels |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.354423aa08680294a974d5ee560e0d76%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.