Re: [Django] #29658: Use unittest.addCleanup to unregister lookups.

[Django]

#29658: Use unittest.addCleanup to unregister lookups.
-+-
 Reporter:  Mads Jensen  |Owner:  Srinivas
 Type:   |  Reddy Thatiparthy
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Simon Charette):

 Using context managers should be fine as well.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.c19684c6813b9f73f97490a3a2e41723%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29658: Use unittest.addCleanup to unregister lookups.

[Django]

#29658: Use unittest.addCleanup to unregister lookups.
-+-
 Reporter:  Mads Jensen  |Owner:  Srinivas
 Type:   |  Reddy Thatiparthy
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Accepted => Ready for checkin


Comment:

 Patch looks good to me, unless there's some reason to prefer
 `addCleanup()`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.5708d780cd2588bf8244d62c3e92864e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29658: Use unittest.addCleanup to unregister lookups.

[Django]

#29658: Use unittest.addCleanup to unregister lookups.
-+-
 Reporter:  Mads Jensen  |Owner:  Srinivas
 Type:   |  Reddy Thatiparthy
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Claude Paroz):

 * has_patch:  0 => 1


Comment:

 The current patch is using a context manager instead of the `try/finally`
 method.
 Mads, is that something you are comfortable with, or do you still see some
 benefit with `addCleanup`?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.39c70c098b7573ee419bda488246e99b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29658: Use unittest.addCleanup to unregister lookups.

[Django]

#29658: Use unittest.addCleanup to unregister lookups.
-+-
 Reporter:  Mads Jensen  |Owner:  Srinivas
 Type:   |  Reddy Thatiparthy
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Srinivas Reddy Thatiparthy):

 * owner:  Dominic White => Srinivas Reddy Thatiparthy


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.6999b9600c0db2bca0cfe51e759a870d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29658: Use unittest.addCleanup to unregister lookups.

[Django]

#29658: Use unittest.addCleanup to unregister lookups.
-+-
 Reporter:  Mads Jensen  |Owner:  Dominic
 Type:   |  White
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Srinivas Reddy Thatiparthy):

 https://code.djangoproject.com/ticket/29658

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.a4fca27c66ecd246a9d9a0737d0724da%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29658: Use unittest.addCleanup to unregister lookups.

[Django]

#29658: Use unittest.addCleanup to unregister lookups.
-+-
 Reporter:  Mads Jensen  |Owner:  Dominic
 Type:   |  White
  Cleanup/optimization   |   Status:  assigned
Component:  Core (Other) |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Dominic White):

 * status:  new => assigned
 * owner:  nobody => Dominic White


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.9925e9f2ef8595da71a88cdbc1f9996a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29658: Use unittest.addCleanup to unregister lookups.

[Django]

#29658: Use unittest.addCleanup to unregister lookups.
--+
 Reporter:  Mads Jensen   |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:  master
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by Claude Paroz):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.024f7617bb8eae6438870ecad5ae1a03%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.