Re: [Django] #29984: Support prefetch_related() with Queryset.iterator()

[Django]

#29984: Support prefetch_related() with Queryset.iterator()
-+-
 Reporter:  Taylor H |Owner:  Jacob
 |  Walls
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"139135627650ed6aaaf4c755b82c3bd43f2b8f51" 1391356]:
 {{{
 #!CommitTicketReference repository=""
 revision="139135627650ed6aaaf4c755b82c3bd43f2b8f51"
 Refs #29984 -- Made QuerySet.iterator() without chunk_size raise
 ValueError after prefetch_related().

 Per deprecation timeline.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070185bf595732-c707ea04-43df-4885-9fcd-3d916104b86a-00%40eu-central-1.amazonses.com.

Re: [Django] #29984: Support prefetch_related() with Queryset.iterator()

[Django]

#29984: Support prefetch_related() with Queryset.iterator()
-+-
 Reporter:  Taylor H |Owner:  Jacob
 |  Walls
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"edbf930287cb72e9afab1f7208c24b1146b0c4ec" edbf9302]:
 {{{
 #!CommitTicketReference repository=""
 revision="edbf930287cb72e9afab1f7208c24b1146b0c4ec"
 Fixed #29984 -- Added QuerySet.iterator() support for prefetching related
 objects.

 Co-authored-by: Raphael Kimmig 
 Co-authored-by: Simon Charette 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.efb9bb192c4790ac260cafc7376763d9%40djangoproject.com.

Re: [Django] #29984: Support prefetch_related() with Queryset.iterator()

[Django]

#29984: Support prefetch_related() with Queryset.iterator()
-+-
 Reporter:  Taylor H |Owner:  Jacob
 |  Walls
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.fe2311b086d7102d4566cb655edf482a%40djangoproject.com.

Re: [Django] #29984: Support prefetch_related() with Queryset.iterator()

[Django]

#29984: Support prefetch_related() with Queryset.iterator()
-+-
 Reporter:  Taylor H |Owner:  Jacob
 |  Walls
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.568a457fb1c04f53377fb29373f8f733%40djangoproject.com.

Re: [Django] #29984: Support prefetch_related() with Queryset.iterator()

[Django]

#29984: Support prefetch_related() with Queryset.iterator()
-+-
 Reporter:  Taylor H |Owner:  Jacob
 |  Walls
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.86f0c2d4c49e59a241c0f4517ab44a89%40djangoproject.com.

Re: [Django] #29984: Support prefetch_related() with Queryset.iterator()

[Django]

#29984: Support prefetch_related() with Queryset.iterator()
-+-
 Reporter:  Taylor H |Owner:  Jacob
 |  Walls
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0


Comment:

 [https://github.com/django/django/pull/15334 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.e545ad755a5af67d06dc38e65f56bddd%40djangoproject.com.

Re: [Django] #29984: Support prefetch_related() with Queryset.iterator()

[Django]

#29984: Support prefetch_related() with Queryset.iterator()
-+-
 Reporter:  Taylor H |Owner:  Jacob
 |  Walls
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jacob Walls):

 * owner:  nobody => Jacob Walls
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.2b4ffa6b1788d39fcbcf997b83b3a49f%40djangoproject.com.

Re: [Django] #29984: Support prefetch_related() with Queryset.iterator()

[Django]

#29984: Support prefetch_related() with Queryset.iterator()
-+-
 Reporter:  Taylor H |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Simon Charette):

 * needs_better_patch:  0 => 1


Comment:

 Patch needs both documentation and a deprecation warning when
 `self._prefetch_related_lookups and chunk_size is None`. The idea is to
 eventually turn this deprecation warning into an error and never performs
 prefetching unless a chunk size is specified.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.da65a5d3113ae52070d949ba53c3%40djangoproject.com.

Re: [Django] #29984: Support prefetch_related() with Queryset.iterator()

[Django]

#29984: Support prefetch_related() with Queryset.iterator()
-+-
 Reporter:  Taylor H |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Asif Saifuddin Auvi):

 * version:  2.1 => master


Old description:

> I was surprise when I found out that `prefetch_related` calls are ignored
> when using `Queryset.iterator`. I noticed in the docs here
> https://docs.djangoproject.com/en/2.1/ref/models/querysets/#iterator that
> it is because the "these two optimizations do not make sense together."
> That may have been true in the past, but it is definitely not the case
> now. The iterator allows chunking (by default 2000) and it would be very
> helpful to prefetch related for each chunk.

New description:

 I was surprised when I found out that `prefetch_related` calls are ignored
 when using `Queryset.iterator`. I noticed in the docs here
 https://docs.djangoproject.com/en/dev/ref/models/querysets/#iterator that
 it is because the "these two optimizations do not make sense together."
 That may have been true in the past, but it is definitely not the case
 now. The iterator allows chunking (by default 2000) and it would be very
 helpful to prefetch related for each chunk.

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.2dee21b98959f92fb22c13123888b2c3%40djangoproject.com.

Re: [Django] #29984: Support prefetch_related() with Queryset.iterator()

[Django]

#29984: Support prefetch_related() with Queryset.iterator()
-+-
 Reporter:  Taylor H |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  2.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by David Foster):

 * needs_docs:  0 => 1
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.0cb394a7562e09b29cea1ca5c6450a14%40djangoproject.com.

Re: [Django] #29984: Support prefetch_related() with Queryset.iterator()

[Django]

#29984: Support prefetch_related() with Queryset.iterator()
-+-
 Reporter:  Taylor H |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  2.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Raphael Kimmig):

 I've created a proof of concept implementation
 https://github.com/django/django/pull/10707/

 I think prefetching is probably closer to what a user would expect from
 the api.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.6e7980bc675d33637b7b81038c4aa933%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #29984: Support prefetch_related() with Queryset.iterator() (was: Support prefetch_related with Queryset.iterator)

[Django]

#29984: Support prefetch_related() with Queryset.iterator()
-+-
 Reporter:  Taylor H |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  2.1
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * stage:  Unreviewed => Accepted


Comment:

 The situation isn't completely straightforward. There's a discussion on
 [https://groups.google.com/d/topic/django-
 developers/ADgUd6jRvdw/discussion django-developers]. Accepting the ticket
 to do something.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/070.2f18b280e995428b2488b4f17506463d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.