Re: [Django] #30033: SQLite schema editor should use the documented process to emulate table alterations on SQlite3.

2019-01-28 Thread Django 
#30033: SQLite schema editor should use the documented process to emulate table
alterations on SQlite3.
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"e8cb0dcc19c4bcabee1d856b7fae1b54fa3e3380" e8cb0dcc]:
 {{{
 #!CommitTicketReference repository=""
 revision="e8cb0dcc19c4bcabee1d856b7fae1b54fa3e3380"
 [2.2.x] Refs #30033 -- Doc'd change regarding apps without migrations
 depending on apps with migrations.

 The addition of self.connection.check_constraints() in
 7289874adceec46b5367ec3157cdd10c711253a0 is the cause.

 Backport of fcfb7306586184f08c7f75c174f95b54a212320d from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.c1a7832ed94076904606d31e05027d33%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30033: SQLite schema editor should use the documented process to emulate table alterations on SQlite3.

2019-01-28 Thread Django 
#30033: SQLite schema editor should use the documented process to emulate table
alterations on SQlite3.
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"fcfb7306586184f08c7f75c174f95b54a212320d" fcfb7306]:
 {{{
 #!CommitTicketReference repository=""
 revision="fcfb7306586184f08c7f75c174f95b54a212320d"
 Refs #30033 -- Doc'd change regarding apps without migrations depending on
 apps with migrations.

 The addition of self.connection.check_constraints() in
 7289874adceec46b5367ec3157cdd10c711253a0 is the cause.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.960dc296f4f77e12ed71c9fce5760f54%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30033: SQLite schema editor should use the documented process to emulate table alterations on SQlite3.

2018-12-26 Thread Django 
#30033: SQLite schema editor should use the documented process to emulate table
alterations on SQlite3.
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  new => closed
 * resolution:   => fixed
 * severity:  Release blocker => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.93fb68293c019430dc087c7fce83ba1f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30033: SQLite schema editor should use the documented process to emulate table alterations on SQlite3.

2018-12-26 Thread Django 
#30033: SQLite schema editor should use the documented process to emulate table
alterations on SQlite3.
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  new
Component:  Migrations   |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"0b54ab0675a5443dbda2fc48e98ab474c295ac0c" 0b54ab06]:
 {{{
 #!CommitTicketReference repository=""
 revision="0b54ab0675a5443dbda2fc48e98ab474c295ac0c"
 Refs #30033 -- Fixed schema's test_m2m_rename_field_in_target_model test
 failure on SQLite < 3.20.

 Mixing local test models with non-local models resulted in a referential
 integrity error during tear down since the models are removed in separate
 schema editor instances which each check constraints.

 Failure appeared after 7289874adceec46b5367ec3157cdd10c711253a0.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6c1e2ab9f1fbc0fb15bb37ba8bd2aa4f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30033: SQLite schema editor should use the documented process to emulate table alterations on SQlite3.

2018-12-22 Thread Django 
#30033: SQLite schema editor should use the documented process to emulate table
alterations on SQlite3.
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  new
Component:  Migrations   |  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * status:  closed => new
 * has_patch:  1 => 0
 * resolution:  fixed =>
 * severity:  Normal => Release blocker
 * stage:  Ready for checkin => Accepted


Comment:

 On Ubuntu 16.04 which has SQLite 3.11, some problems appeared after
 7289874adceec46b5367ec3157cdd10c711253a0:
 {{{
 ==
 ERROR: test_m2m_rename_field_in_target_model (schema.tests.SchemaTests)
 --
 Traceback (most recent call last):
   File "/media/sf_django/django/db/backends/utils.py", line 82, in
 _execute
 return self.cursor.execute(sql)
   File "/media/sf_django/django/db/backends/sqlite3/base.py", line 360, in
 execute
 return Database.Cursor.execute(self, query)
 sqlite3.OperationalError: no such table: schema_tagm2mtest

 The above exception was the direct cause of the following exception:

 Traceback (most recent call last):
   File "/media/sf_django/tests/schema/tests.py", line 70, in tearDown
 self.delete_tables()
   File "/media/sf_django/tests/schema/tests.py", line 97, in delete_tables
 connection.enable_constraint_checking()
   File "/media/sf_django/django/db/backends/sqlite3/schema.py", line 34,
 in __exit__
 self.connection.check_constraints()
   File "/media/sf_django/django/db/backends/sqlite3/base.py", line 320, in
 check_constraints
 column_name, referenced_column_name,
   File "/media/sf_django/django/db/backends/utils.py", line 67, in execute
 return self._execute_with_wrappers(sql, params, many=False,
 executor=self._execute)
   File "/media/sf_django/django/db/backends/utils.py", line 76, in
 _execute_with_wrappers
 return executor(sql, params, many, context)
   File "/media/sf_django/django/db/backends/utils.py", line 84, in
 _execute
 return self.cursor.execute(sql, params)
   File "/media/sf_django/django/db/utils.py", line 89, in __exit__
 raise dj_exc_value.with_traceback(traceback) from exc_value
   File "/media/sf_django/django/db/backends/utils.py", line 82, in
 _execute
 return self.cursor.execute(sql)
   File "/media/sf_django/django/db/backends/sqlite3/base.py", line 360, in
 execute
 return Database.Cursor.execute(self, query)
 django.db.utils.OperationalError: no such table: schema_tagm2mtest
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.bb7554c86af2e931d07445b87e0b6f7a%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30033: SQLite schema editor should use the documented process to emulate table alterations on SQlite3.

2018-12-22 Thread Django 
#30033: SQLite schema editor should use the documented process to emulate table
alterations on SQlite3.
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"ce8b65ac5e8e20912c36ab5c714ddf11de3b664c" ce8b65a]:
 {{{
 #!CommitTicketReference repository=""
 revision="ce8b65ac5e8e20912c36ab5c714ddf11de3b664c"
 Fixed #30054 -- Implemented cascaded flush on SQLite.

 This is required to maintain foreign key integrity when using
 TransactionTestCase.available_apps.

 Refs #30033, #14204, #20483.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6a7bf3bbc2c0533309c3bff16e0cdf45%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30033: SQLite schema editor should use the documented process to emulate table alterations on SQlite3.

2018-12-22 Thread Django 
#30033: SQLite schema editor should use the documented process to emulate table
alterations on SQlite3.
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"790d108c97f0cf9caa02c72791f2bf158d308fcd" 790d108c]:
 {{{
 #!CommitTicketReference repository=""
 revision="790d108c97f0cf9caa02c72791f2bf158d308fcd"
 Refs #30033 -- Checked constraints before committing SQLite schema
 changes.

 This order of operations is more in line with SQLite's documented table
 rebuild procedure and ensures that changes aren't committed if foreign key
 integrity is broken.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.eb445d1b5aeb9342ea24144130f4626b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30033: SQLite schema editor should use the documented process to emulate table alterations on SQlite3.

2018-12-17 Thread Django 
#30033: SQLite schema editor should use the documented process to emulate table
alterations on SQlite3.
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Carlton Gibson ):

 In [changeset:"894cb13779e6d092974c873bd2cf1452554d2e06" 894cb13]:
 {{{
 #!CommitTicketReference repository=""
 revision="894cb13779e6d092974c873bd2cf1452554d2e06"
 Refs #29182 -- Stopped relying on legacy alter table semantic on SQLite
 3.26+.

 SQLite 3.26 changed the behavior of table and column renaming operations
 to
 repoint foreign key references even if foreign key checks are disabled.

 This makes the workarounds in place to simulate this behavior unnecessary
 on
 SQLite 3.26+. Refs #30033.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5f38bee78fe42a451b30897d92d02c74%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30033: SQLite schema editor should use the documented process to emulate table alterations on SQlite3.

2018-12-17 Thread Django 
#30033: SQLite schema editor should use the documented process to emulate table
alterations on SQlite3.
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  closed
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7289874adceec46b5367ec3157cdd10c711253a0" 7289874a]:
 {{{
 #!CommitTicketReference repository=""
 revision="7289874adceec46b5367ec3157cdd10c711253a0"
 Fixed #30033 -- Conformed to the recommended table alterations procedure
 on SQlite3.

 Refs #29182.

 The previous implementation was following a procedure explicitly
 documented
 as incorrect and was the origin of the breakage experienced on SQLite 3.26
 release that were addressed by c8ffdbe514b55ff5c9a2b8cb8bbdf2d3978c188f.

 Thanks to Richard Hipp for pointing out the usage of the incorrect
 procedure.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.54fc8fa92ba1c772f9bd224fbf1d4157%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30033: SQLite schema editor should use the documented process to emulate table alterations on SQlite3. (was: SQLite schema editor should use the documented to emulate table alterations o

2018-12-14 Thread Django 
#30033: SQLite schema editor should use the documented process to emulate table
alterations on SQlite3.
-+-
 Reporter:  Simon Charette   |Owner:  Simon
 Type:   |  Charette
  Cleanup/optimization   |   Status:  assigned
Component:  Migrations   |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.0ef71d2ebb0d2575f74882c59c14675b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.