Re: [Django] #30237: admin check for AuthenticationMiddleware should allow subclasses

[Django]

#30237: admin check for AuthenticationMiddleware should allow subclasses
-+-
 Reporter:  Alek Ratzloff|Owner:  Herman S
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.2
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 Niclas, see #30312.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.de5da36885e6796440471073d2710668%40djangoproject.com.

Re: [Django] #30237: admin check for AuthenticationMiddleware should allow subclasses

[Django]

#30237: admin check for AuthenticationMiddleware should allow subclasses
-+-
 Reporter:  Alek Ratzloff|Owner:  Herman S
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.2
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Niclas Olofsson):

 Hmm, I just ran into this as well, but in our case we are using a subclass
 of `SessionMiddleware`. Looking at the patch I can see that
 `SessionMiddleware` is mentioned in the title, but I cannot see that the
 implementation actually checks for such subclasses?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.fff90d7b7695e1de965faf7249e34d2f%40djangoproject.com.

Re: [Django] #30237: admin check for AuthenticationMiddleware should allow subclasses

[Django]

#30237: admin check for AuthenticationMiddleware should allow subclasses
-+-
 Reporter:  Alek Ratzloff|Owner:  Herman S
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.2
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 batistalucash, please don't reopen fixed tickets without providing any new
 information. This patch allows subclasses of `AuthenticationMiddleware`
 and `SessionMiddleware`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.72f5b8055bfcb7f8beda91b8dad1b16b%40djangoproject.com.

Re: [Django] #30237: admin check for AuthenticationMiddleware should allow subclasses

[Django]

#30237: admin check for AuthenticationMiddleware should allow subclasses
-+-
 Reporter:  Alek Ratzloff|Owner:  Herman S
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by batistalucash):

 * status:  closed => new
 * resolution:  fixed =>


Comment:

 I am not sure this issue was solved. Should something be changed in the
 settings.py file?


 FYI: It started happening after a change the version of Django to the
 newest one.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.311e40ad9a3218372de32a7901dc350c%40djangoproject.com.

Re: [Django] #30237: admin check for AuthenticationMiddleware should allow subclasses

[Django]

#30237: admin check for AuthenticationMiddleware should allow subclasses
-+-
 Reporter:  Alek Ratzloff|Owner:  Herman S
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.2
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tameron NGUYEN):

 Replying to [comment:1 Tim Graham]:
 > The check is new in Django 2.2
 (371ece2f0682e51f2f796854d3e091827a7cea63). It might be possible to modify
 it so that it detects `AuthenticationMiddleware` subclasses. You could
 also simply add that error to your `SILENCED_SYSTEM_CHECKS` setting.

 Errors: ?: (admin.E408)
 'django.contrib.auth.middleware.AuthenticationMiddleware' must be in
 MIDDLEWARE in order to use the admin application.
 In settings.py, add

 {{{
 SILENCED_SYSTEM_CHECKS = [
 'admin.E408',
 ]
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.5ddacd8a2c951e487691e18a41918b72%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30237: admin check for AuthenticationMiddleware should allow subclasses

[Django]

#30237: admin check for AuthenticationMiddleware should allow subclasses
-+-
 Reporter:  Alek Ratzloff|Owner:  Herman S
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.2
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham ):

 In [changeset:"d8704a4d4f6a3bc96cf26ffd1f14bf4b5c71c74d" d8704a4d]:
 {{{
 #!CommitTicketReference repository=""
 revision="d8704a4d4f6a3bc96cf26ffd1f14bf4b5c71c74d"
 [2.2.x] Fixed #30237 -- Made Authentication/SessionMiddleware and
 ModelBackend admin checks allow subclasses.

 Backport of f976ab1b117574db78d884c94e549a6b8e4c9f9b from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.e03289daea2d098ead21266a58ddb739%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30237: admin check for AuthenticationMiddleware should allow subclasses

[Django]

#30237: admin check for AuthenticationMiddleware should allow subclasses
-+-
 Reporter:  Alek Ratzloff|Owner:  Herman S
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  2.2
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"f976ab1b117574db78d884c94e549a6b8e4c9f9b" f976ab1b]:
 {{{
 #!CommitTicketReference repository=""
 revision="f976ab1b117574db78d884c94e549a6b8e4c9f9b"
 Fixed #30237 -- Made Authentication/SessionMiddleware and ModelBackend
 admin checks allow subclasses.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.ecd9e5f45f319eaaadae8431754b860e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30237: admin check for AuthenticationMiddleware should allow subclasses

[Django]

#30237: admin check for AuthenticationMiddleware should allow subclasses
-+-
 Reporter:  Alek Ratzloff|Owner:  Herman S
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.dc6251b4c7d4abe95dcd91a3da1fc90c%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30237: admin check for AuthenticationMiddleware should allow subclasses

[Django]

#30237: admin check for AuthenticationMiddleware should allow subclasses
-+
 Reporter:  Alek Ratzloff|Owner:  Herman S
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Herman S):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.490963faaad030fc921f52535f445949%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30237: admin check for AuthenticationMiddleware should allow subclasses (was: django.contrib.admin checks for django.contrib.auth.middleware.AuthenticationMiddleware, breaking custom aut

[Django]

#30237: admin check for AuthenticationMiddleware should allow subclasses
-+
 Reporter:  Alek Ratzloff|Owner:  hermansc
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  2.2
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f06a73c22c045b2b92dc9a44950bf07d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.