Re: [Django] #30553: Misleading logging documentation about disable_existing_loggers default value.

[Django]

#30553: Misleading logging documentation about disable_existing_loggers default
value.
-+-
 Reporter:  darthdragon  |Owner:  Swatantra
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
  disable_existing_loggers logging   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"6dca3361670d5a92dbe0954515d63c1e9db7cbcb" 6dca3361]:
 {{{
 #!CommitTicketReference repository=""
 revision="6dca3361670d5a92dbe0954515d63c1e9db7cbcb"
 [2.2.x] Fixed #30553 -- Clarified the default value of
 disable_existing_loggers.

 Backport of 03cd3d137e2c29484b020b9768a4741f1096be97 from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.5e3c7598ec42c98864b5cf9dc7617041%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30553: Misleading logging documentation about disable_existing_loggers default value.

[Django]

#30553: Misleading logging documentation about disable_existing_loggers default
value.
-+-
 Reporter:  darthdragon  |Owner:  Swatantra
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
  disable_existing_loggers logging   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"03cd3d137e2c29484b020b9768a4741f1096be97" 03cd3d1]:
 {{{
 #!CommitTicketReference repository=""
 revision="03cd3d137e2c29484b020b9768a4741f1096be97"
 Fixed #30553 -- Clarified the default value of disable_existing_loggers.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.b007d3f117f5fe7c9c7c0ed7fccb8277%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30553: Misleading logging documentation about disable_existing_loggers default value.

[Django]

#30553: Misleading logging documentation about disable_existing_loggers default
value.
-+-
 Reporter:  darthdragon  |Owner:  Swatantra
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
  disable_existing_loggers logging   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.5b98d575097544ed471d47f80ccf8dc8%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30553: Misleading logging documentation about disable_existing_loggers default value.

[Django]

#30553: Misleading logging documentation about disable_existing_loggers default
value.
-+-
 Reporter:  darthdragon  |Owner:  Swatantra
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  disable_existing_loggers logging   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


Comment:

 As per comment on PR, I think the solution here should just clarify that
 the "default" in question if that of `dictConfig`, rather than referring
 to the value used by Django's `DEFAULT_LOGGING` during startup.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.5519a48bcf8b951bd7d676928ee0c3c0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30553: Misleading logging documentation about disable_existing_loggers default value.

[Django]

#30553: Misleading logging documentation about disable_existing_loggers default
value.
-+-
 Reporter:  darthdragon  |Owner:  Swatantra
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  disable_existing_loggers logging   |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/11456 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.02ee2d453dbf44a99033832579e257a9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30553: Misleading logging documentation about disable_existing_loggers default value.

[Django]

#30553: Misleading logging documentation about disable_existing_loggers default
value.
-+-
 Reporter:  darthdragon  |Owner:  Swat009
 Type:   |   Status:  assigned
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  disable_existing_loggers logging   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Swat009):

 * owner:  nobody => Swat009
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.532a7a1b869d287c7c0d8041f9cfed20%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30553: Misleading logging documentation about disable_existing_loggers default value.

[Django]

#30553: Misleading logging documentation about disable_existing_loggers default
value.
-+-
 Reporter:  darthdragon  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  disable_existing_loggers logging   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by darthdragon):

 I think these two sentences are what may start the headache:

  "By default, the LOGGING setting is merged with Django’s default logging
 configuration using the following scheme.

  If the disable_existing_loggers key in the LOGGING dictConfig is set to
 True (which is the default) then all loggers from the default
 configuration will be disabled. ...

 Because even after reading it 10 times, if you have never looked to python
 logging.config (and I didn't until today, shame on me),  you may not
 understand that also any loggers that may have been defined before are
 also disabled.

 And maybe clarifying in "Django’s default logging configuration", that the
 default django loggers are added with disable_existing_loggers=False.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.f40bfc9d774ba9d943f03f5d92b785a3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30553: Misleading logging documentation about disable_existing_loggers default value.

[Django]

#30553: Misleading logging documentation about disable_existing_loggers default
value.
-+-
 Reporter:  darthdragon  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  disable_existing_loggers logging   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by felixxm):

 You're right I missed that in
 [https://docs.python.org/3/library/logging.config.html#dictionary-schema-
 details dictionary-schema-details].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.6bc241696fe8b167caf4a736ddb980ef%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30553: Misleading logging documentation about disable_existing_loggers default value.

[Django]

#30553: Misleading logging documentation about disable_existing_loggers default
value.
-+-
 Reporter:  darthdragon  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  disable_existing_loggers logging   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 Yeah, it seems this kind of thought was exactly what led to #20981 in the
 first place.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.553c3919385d8678b42f5e818c571d92%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30553: Misleading logging documentation about disable_existing_loggers default value.

[Django]

#30553: Misleading logging documentation about disable_existing_loggers default
value.
-+-
 Reporter:  darthdragon  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  disable_existing_loggers logging   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-

Comment (by Carlton Gibson):

 I think what's meant here is the default for **dictConfig** if
 `disable_existing_loggers` isn't provided.

 > If absent, this parameter defaults to `True`.

 https://docs.python.org/3.7/library/logging.config.html#dictionary-schema-
 details

 I guess the point is that it's important to provide
 `disable_existing_loggers: False` because often the default behaviour is
 not what you want. (''Why aren't my loggers working?'' comes up a lot
 because of this.)

 For me, it'd be worth a rephrase to clarify this. (We see a lot of
 confusions.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.ab7e464d7ae6970c20a71c82c44b8ef5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #30553: Misleading logging documentation about disable_existing_loggers default value. (was: Misleading logging documentation about disable_existing_loggers default value)

[Django]

#30553: Misleading logging documentation about disable_existing_loggers default
value.
-+-
 Reporter:  darthdragon  |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Documentation|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
  disable_existing_loggers logging   |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * version:  2.2 => master
 * type:  Uncategorized => Cleanup/optimization
 * easy:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 Thanks for the report, it seems that this note is incorrect since its
 introduction in 095643e69145d6899313c518fdd39919c9a89908 because we
 changed that in 72c65fea41a6a01f24e134e7627417d94746291a.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.32a4ac81b85eaf2bd7e0fdca9a5ead43%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.