Re: [Django] #31250: assertXMLEqual() crashes on processing instructions.

[Django]

#31250: assertXMLEqual() crashes on processing instructions.
-+-
 Reporter:  Matt Fisher  |Owner:  Yuri
 |  Savin
 Type:  Bug  |   Status:  closed
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"54b7af7eb4107f933d14da0737b539bbe38d0fc8" 54b7af7e]:
 {{{
 #!CommitTicketReference repository=""
 revision="54b7af7eb4107f933d14da0737b539bbe38d0fc8"
 Fixed #31250 -- Ignored processing instructions in
 assertXMLEqual()/assertXMLNotEqual().
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.fc1f265993b324c48c7e78331743f3ad%40djangoproject.com.

Re: [Django] #31250: assertXMLEqual() crashes on processing instructions.

[Django]

#31250: assertXMLEqual() crashes on processing instructions.
-+-
 Reporter:  Matt Fisher  |Owner:  Yuri
 |  Savin
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.99f4135a28c981b83f92ddcd2cdffd4c%40djangoproject.com.

Re: [Django] #31250: assertXMLEqual() crashes on processing instructions.

[Django]

#31250: assertXMLEqual() crashes on processing instructions.
---+--
 Reporter:  Matt Fisher|Owner:  Yuri Savin
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1c5e597654fc4811f5ae19ade097561b%40djangoproject.com.

Re: [Django] #31250: assertXMLEqual() crashes on processing instructions.

[Django]

#31250: assertXMLEqual() crashes on processing instructions.
---+--
 Reporter:  Matt Fisher|Owner:  Yuri Savin
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--

Comment (by Yuri Savin):

 Replying to [comment:5 felixxm]:
 > Yuri, you shouldn't mark you own patches as "Ready for checkin".
 Oh, I'm sorry. I'm trying to notify you that the patch is ready

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.5b82e858fd7353e2bf0e661613e032f3%40djangoproject.com.

Re: [Django] #31250: assertXMLEqual() crashes on processing instructions.

[Django]

#31250: assertXMLEqual() crashes on processing instructions.
---+--
 Reporter:  Matt Fisher|Owner:  Yuri Savin
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by felixxm):

 * has_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Yuri, you shouldn't mark you own patches as "Ready for checkin".

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.1c6bbbed5f15b6d832ca3c3949989a06%40djangoproject.com.

Re: [Django] #31250: assertXMLEqual() crashes on processing instructions.

[Django]

#31250: assertXMLEqual() crashes on processing instructions.
-+-
 Reporter:  Matt Fisher  |Owner:  Yuri
 |  Savin
 Type:  Bug  |   Status:  assigned
Component:  Testing framework|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Yuri Savin):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.4f45e9cb888063127695ded58a6d7eb6%40djangoproject.com.

Re: [Django] #31250: assertXMLEqual() crashes on processing instructions.

[Django]

#31250: assertXMLEqual() crashes on processing instructions.
---+--
 Reporter:  Matt Fisher|Owner:  Yuri Savin
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--

Comment (by Yuri Savin):

 Write PR for this ticket https://github.com/django/django/pull/12446
 Added a check for the availability of fields in the node. The original
 branch was passed nodes COMMENT_NODE and DOCUMENT_TYPE_NODE. I left pass
 only COMMENT_NODE

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e964cf2c7bd7f3abc629aa1b926c0701%40djangoproject.com.

Re: [Django] #31250: assertXMLEqual() crashes on processing instructions.

[Django]

#31250: assertXMLEqual() crashes on processing instructions.
---+--
 Reporter:  Matt Fisher|Owner:  Yuri Savin
 Type:  Bug|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by Yuri Savin):

 * owner:  nobody => Yuri Savin
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.aa2318322ab92ebf5dc9c1260ef7c1f2%40djangoproject.com.

Re: [Django] #31250: assertXMLEqual() crashes on processing instructions. (was: assertXMLEqual fails on processing instructions)

[Django]

#31250: assertXMLEqual() crashes on processing instructions.
---+
 Reporter:  Matt Fisher|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by felixxm):

 * version:  3.0 => master
 * easy:  0 => 1
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.b1f78be13e6cf7b43ec21378be28d3de%40djangoproject.com.