Re: [Django] #31597: New "Clear all filters" shown always in raw_id_fields popup

[Django]

#31597: New "Clear all filters" shown always in raw_id_fields popup
---+--
 Reporter:  frnhr  |Owner:  frnhr
 Type:  Uncategorized  |   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by frnhr):

 * owner:  nobody => frnhr
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.9b90029528326a889ce20c6788c64088%40djangoproject.com.

Re: [Django] #31597: New "Clear all filters" shown always in raw_id_fields popup

[Django]

#31597: New "Clear all filters" shown always in raw_id_fields popup
---+--
 Reporter:  frnhr  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Description changed by frnhr:

Old description:

> The new "Clear all filters" link does not play nice with `raw_id_fields`
> lookup popup window. The new link is shown in the popup regardless of any
> filters being selected or not.
>
> Present in `3.1a1`.
>

> To reproduce:
>
>  * create two models, `ModelA` and `ModelB`
>  * create a Foreign key field on `ModelA` pointing to `ModelB`
>  * create a boolean field on `ModelB`
>
>  * create an admin page for `ModelA`
>  * add the FK field to `raw_id_fields` list
>
>  * create an admin page for `ModelB`
>  * add the boolean field to `list_filter` list
>
>  * open the admin page in a browser
>  * click on the "magnifying class" icon for the `ModelB` field
>
>  * expected:
> * no `X Clear all filters` link
>
>  * actual:
> * yes `X Clear all filters` link
>

> Additionally, clicking the link removes `_to_field` query param, which it
> should not do (`_popup` param is correctly preserved).
>
> [[Image(clearallfiltersrawidfields.png)]]

New description:

 The new "Clear all filters" link does not play nice with `raw_id_fields`
 lookup popup window. The new link is shown in the popup regardless of any
 filters being selected or not.

 Present in `3.1a1`.


 To reproduce:

  * create two models, `ModelA` and `ModelB`
  * create a Foreign key field on `ModelA` pointing to `ModelB`
  * create a boolean field on `ModelB`

  * create an admin page for `ModelA`
  * add the FK field to `raw_id_fields` list

  * create an admin page for `ModelB`
  * add the boolean field to `list_filter` list

  * open the admin page in a browser
  * click on the "magnifying class" icon for the `ModelB` field

  * expected:
 * no `X Clear all filters` link

  * actual:
 * yes `X Clear all filters` link


 Additionally, clicking the link removes `_to_field` query param, which it
 should not do (`_popup` param is correctly preserved).

 [[Image(clearallfiltersrawidfields.jpg)]]

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.dc6998eb75ed33aca1e0263c57dcf8ef%40djangoproject.com.

Re: [Django] #31597: New "Clear all filters" shown always in raw_id_fields popup

[Django]

#31597: New "Clear all filters" shown always in raw_id_fields popup
---+--
 Reporter:  frnhr  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by frnhr):

 * Attachment "clearallfiltersrawidfields.jpg" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.a34a836468a0c7ca5a678967618c3f42%40djangoproject.com.

Re: [Django] #31597: New "Clear all filters" shown always in raw_id_fields popup

[Django]

#31597: New "Clear all filters" shown always in raw_id_fields popup
---+--
 Reporter:  frnhr  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by frnhr):

 * Attachment "clearallfiltersrawidfields.jpg" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.fcd832d479897ab2f76e005526318c4f%40djangoproject.com.