Re: [Django] #31636: BooleanFieldListFilter doesn't respect field choices.

[Django]

#31636: BooleanFieldListFilter doesn't respect field choices.
-+-
 Reporter:  Maxence G|Owner:  Manav
 |  Agarwal
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"580a4341cb0b4cbfc215a70afc004875a7e815f4" 580a4341]:
 {{{
 #!CommitTicketReference repository=""
 revision="580a4341cb0b4cbfc215a70afc004875a7e815f4"
 Fixed #31636 -- Made BooleanFieldListFilter respect Field.choices.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.0b44259609c0b02b737afd06fc60c49b%40djangoproject.com.

Re: [Django] #31636: BooleanFieldListFilter doesn't respect field choices.

[Django]

#31636: BooleanFieldListFilter doesn't respect field choices.
-+-
 Reporter:  Maxence G|Owner:  Manav
 |  Agarwal
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by felixxm):

 * needs_better_patch:  1 => 0
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.8347d5c66a903f2b4763e3660d80d0c4%40djangoproject.com.

Re: [Django] #31636: BooleanFieldListFilter doesn't respect field choices.

[Django]

#31636: BooleanFieldListFilter doesn't respect field choices.
---+-
 Reporter:  Maxence G  |Owner:  Manav Agarwal
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+-
Changes (by felixxm):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.eb993efc8867d6083b1964c516174094%40djangoproject.com.

Re: [Django] #31636: BooleanFieldListFilter doesn't respect field choices.

[Django]

#31636: BooleanFieldListFilter doesn't respect field choices.
---+-
 Reporter:  Maxence G  |Owner:  Manav Agarwal
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+-
Changes (by felixxm):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


Comment:

 [https://github.com/django/django/pull/13413 New PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.e2c443530f8c7a7f76c6281cc1c99f4c%40djangoproject.com.

Re: [Django] #31636: BooleanFieldListFilter doesn't respect field choices.

[Django]

#31636: BooleanFieldListFilter doesn't respect field choices.
---+-
 Reporter:  Maxence G  |Owner:  Manav Agarwal
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+-
Changes (by Manav Agarwal):

 * owner:  Ninad Kulkrni => Manav Agarwal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.5b81e9ad329b638a3d5ab3b462c23b37%40djangoproject.com.

Re: [Django] #31636: BooleanFieldListFilter doesn't respect field choices.

[Django]

#31636: BooleanFieldListFilter doesn't respect field choices.
---+-
 Reporter:  Maxence G  |Owner:  Ninad Kulkrni
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+-

Comment (by Manav Agarwal):

 May i work on this issue?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.aac544e31a6a18f1194724f0221c5070%40djangoproject.com.

Re: [Django] #31636: BooleanFieldListFilter doesn't respect field choices.

[Django]

#31636: BooleanFieldListFilter doesn't respect field choices.
---+--
 Reporter:  Maxence G  |Owner:  Jithin Tom
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by felixxm):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 [https://github.com/django/django/pull/13047 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.d205fd1540224d436cccdf200c6f2087%40djangoproject.com.

Re: [Django] #31636: BooleanFieldListFilter doesn't respect field choices.

[Django]

#31636: BooleanFieldListFilter doesn't respect field choices.
---+--
 Reporter:  Maxence G  |Owner:  jithintomz
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by jithintomz):

 * owner:  nobody => jithintomz
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.5a8de0cb64ce1c7185f911944d301bf3%40djangoproject.com.

Re: [Django] #31636: BooleanFieldListFilter doesn't respect field choices. (was: Django Bool choices text and admin filter)

[Django]

#31636: BooleanFieldListFilter doesn't respect field choices.
---+
 Reporter:  Maxence G  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by felixxm):

 * version:  3.0 => master
 * stage:  Unreviewed => Accepted


Comment:

 Thanks, we could probably use `field.flatchoices`, e.g.
 {{{
 diff --git a/django/contrib/admin/filters.py
 b/django/contrib/admin/filters.py
 index 3e02cd89d7..9fdf038085 100644
 --- a/django/contrib/admin/filters.py
 +++ b/django/contrib/admin/filters.py
 @@ -244,10 +244,7 @@ class BooleanFieldListFilter(FieldListFilter):
  return [self.lookup_kwarg, self.lookup_kwarg2]

  def choices(self, changelist):
 -for lookup, title in (
 -(None, _('All')),
 -('1', _('Yes')),
 -('0', _('No'))):
 +for lookup, title in ((None, _('All')), *self.field.flatchoices):
  yield {
  'selected': self.lookup_val == lookup and not
 self.lookup_val2,
  'query_string':
 changelist.get_query_string({self.lookup_kwarg: lookup},
 [self.lookup_kwarg2]),
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.947c61cf6ecc6b1b1e5ecfbf47cc680f%40djangoproject.com.