Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
-+-
 Reporter:  Denis Anuschewski|Owner:  Abhijeet
 Type:   |  Singh
  Cleanup/optimization   |   Status:  assigned
Component:  Error reporting  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Comment (by Denis Anuschewski):

 Hey there.

 In the meantime I came up with my own approach. You can check out my PR if
 you like: https://github.com/django/django/pull/18198

 The collapsible code line elements are now rendered as details/summary
 tags and are slightly more highlighted by having a thin border plus a
 differently colored icon (+/-) which indicates toggling functionality.

 Some javascript was needed for adjusting the behavior of the
 details/summary tags as they did not allow the center code line element to
 be in the middle after opening (it always pops up on top). But it's not
 much and the end result works and feels the same as with native details
 and summary tags. Plus the HTML markup is now more semantic.

 With the new changes you can also "step" through the elements by clicking
 on tab/shift+tab and easily open and close them without losing focus.
 Keyboard ninjas will hopefully appreciate this ⌨️亮

 
[[Image(https://code.djangoproject.com/attachment/ticket/35137/collapsibles.png)]]

 Cheers
 Denis
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018fb1c511ac-34244947-5ecc-4fc6-bce7-8a0b5eaf8b13-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
-+-
 Reporter:  Denis Anuschewski|Owner:  Abhijeet
 Type:   |  Singh
  Cleanup/optimization   |   Status:  assigned
Component:  Error reporting  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Denis Anuschewski):

 * Attachment "collapsibles.png" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018fb1c3bbee-6179095a-c341-4c03-82f8-9804ce9351a5-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
-+-
 Reporter:  Denis Anuschewski|Owner:  Abhijeet
 Type:   |  Singh
  Cleanup/optimization   |   Status:  assigned
Component:  Error reporting  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Comment (by Abhijeet Singh):

 Hay! I just opened a Discord Thred to discuss the Patch Improvement, I
 would appreciate if you checked it out
 (https://discordapp.com/channels/856567261900832808/1236418777323671633)
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f45729291-cdba77c6-4a0e-44a0-b1a4-2c5bca75fce1-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
-+-
 Reporter:  Denis Anuschewski|Owner:  Abhijeet
 Type:   |  Singh
  Cleanup/optimization   |   Status:  assigned
Component:  Error reporting  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Sarah Boyce):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f0f80eda9-30bf2ef4-823a-4509-9eea-087c0e84cd33-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
-+-
 Reporter:  Denis Anuschewski|Owner:  Abhijeet
 Type:   |  Singh
  Cleanup/optimization   |   Status:  assigned
Component:  Error reporting  |  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Comment (by Sarah Boyce):

 Note that #35189 also deals with collapsible elements and accessibility
 concerns might be similar both (and might make sense to be reviewed
 together).
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018ebe87150d-3e7ce4f1-473f-4eeb-80c5-695de3a5d6dd-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
--+
 Reporter:  Denis Anuschewski |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Error reporting   |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  1
--+
Comment (by Denis Anuschewski):

 Another suggestion for a simple solution:

 Adapt the icon for the collapsible link "Local vars" just under the gray
 error box (placed on the left of the line number just like Thibaud
 mentioned).
 Plus implement a thin border to let the box stand out more.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d41a58a50-730e1b2c-db4f-43f8-b450-fd2a7a24c51f-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
--+
 Reporter:  Denis Anuschewski |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Error reporting   |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  1
--+
Comment (by Thibaud Colas):

 Note there are three separate issues here:

 1. Bug: the current implementation is unusable for keyboard and voice
 control users due to adding interactivity to list item elements.
 2. Somewhere between a bug and a usability fail: placing the "this is
 collapsible" signifier all the way to the right means it’s more or less
 impossible to spot for users of screen magnification
 3. And usability issue – it’s hard to understand this is interactive.

 I’d recommend fixing them all at once by introducing a "toggle" button to
 the left of the line number, so we can solve the issue at hand without
 reinventing the current designs. That button will be focusable and can
 either have a visible "toggle" label or icon + tooltip, plus hover styles
 (see for example
 
[https://github.com/django/django/commit/3f6d939c62efd967f548c27a265748cc2cc47ca5
 how GitHub does it]).
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d4182de8f-3c11f22a-b3e9-467c-849d-8a5a308aae31-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
--+
 Reporter:  Denis Anuschewski |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Error reporting   |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  1
--+

Comment (by Denis Anuschewski):

 https://forum.djangoproject.com/t/usability-of-server-error-traceback-
 collapsibles/27322

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d37fb6713-c220c0d4-e419-4f55-90d3-55d40b7a2dc4-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
--+
 Reporter:  Denis Anuschewski |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Error reporting   |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  1
--+

Comment (by Denis Anuschewski):

 Hey Natalia.

 Thx, will do that.

 Shout out to Thibaud Colas who 1st found this behaviour.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d37f26b4b-5a60da83-4c01-4692-b86e-809813f57506-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
--+
 Reporter:  Denis Anuschewski |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Error reporting   |  Version:  dev
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  1
--+
Changes (by Natalia Bidart):

 * cc: Thibaud Colas, Tom Carrick, Sarah Abderemane (added)
 * type:  Bug => Cleanup/optimization
 * version:  5.0 => dev
 * component:  Uncategorized => Error reporting
 * stage:  Unreviewed => Accepted


Comment:

 Accepting on the basis that I have used Django for more than 15 years and
 I did not know this existed!!!
 I agree that improving the discoverability of this feature would certainly
 be a positive thing for the framework.

 Denis, would you like to prepare a patch? I would suggest to first reach
 out to the Django Accessibility Team
 ([https://forum.djangoproject.com/c/internals/accessibility/26 via the
 Django forum]) to agree on a proper accessible design fix. Thank you!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d37ccbcec-8fe40a6f-4423-4963-9638-4dce2e014f25-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
---+--
 Reporter:  Denis Anuschewski  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Uncategorized  |  Version:  5.0
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+--
Changes (by Denis Anuschewski):

 * type:  Cleanup/optimization => Bug


Old description:

> On the debug page for a server error the collapsible elements in the
> traceback view do not clearly indicate that they are in fact interactive:
>
> 1) The little icon on the right corner is way too small I think and also
> far away from the element's inner content (see
> [https://ant.design/components/collapse] for a possible alternative).
>
> 2) The element does not stand out in a way that it indicates it's
> interactive. It could have e.g. a border to separate it from the
> background.
>
> Also the elements are not selectable via keyboard and the tab button.
>
> Example: [https://django-admin-
> tests.netlify.app/django_admin_tests/v5.1/english/defaults/500/]

New description:

 [[Image(https://code.djangoproject.com/raw-attachment/ticket/35137
 /stacktrace-error.png)]]

 On the debug page for a server error the collapsible elements in the
 traceback view do not clearly indicate that they are in fact interactive:

 1) The little icon on the right corner is way too small I think and also
 far away from the element's inner content (see
 [https://ant.design/components/collapse] for a possible alternative).

 2) The element does not stand out in a way that it indicates it's
 interactive. It could have e.g. a border to separate it from the
 background.

 Also the elements are not selectable via keyboard and the tab button.

 Example: [https://django-admin-
 tests.netlify.app/django_admin_tests/v5.1/english/defaults/500/]

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d37642f53-dbe1122f-8bce-462d-b431-32b8c579a555-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
-+-
 Reporter:  Denis Anuschewski|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Description changed by Denis Anuschewski:

Old description:

> On the debug page for a server error the collapsible elements in the
> traceback view do not clearly indicate that they are in fact interactive:
>
> 1) The little icon on the right corner is way too small I think and also
> far away from the element's inner content (see
> [https://ant.design/components/collapse] for a possible alternative).
>
> 2) The element does not stand out in a way that it indicates it's
> interactive. It could have e.g. a border to separate it from the
> background.
>
> Also the elements are not selectable via keyboard and the tab button.
>
> Example: [https://django-admin-
> tests.netlify.app/django_admin_tests/v5.1/english/defaults/500/]
>
> [[Image(https://code.djangoproject.com/attachment/ticket/35137
> /stacktrace-error.png)]]

New description:

 On the debug page for a server error the collapsible elements in the
 traceback view do not clearly indicate that they are in fact interactive:

 1) The little icon on the right corner is way too small I think and also
 far away from the element's inner content (see
 [https://ant.design/components/collapse] for a possible alternative).

 2) The element does not stand out in a way that it indicates it's
 interactive. It could have e.g. a border to separate it from the
 background.

 Also the elements are not selectable via keyboard and the tab button.

 Example: [https://django-admin-
 tests.netlify.app/django_admin_tests/v5.1/english/defaults/500/]

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d375a8a02-414e7add-77de-487c-a9ae-0cf927de7895-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
-+-
 Reporter:  Denis Anuschewski|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Description changed by Denis Anuschewski:

Old description:

> On the debug page for a server error the collapsible elements in the
> traceback view do not clearly indicate that they are in fact interactive:
>
> 1) The little icon on the right corner is way too small I think and also
> far away from the element's inner content (see
> [https://ant.design/components/collapse] for a possible alternative).
>
> 2) The element does not stand out in a way that it indicates it's
> interactive. It could have e.g. a border to separate it from the
> background.
>
> Also the elements are not selectable via keyboard and the tab button.
>
> Example: [https://django-admin-
> tests.netlify.app/django_admin_tests/v5.1/english/defaults/500/]

New description:

 On the debug page for a server error the collapsible elements in the
 traceback view do not clearly indicate that they are in fact interactive:

 1) The little icon on the right corner is way too small I think and also
 far away from the element's inner content (see
 [https://ant.design/components/collapse] for a possible alternative).

 2) The element does not stand out in a way that it indicates it's
 interactive. It could have e.g. a border to separate it from the
 background.

 Also the elements are not selectable via keyboard and the tab button.

 Example: [https://django-admin-
 tests.netlify.app/django_admin_tests/v5.1/english/defaults/500/]

 [[Image(https://code.djangoproject.com/attachment/ticket/35137/stacktrace-
 error.png)]]

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d375a3b70-f2930479-abe1-493d-a32f-9518eab3fa0c-00%40eu-central-1.amazonses.com.

Re: [Django] #35137: Collapsible error container elements do not indicate that they are interactive

[Django]

#35137: Collapsible error container elements do not indicate that they are
interactive
-+-
 Reporter:  Denis Anuschewski|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Denis Anuschewski):

 * Attachment "stacktrace-error.png" added.


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d37586a29-e836a07d-6fde-4c44-903c-576b31fde1a1-00%40eu-central-1.amazonses.com.