Re: [Django] #35145: Django admin’s dark theme should set color-scheme property for vanilla HTML components

[Django]

#35145: Django admin’s dark theme should set color-scheme property for vanilla 
HTML
components
-+-
 Reporter:  Thibaud Colas|Owner:  Eliana
 |  Rosselli
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  accessibility,   | Triage Stage:  Ready for
  color contrast, dark mode, dark|  checkin
  theme  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed

Comment:

 In [changeset:"b47bdb4cd9149ee2a39bf1cc9996a36a940bd7d9" b47bdb4c]:
 {{{#!CommitTicketReference repository=""
 revision="b47bdb4cd9149ee2a39bf1cc9996a36a940bd7d9"
 Fixed #35145 -- Corrected color scheme of vanilla HTML widgets in admin.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d8d89c25d-e5cebf29-eec6-4bcd-9954-2d66155f05e6-00%40eu-central-1.amazonses.com.

Re: [Django] #35145: Django admin’s dark theme should set color-scheme property for vanilla HTML components

[Django]

#35145: Django admin’s dark theme should set color-scheme property for vanilla 
HTML
components
-+-
 Reporter:  Thibaud Colas|Owner:  Eliana
 |  Rosselli
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Ready for
  color contrast, dark mode, dark|  checkin
  theme  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d8d2e5c85-3efbc9d2-5b9a-4e52-beff-a0c5a8c235a7-00%40eu-central-1.amazonses.com.

Re: [Django] #35145: Django admin’s dark theme should set color-scheme property for vanilla HTML components

[Django]

#35145: Django admin’s dark theme should set color-scheme property for vanilla 
HTML
components
-+-
 Reporter:  Thibaud Colas|Owner:  Eliana
 |  Rosselli
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  color contrast, dark mode, dark|
  theme  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Natalia Bidart):

 * has_patch:  0 => 1
 * needs_tests:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d6110dd6d-24484439-5f2b-4fe3-a99c-029549626a29-00%40eu-central-1.amazonses.com.

Re: [Django] #35145: Django admin’s dark theme should set color-scheme property for vanilla HTML components

[Django]

#35145: Django admin’s dark theme should set color-scheme property for vanilla 
HTML
components
-+-
 Reporter:  Thibaud Colas|Owner:  Eliana
 |  Rosselli
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  color contrast, dark mode, dark|
  theme  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Eliana Rosselli):

 * owner:  nobody => Eliana Rosselli
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d460b7745-f440bdc8-5b9e-4780-934f-4115bf5e1cb1-00%40eu-central-1.amazonses.com.

Re: [Django] #35145: Django admin’s dark theme should set color-scheme property for vanilla HTML components

[Django]

#35145: Django admin’s dark theme should set color-scheme property for vanilla 
HTML
components
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:  Accepted
  color contrast, dark mode, dark|
  theme  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Mariusz Felisiak):

 * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d4406f6fc-73f1d5ff-470d-42d0-9dc7-cca8d2704ece-00%40eu-central-1.amazonses.com.

Re: [Django] #35145: Django admin’s dark theme should set color-scheme property for vanilla HTML components

[Django]

#35145: Django admin’s dark theme should set color-scheme property for vanilla 
HTML
components
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:
  color contrast, dark mode, dark|  Unreviewed
  theme  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Description changed by Thibaud Colas:

Old description:

> The Django admin uses unstyled vanilla HTML widgets for a few scenarios.
> Currently in the dark theme those elements are displayed with the
> browser’s default "light" UI – it would better if we instructed the
> browser to use their dark variant with the CSS `color-scheme` property.
>
> Here’s an example, where [https://developer.mozilla.org/en-
> US/docs/Web/CSS/color-scheme color-scheme] affects the search field’s
> clear button color and checkboxes, before/after:
>

>
> - For the clear button it’s almost invisible without this so is a clear
> accessibility issue / WCAG contrast fail
> - For the checkboxes it just looks better.
>
> This also affects file inputs, multi-select widgets, scrollbars, and I’m
> sure other parts of the UI.
>
> ---
>
> My suggested solution would be to add `color-scheme: dark` at the root
> level when in dark mode, but it might be worth researching a bit to make
> sure we use the property as well as possible.

New description:

 The Django admin uses unstyled vanilla HTML widgets for a few scenarios.
 Currently in the dark theme those elements are displayed with the
 browser’s default "light" UI – it would better if we instructed the
 browser to use their dark variant with the CSS `color-scheme` property.

 Here’s an example, where [https://developer.mozilla.org/en-US/docs/Web/CSS
 /color-scheme color-scheme] affects the search field’s clear button color
 and checkboxes, before/after:

 [[Image(https://code.djangoproject.com/raw-attachment/ticket/35145/color-
 scheme-django.gif)]]

 - For the clear button it’s almost invisible without this so is a clear
 accessibility issue / WCAG contrast fail
 - For the checkboxes it just looks better.

 This also affects file inputs, multi-select widgets, scrollbars, and I’m
 sure other parts of the UI.

 ---

 My suggested solution would be to add `color-scheme: dark` at the root
 level when in dark mode, but it might be worth researching a bit to make
 sure we use the property as well as possible.

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d42b1785e-c9f7f901-4f30-444b-a00f-c87e42fe375b-00%40eu-central-1.amazonses.com.

Re: [Django] #35145: Django admin’s dark theme should set color-scheme property for vanilla HTML components

[Django]

#35145: Django admin’s dark theme should set color-scheme property for vanilla 
HTML
components
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:
  color contrast, dark mode, dark|  Unreviewed
  theme  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Comment (by Thibaud Colas):

 cc @erosselli who was interested in working on this (but please wait for
 it to be approved)
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d42b0f8f7-02a72044-d4b9-49ed-a17a-265d08361601-00%40eu-central-1.amazonses.com.

Re: [Django] #35145: Django admin’s dark theme should set color-scheme property for vanilla HTML components

[Django]

#35145: Django admin’s dark theme should set color-scheme property for vanilla 
HTML
components
-+-
 Reporter:  Thibaud Colas|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:  accessibility,   | Triage Stage:
  color contrast, dark mode, dark|  Unreviewed
  theme  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Thibaud Colas):

 * Attachment "color-scheme-django.gif" added.

 Recording of color-scheme set to dark and unset in Django admin
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018d42ad01d7-3c697c64-6c4d-438d-bb37-2702cc0848fe-00%40eu-central-1.amazonses.com.