Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-06-20 Thread Django
#35404: Admin fieldset multiple flexbox regressions
-+-
 Reporter:  minusf   |Owner:  Vaarun
 |  Sinha
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  css admin fieldset   | Triage Stage:  Accepted
  accessibility  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

 In [changeset:"ba81b3f0a35c7753419b4adcf0daca64466c930c" ba81b3f0]:
 {{{#!CommitTicketReference repository=""
 revision="ba81b3f0a35c7753419b4adcf0daca64466c930c"
 [5.1.x] Refs #35404 -- Fixed padding of admin fieldset checkbox label.

 Backport of 9691a00d5839e6137a2716526277013af9ee97ff from main.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107019034982080-e27e1ff2-4ac2-45d3-9181-e071bf9e99a1-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-06-20 Thread Django
#35404: Admin fieldset multiple flexbox regressions
-+-
 Reporter:  minusf   |Owner:  Vaarun
 |  Sinha
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  css admin fieldset   | Triage Stage:  Accepted
  accessibility  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

 In [changeset:"9691a00d5839e6137a2716526277013af9ee97ff" 9691a00d]:
 {{{#!CommitTicketReference repository=""
 revision="9691a00d5839e6137a2716526277013af9ee97ff"
 Refs #35404 -- Fixed padding of admin fieldset checkbox label.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107019034960a4b-8cf64e17-48c5-41ba-ac30-de59b1810205-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-06-18 Thread Django
#35404: Admin fieldset multiple flexbox regressions
-+-
 Reporter:  minusf   |Owner:  Vaarun
 |  Sinha
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  css admin fieldset   | Triage Stage:  Accepted
  accessibility  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Comment (by Vaarun Sinha):

 https://github.com/VaarunSinha/contribution-
 notes/blob/main/django/ticket_35404/notes.md

 The checkbox issue has been fixed, and these are my contribution notes.

 I will be committing and creating a PR soon.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701902ef09ca3-18aafa49-e4d5-454c-9253-78097e991627-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-06-17 Thread Django
#35404: Admin fieldset multiple flexbox regressions
-+-
 Reporter:  minusf   |Owner:  Vaarun
 |  Sinha
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  css admin fieldset   | Triage Stage:  Accepted
  accessibility  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Vaarun Sinha):

 * owner:  nobody => Vaarun Sinha
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107019025669ee3-cc1d04e1-66eb-4e32-939d-c6071531e5eb-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-05-10 Thread Django
#35404: Admin fieldset multiple flexbox regressions
-+-
 Reporter:  minusf   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  css admin fieldset   | Triage Stage:  Accepted
  accessibility  |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Sarah Boyce):

 * has_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f61fd092a-c260fe48-912c-44db-b7dc-a67a975e2d29-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-05-10 Thread Django
#35404: Admin fieldset multiple flexbox regressions
-+-
 Reporter:  minusf   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  css admin fieldset   | Triage Stage:  Accepted
  accessibility  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Comment (by Sarah Boyce <42296566+sarahboyce@…>):

 In [changeset:"dd46cab6e076ec766ef0727a16f4219e3e6cb552" dd46cab]:
 {{{#!CommitTicketReference repository=""
 revision="dd46cab6e076ec766ef0727a16f4219e3e6cb552"
 Refs #35404 -- Fixed the line height of admin fieldset labels.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f61fcb5f9-a446c570-1999-471f-b31e-52d18dbea3cd-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-05-10 Thread Django
#35404: Admin fieldset multiple flexbox regressions
-+-
 Reporter:  minusf   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  4.2
 Severity:  Normal   |   Resolution:
 Keywords:  css admin fieldset   | Triage Stage:  Accepted
  accessibility  |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  1
-+-
Changes (by Sarah Boyce):

 * keywords:  css admin fieldset => css admin fieldset accessibility

Comment:

 Replying to [comment:9 minusf]:
 > Regarding `help_text`, I think that with this small font `line-height:
 normal` is not enough:
 > {{{#!diff
 > M django/contrib/admin/static/admin/css/base.css
 > @@ -268,6 +268,7 @@ hr {
 >  .help, p.help, form p.help, div.help, form div.help, div.help li {
 >  font-size: 0.6875rem;
 >  color: var(--body-quiet-color);
 > +line-height: 1.5;
 >  }
 > ·
 >  div.help ul {
 > }}}

 I don't think, taking into account the way the admin is already, this css
 change clearly fixes an issue/bug.

 I think a wider discussion on whether the fonts and spacing in the admin
 is too small (with the accessibility team involved) is a good idea, but
 out of scope of this ticket.
 There are many small tweaks we can make to css and there is a lot of
 subjectivity around what looks "better", so let's fix the issue as
 reported and create further discussions as necessary. Then the changes we
 make are scoped out and made to all required areas at once, rather than a
 series of many small tweaks requiring many reviews. I hope that makes
 sense 
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f61de4d3d-ff9b793c-a0fe-4521-9af0-db187507e312-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-05-09 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  4.2
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Comment (by minusf):

 Regarding `help_text`, I think that with this small font `line-height:
 normal` is not enough:
 {{{#!diff
 M django/contrib/admin/static/admin/css/base.css
 @@ -268,6 +268,7 @@ hr {
  .help, p.help, form p.help, div.help, form div.help, div.help li {
  font-size: 0.6875rem;
  color: var(--body-quiet-color);
 +line-height: 1.5;
  }
 ·
  div.help ul {
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f5efe4f46-a98b022f-be49-4051-9d19-32f07ddbe5cc-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-05-09 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  4.2
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Changes (by minusf):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f5e3b79ea-07ed3330-88bc-40e1-b744-ea9343602d65-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-05-09 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  4.2
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Comment (by minusf):

 Replying to [comment:6 Sarah Boyce]:
 > In case I was misunderstood, for the css we were looking at `line-
 height: 1;` was overriding an existing larger line-height. Generally, I
 would like our css have good defaults and not have too much being
 overriden for particular classes/elements.

 Yes, I see what you mean. Removing it sets `line-height: normal` (by user
 agent), which according to mdn is "a default value of roughly 1.2,
 depending on the element's font-family"...

 https://github.com/django/django/pull/18151
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f5e3b45b8-1cc2127b-6de4-41cb-ad3a-eedfc0210ba0-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-05-08 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  4.2
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Comment (by Sarah Boyce):

 > strongly benefit in readability with line-height at least 1.2 to 1.5
 depending on font type
 I agree 1 is too small 
 In case I was misunderstood, for the css we were looking at `line-height:
 1;` was overriding an existing larger line-height. Generally, I would like
 our css have good defaults and not have too much being overriden for
 particular classes/elements.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f574773df-f4bf9737-d8f5-450e-be38-2d9bb7461db1-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-05-07 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  4.2
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Changes (by minusf):

 * Attachment "admin-help-text.png" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f54d6e73f-1aabb949-6089-44c6-827d-f08256dd6538-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-05-07 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  4.2
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Changes (by minusf):

 * Attachment "Screenshot 2024-05-07 at 22.53.11.png" removed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f54d65980-22c3999f-d09a-4479-9c9e-9b83a9e10010-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-05-07 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  4.2
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Changes (by minusf):

 * Attachment "Screenshot 2024-05-07 at 22.53.11.png" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f54d6300e-5578dd9d-4e98-45e5-ad7d-1ac36f2438d6-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-05-07 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  4.2
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Comment (by minusf):

 > I think you can also remove the line-height

 I might be wrong but afaik multiline paragraphs strongly benefit in
 readability with `line-height` at least `1.2` to `1.5` depending on font
 type... This is an actual issue in the admin how it shows `help_text` as
 well and I meant to send a patch for that for years...
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f54d5e5bb-93621a64-81ca-483e-91f4-14e8d9351d2f-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-04-29 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  4.2
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Comment (by Sarah Boyce):

 > If you are happy with the patch for the height issue (no 2.), ...

 I think you can also remove the line-height

 {{{#!diff
 M django/contrib/admin/static/admin/css/forms.css
 @@ -84,14 +84,13 @@ form ul.inline li {
  min-width: 160px;
  width: 160px;
  word-wrap: break-word;
 -line-height: 1;
  }

  .aligned label:not(.vCheckboxLabel):after {
  content: '';
  display: inline-block;
  vertical-align: middle;
 -height: 1.625rem;
  }

 }}}
 Looks ok to me
 [[Image(image-20240429-085114.png)]]

 > ...,  I can start a pull request and work from there.

 Please do! I also think (2) should be a separate commit to (1) and (3)
 (maybe a commit message something like... Refs #35404 -- Fixed line height
 of admin fieldset labels.)
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f28a57141-fb511c93-bada-4ea1-a8b4-32becb60abba-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-04-29 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  4.2
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Changes (by Sarah Boyce):

 * Attachment "image-20240429-085114.png" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f289f30d1-07ae69db-190a-43dd-9c9e-a5bc434ced7f-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-04-26 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  4.2
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Comment (by minusf):

 Thank your for looking into this. Interesting that for so long nobody
 reported this.

 I am sorry but I think the help_text is not helping much, personally my
 eyes are still bleeding ;-)

 If you are happy with the patch for the height issue (no 2.), I can start
 a pull request and work from there.

 The first couple of "fixes" I tried were not effective and it seems like I
 have to dive into flex myself much deeper as my understanding of it is
 flawed.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f1bad2a04-4f9b5cbc-2f68-48b5-8f61-8c25548ec737-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-04-25 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  4.2
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+
Changes (by Sarah Boyce):

 * stage:  Unreviewed => Accepted
 * version:  5.0 => 4.2

Comment:

 Thank you for the report and screenshots! Replicated 

 For reference, this is how these examples looked on 4.1 (ignore the red
 dot)
 [[Image(image-20240425-090901.png)]]

 1 and 3 are regressions from 96a598356a9ea8c2c05b22cadc12e256a3b295fd, 2
 is a long standing issue.

 Unsure what is the best option for 1, because the grow behaviour looks
 better when there is help text.
 Happy to receive suggestions or to default to the previous behaviour.
 [[Image(image-20240425-092610.png)]]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f1429e5c7-55d6e273-c8e2-4f50-899d-941169166d63-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-04-25 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+--
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  5.0
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+--
Changes (by Sarah Boyce):

 * Attachment "image-20240425-092610.png" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f1425c15f-9cfd4de7-4ad0-4e3e-b313-afd47cc6dc6f-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-04-25 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+--
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  5.0
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+--
Changes (by Sarah Boyce):

 * Attachment "image-20240425-090901.png" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f14160eaf-2980c26b-2cc6-451c-ba84-e4f01700bd48-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-04-24 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+--
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  5.0
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+--
Description changed by minusf:

Old description:

> Hello. I have noticed a couple regressions in the admin fieldset css. I
> think they are all related to switching `` to
> flexbox.
>
> 1. input type=text boxes on the right side grow in height if the label
> doesn't fit into 160px.
>
> 2. long labels have uncovered another issue: incorrect line height and a
> forced height in general.
>
> 3. checkboxes are not aligned with their labels.

New description:

 Hello. I have noticed a couple regressions in the admin fieldset css. I
 think they are all related to switching `` to
 flexbox.

 1. input type=text boxes on the right side grow in height if the label
 doesn't fit into 160px.

 [[Image(flexbox-input.png)]]

 2. long labels have uncovered another issue: incorrect line height and a
 forced height in general. After applying the following patch:

 {{{#!diff
 M django/contrib/admin/static/admin/css/forms.css
 @@ -84,14 +84,13 @@ form ul.inline li {
  min-width: 160px;
  width: 160px;
  word-wrap: break-word;
 -line-height: 1;
 +line-height: 1.5;
  }

  .aligned label:not(.vCheckboxLabel):after {
  content: '';
  display: inline-block;
  vertical-align: middle;
 -height: 1.625rem;
  }

  .aligned label + p, .aligned .checkbox-row + div.help, .aligned label +
 div.readonly {
 }}}

 long labels looks more readable:

 [[Image(long-labels-with-patch.png)]]

 3. checkboxes are not aligned with their labels. I don't have a patch for
 this, only 2 screenshots:

 with flexbox:

 [[Image(unaligned-checkbox.png)]]

 without flexbox:

 [[Image(checkbox-wo-flexbox.png)]]

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f12680cac-98b6f8a4-08c7-401f-ab4c-a08667a76925-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-04-24 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+--
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  5.0
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+--
Changes (by minusf):

 * Attachment "checkbox-wo-flexbox.png" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f126074f2-6a079742-fef5-460f-b06d-c7ae9c263149-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-04-24 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+--
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  5.0
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+--
Changes (by minusf):

 * Attachment "unaligned-checkbox.png" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f126066b8-48febbdb-e5f9-4263-a733-729c69b0cc01-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-04-24 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+--
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  5.0
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+--
Changes (by minusf):

 * Attachment "long-labels-with-patch.png" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f126053c9-95db5fc3-05db-4beb-9c4e-7e23c67d37c6-00%40eu-central-1.amazonses.com.


Re: [Django] #35404: Admin fieldset multiple flexbox regressions

2024-04-24 Thread Django
#35404: Admin fieldset multiple flexbox regressions
+--
 Reporter:  minusf  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  5.0
 Severity:  Normal  |   Resolution:
 Keywords:  css admin fieldset  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  1
+--
Changes (by minusf):

 * Attachment "flexbox-input.png" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018f125f67a9-a2889797-ac25-412b-a6ac-b1d4e81fcade-00%40eu-central-1.amazonses.com.