Re: [Django] #35648: SafeString and overriding addition do not work well together

[Django]

#35648: SafeString and overriding addition do not work well together
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Matthias
 |  Kestenholz
 Type:  Bug  |   Status:  closed
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  safestring   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by GitHub ):

 In [changeset:"6f0a4c1f3f015f917feb8b34ae24232d14ced04a" 6f0a4c1]:
 {{{#!CommitTicketReference repository=""
 revision="6f0a4c1f3f015f917feb8b34ae24232d14ced04a"
 Refs #35648 -- Corrected release notes for SafeString.__add__() changes.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107019147f28ed5-465d1d1e-737d-48dd-bbe2-cb0a64d09182-00%40eu-central-1.amazonses.com.

Re: [Django] #35648: SafeString and overriding addition do not work well together

[Django]

#35648: SafeString and overriding addition do not work well together
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Matthias
 |  Kestenholz
 Type:  Bug  |   Status:  closed
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  safestring   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by nessita <124304+nessita@…>):

 * resolution:   => fixed
 * status:  assigned => closed

Comment:

 In [changeset:"d84200e4eb4d20116080130c612ba157a4718977" d84200e4]:
 {{{#!CommitTicketReference repository=""
 revision="d84200e4eb4d20116080130c612ba157a4718977"
 Fixed #35648 -- Raised NotImplementedError in SafeString.__add__ for non-
 string RHS.

 This change ensures SafeString addition operations handle non-string RHS
 properly, allowing them to implement __radd__ for better compatibility.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070191479f5566-82a0338d-e1ff-4d13-8b02-195e16f67234-00%40eu-central-1.amazonses.com.

Re: [Django] #35648: SafeString and overriding addition do not work well together

[Django]

#35648: SafeString and overriding addition do not work well together
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Matthias
 |  Kestenholz
 Type:  Bug  |   Status:  assigned
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  safestring   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by nessita <124304+nessita@…>):

 In [changeset:"b5c048f5ecbf1c718102f19c3018b1fb62d66b3d" b5c048f5]:
 {{{#!CommitTicketReference repository=""
 revision="b5c048f5ecbf1c718102f19c3018b1fb62d66b3d"
 Refs #35648 -- Added test for addition between SafeString and str in
 utils_tests.
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070191479f5518-f908c674-3666-41ec-844e-d3e56ac1bdaa-00%40eu-central-1.amazonses.com.

Re: [Django] #35648: SafeString and overriding addition do not work well together

[Django]

#35648: SafeString and overriding addition do not work well together
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Matthias
 |  Kestenholz
 Type:  Bug  |   Status:  assigned
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  safestring   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * stage:  Accepted => Ready for checkin

Comment:

 Will merge when CI is green.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701914767acec-39731baa-4be0-46eb-8d2a-a2d5aa684c54-00%40eu-central-1.amazonses.com.

Re: [Django] #35648: SafeString and overriding addition do not work well together

[Django]

#35648: SafeString and overriding addition do not work well together
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Matthias
 |  Kestenholz
 Type:  Bug  |   Status:  assigned
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  safestring   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Matthias Kestenholz):

 * needs_better_patch:  1 => 0

Comment:

 I have applied the requested changes (I hope!) so I'm going to unset the
 flag again.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107019137d1ad4f-0656f3bd-0047-4876-a3bc-59dd3263dd20-00%40eu-central-1.amazonses.com.

Re: [Django] #35648: SafeString and overriding addition do not work well together

[Django]

#35648: SafeString and overriding addition do not work well together
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Matthias
 |  Kestenholz
 Type:  Bug  |   Status:  assigned
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  safestring   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * needs_better_patch:  0 => 1

Comment:

 Branch is looking good! I requested a few small tweaks to tests.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107019137a4926f-f82f538c-06c1-406d-bf0f-0e8944970111-00%40eu-central-1.amazonses.com.

Re: [Django] #35648: SafeString and overriding addition do not work well together

[Django]

#35648: SafeString and overriding addition do not work well together
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Matthias
 |  Kestenholz
 Type:  Bug  |   Status:  assigned
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  safestring   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Matthias Kestenholz):

 * needs_better_patch:  1 => 0
 * needs_docs:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701910c93f3a7-209e82a8-8927-4196-9ce8-ce62cdd650b0-00%40eu-central-1.amazonses.com.

Re: [Django] #35648: SafeString and overriding addition do not work well together

[Django]

#35648: SafeString and overriding addition do not work well together
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Matthias
 |  Kestenholz
 Type:  Bug  |   Status:  assigned
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  safestring   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Natalia Bidart):

 Similar-ish to #26287.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701910a679a13-9b9984ab-6381-405a-abb9-897ff3d8b4c5-00%40eu-central-1.amazonses.com.

Re: [Django] #35648: SafeString and overriding addition do not work well together

[Django]

#35648: SafeString and overriding addition do not work well together
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Matthias
 |  Kestenholz
 Type:  Bug  |   Status:  assigned
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  safestring   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701910a5c968c-b92d5f09-6d2b-48e6-b3ef-aab160b36ddc-00%40eu-central-1.amazonses.com.

Re: [Django] #35648: SafeString and overriding addition do not work well together

[Django]

#35648: SafeString and overriding addition do not work well together
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Matthias
 |  Kestenholz
 Type:  Bug  |   Status:  assigned
Component:  Utilities|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:  safestring   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * keywords:   => safestring
 * stage:  Unreviewed => Accepted
 * version:  5.0 => dev

Comment:

 Hello Matthias! Thank you for taking the time to create this ticket and
 the corresponding PR.

 I'm accepting on the basis that I agree with your reasoning that it is
 expected that a `SafeString` instance should work and operate like any
 `str` since
 
[https://docs.djangoproject.com/en/5.0/ref/utils/#django.utils.safestring.SafeString
 the docs] clearly say:

 > A str subclass that has been specifically marked as “safe” (requires no
 further escaping) for HTML output purposes.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701910a4db5a3-eff79879-5c0f-4c07-98ce-38dfe300d1de-00%40eu-central-1.amazonses.com.

Re: [Django] #35648: SafeString and overriding addition do not work well together

[Django]

#35648: SafeString and overriding addition do not work well together
-+-
 Reporter:  Matthias Kestenholz  |Owner:  Matthias
 |  Kestenholz
 Type:  Bug  |   Status:  assigned
Component:  Utilities|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Matthias Kestenholz):

 [https://github.com/django/django/pull/18434 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070191097d3621-d3baf249-0fe5-4875-9264-28b5751a4ca9-00%40eu-central-1.amazonses.com.