Re: [Django] #35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin and StackedInlineAdmin

[Django]

#35650: Multi select checkboxes with shift key is not working in 
TabularInlineAdmin
and StackedInlineAdmin
+--
 Reporter:  tanaydin sirin  |Owner:  tanaydin sirin
 Type:  New feature |   Status:  assigned
Component:  contrib.admin   |  Version:  dev
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Sarah Boyce):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070191a21b17bc-94ca0ac1-4b7e-4e29-abca-9b64ecb3a5db-00%40eu-central-1.amazonses.com.

Re: [Django] #35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin and StackedInlineAdmin

[Django]

#35650: Multi select checkboxes with shift key is not working in 
TabularInlineAdmin
and StackedInlineAdmin
+--
 Reporter:  tanaydin sirin  |Owner:  tanaydin sirin
 Type:  New feature |   Status:  assigned
Component:  contrib.admin   |  Version:  dev
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by tanaydin sirin):

 * needs_better_patch:  1 => 0

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107019186fc4e21-b4eb9ac3-67f9-4e4b-8bc7-0a370b73742c-00%40eu-central-1.amazonses.com.

Re: [Django] #35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin and StackedInlineAdmin

[Django]

#35650: Multi select checkboxes with shift key is not working in 
TabularInlineAdmin
and StackedInlineAdmin
+--
 Reporter:  tanaydin sirin  |Owner:  tanaydin sirin
 Type:  New feature |   Status:  assigned
Component:  contrib.admin   |  Version:  dev
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+--
Comment (by Natalia Bidart):

 Thank you tanaydin sirin! The expected ticket update process is described
 in [https://docs.djangoproject.com/en/dev/internals/contributing/writing-
 code/submitting-patches/#patch-review-checklist these docs]. Basically you
 need to uncheck the "patch needs improvement" flag, and then this ticket
 will show up in the "needs review queue" in the
 [https://dashboard.djangoproject.com Django Development Dashboard].
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107019175320549-e7d3abe4-61e2-44f0-9ec2-41f3afe07df8-00%40eu-central-1.amazonses.com.

Re: [Django] #35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin and StackedInlineAdmin (was: Multi select checkboxes with shift key is not working in TabularInlineAdmi

[Django]

#35650: Multi select checkboxes with shift key is not working in 
TabularInlineAdmin
and StackedInlineAdmin
+--
 Reporter:  tanaydin sirin  |Owner:  tanaydin sirin
 Type:  New feature |   Status:  assigned
Component:  contrib.admin   |  Version:  dev
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+--
Changes (by tanaydin sirin):

 * summary:
 Multi select checkboxes with shift key is not working in
 TabularInlineAdmin
 =>
 Multi select checkboxes with shift key is not working in
 TabularInlineAdmin and StackedInlineAdmin


Old description:

> On any object list, we can select multiple objects by pressing the shift
> key while clicking the second checkbox, but it's not possible with
> TabularInline ModelAdmin.

New description:

 On any object list, we can select multiple objects by pressing the shift
 key while clicking the second checkbox, but it's not possible with
 TabularInline and StackedInlineAdmin ModelAdmin.

--
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701917345b99e-29087bd7-6bbe-4f14-94ae-f921aaee8db4-00%40eu-central-1.amazonses.com.

Re: [Django] #35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin

[Django]

#35650: Multi select checkboxes with shift key is not working in 
TabularInlineAdmin
+--
 Reporter:  tanaydin sirin  |Owner:  tanaydin sirin
 Type:  New feature |   Status:  assigned
Component:  contrib.admin   |  Version:  dev
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+--
Comment (by tanaydin sirin):

 Hello Natalia Bidart, I've made the changes. Shall I do anything else
 about ticket?

 Replying to [comment:3 Natalia Bidart]:
 > Hello tanaydin sirin, thank you for your interest in making Django
 better. I have reproduced the described issue, and I agree it would be
 good to allow for shift-selecting in tabular admins just like in the
 changelist page.
 >
 > I took a quite look at your PR, and I was thinking that instead of
 providing new javascript, we should try to re-use/generalize what the
 changelist page is already using. Could you look into that?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107019172ac1508-12689068-bc75-48e5-b974-129aabe6af9f-00%40eu-central-1.amazonses.com.

Re: [Django] #35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin

[Django]

#35650: Multi select checkboxes with shift key is not working in 
TabularInlineAdmin
+--
 Reporter:  tanaydin sirin  |Owner:  tanaydin sirin
 Type:  New feature |   Status:  assigned
Component:  contrib.admin   |  Version:  dev
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+--
Changes (by Sarah Boyce):

 * owner:  (none) => tanaydin sirin
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701911336014e-74c064e0-4e0b-47cd-b01e-68625dc47f25-00%40eu-central-1.amazonses.com.

Re: [Django] #35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin

[Django]

#35650: Multi select checkboxes with shift key is not working in 
TabularInlineAdmin
+
 Reporter:  tanaydin sirin  |Owner:  (none)
 Type:  New feature |   Status:  new
Component:  contrib.admin   |  Version:  dev
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+
Changes (by Natalia Bidart):

 * needs_better_patch:  0 => 1
 * stage:  Unreviewed => Accepted
 * version:  5.1 => dev

Comment:

 Hello tanaydin sirin, thank you for your interest in making Django better.
 I have reproduced the described issue, and I agree it would be good to
 allow for shift-selecting in tabular admins just like in the changelist
 page.

 I took a quite look at your PR, and I was thinking that instead of
 providing new javascript, we should try to re-use/generalize what the
 changelist page is already using. Could you look into that?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701910f25f31b-d8b9a480-33c1-4f84-a509-ce3ecc9fd4fd-00%40eu-central-1.amazonses.com.

Re: [Django] #35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin

[Django]

#35650: Multi select checkboxes with shift key is not working in 
TabularInlineAdmin
+--
 Reporter:  tanaydin sirin  |Owner:  (none)
 Type:  New feature |   Status:  new
Component:  contrib.admin   |  Version:  5.1
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by tanaydin sirin):

 * version:  5.0 => 5.1

Comment:

 Fix at

 https://github.com/django/django/pull/18438
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701910c67a6a8-5af035bd-da4e-4b94-8d84-8691b5420225-00%40eu-central-1.amazonses.com.

Re: [Django] #35650: Multi select checkboxes with shift key is not working in TabularInlineAdmin

[Django]

#35650: Multi select checkboxes with shift key is not working in 
TabularInlineAdmin
+--
 Reporter:  tanaydin sirin  |Owner:  (none)
 Type:  New feature |   Status:  new
Component:  contrib.admin   |  Version:  5.0
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by tanaydin sirin):

 * has_patch:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701910c2f1aa9-176c0984-e4a2-401b-a052-2876a39e59ed-00%40eu-central-1.amazonses.com.