Re: [Django] #35894: Rename "patch" to "pull request" in the contributor documentation

[Django]

#35894: Rename "patch" to "pull request" in the contributor documentation
-+-
 Reporter:  Baptiste Mispelon|Owner:  Baptiste
 Type:   |  Mispelon
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Claude Paroz):

 I also think that "pull request" is a GitHubism. Not that we should not
 use it, but having "patch" here and there as a more generic term doesn't
 shock me.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/010701930573469f-488b9667-19bb-4f56-9cc5-f64ed85c0130-00%40eu-central-1.amazonses.com.

Re: [Django] #35894: Rename "patch" to "pull request" in the contributor documentation

[Django]

#35894: Rename "patch" to "pull request" in the contributor documentation
-+-
 Reporter:  Baptiste Mispelon|Owner:  Baptiste
 Type:   |  Mispelon
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Tim Graham):

 There were some recent changes along these lines in
 55a2e3136b13d1af95a4129001dac963c26d8415.

 I'd prefer not to rename files and cause external broken links
 ([https://www.w3.org/Provider/Style/URI Cool URIs Don't Change]). (E.g.
 you proposed to rename writing-code/submitting-patches.txt to
 .../writing-code/pull-requests.txt.)

 You also proposed to remove the ".. _patch-review-checklist:" heading
 which I have used extensively in Trac comments as well as on the
 PatchReviewChecklist wiki page (but if the page is renamed the link will
 break anyway).

 It's possible Django will use Git, GitHub, and "pull requests" forever,
 but it might be worth considering if these specific terms should really be
 embedded in URLs.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/010701930403f694-b1ee2234-947d-496a-a162-97dd7151bfac-00%40eu-central-1.amazonses.com.

Re: [Django] #35894: Rename "patch" to "pull request" in the contributor documentation

[Django]

#35894: Rename "patch" to "pull request" in the contributor documentation
-+-
 Reporter:  Baptiste Mispelon|Owner:  Baptiste
 Type:   |  Mispelon
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Baptiste Mispelon):

 I also considered replacing the expression "ready for checkin" with "ready
 for merging" (which has the huge advantage of having the exact same number
 of letters), but that would require a database migration on Trac which
 could be a bit annoying (though not impossible).

 If you think that's worth it I can look into that as well.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/01070193037889ae-287452ce-e5fc-46bf-8be9-79e22152f4f2-00%40eu-central-1.amazonses.com.

Re: [Django] #35894: Rename "patch" to "pull request" in the contributor documentation

[Django]

#35894: Rename "patch" to "pull request" in the contributor documentation
-+-
 Reporter:  Baptiste Mispelon|Owner:  Baptiste
 Type:   |  Mispelon
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Baptiste Mispelon):

 * has_patch:  0 => 1

Comment:

 I've attached a patch for the documentation changes 🙃

 (If you insist, I've also opened a PR:
 https://github.com/django/django/pull/18780)
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/01070193036464d0-8fdaa1c6-79d0-4f15-89ac-ee0d785472dd-00%40eu-central-1.amazonses.com.

Re: [Django] #35894: Rename "patch" to "pull request" in the contributor documentation

[Django]

#35894: Rename "patch" to "pull request" in the contributor documentation
-+-
 Reporter:  Baptiste Mispelon|Owner:  Baptiste
 Type:   |  Mispelon
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:  5.0
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Baptiste Mispelon):

 * Attachment "issue35894.diff" added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019303631746-a73723c8-6a5f-48c2-a770-e60986038f03-00%40eu-central-1.amazonses.com.