subject:"Re\: \[Django\] #35923\: Test settings for running Django tests with PostgreSQL are not present"

Re: [Django] #35923: Test settings for running Django tests with PostgreSQL are not present

2024-11-20 Thread Django

What environment variables are set? DB name/hostname/username/pw/port...
are there any other ones involved?

I think we should check in all of the DB settings files, into `tests`,
without cleaning anything up. Checking in the settings files removes any
doubts about what settings are used in CI. This isn't theoretical, I
spent some time today trying to debug an issue I was seeing locally and
not on CI.

You might not see an upside to doing this, and I understand that this
might generate pressure to "clean up" the settings files. I am proposing
we don't clean them up. But maybe the settings files have trickiness
beyond environment variables, and I'll move on to other things.
--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070193498d82d5-f45dd9de-8db7-4e88-a11d-547375ebdf3e-00%40eu-central-1.amazonses.com.

Re: [Django] #35923: Test settings for running Django tests with PostgreSQL are not present

2024-11-20 Thread Django

#35923: Test settings for running Django tests with PostgreSQL are not present
-+-
 Reporter:  Raphael Gaschignard  |Owner:  (none)
 Type:   |   Status:  closed
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  dev
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Sarah Boyce):

 * resolution:   => wontfix
 * status:  new => closed

Comment:

 We also have django-docker-box for running tests on different databases:
 https://docs.djangoproject.com/en/5.1/internals/contributing/writing-code
 /unit-tests/#running-tests-using-django-docker-box

 I don't think we need to provide more in the Django repo for local test
 setup by default.
 It makes sense to me that SQLite is available by default (easy setup and
 this is all you need for many tickets)
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019349a4776a-9c03a613-d5ee-4054-960d-69074a19bb44-00%40eu-central-1.amazonses.com.

Re: [Django] #35923: Test settings for running Django tests with PostgreSQL are not present

2024-11-20 Thread Django

#35923: Test settings for running Django tests with PostgreSQL are not present
-+-
 Reporter:  Raphael Gaschignard  |Owner:  (none)
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Mariusz Felisiak):

 > I spent some time today trying to debug an issue I was seeing locally
 and not on CI.

 ... and it had nothing to do with settings file.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/010701934995e5c5-fc8f5abc-fbd7-4d28-8774-cc144dd6f3df-00%40eu-central-1.amazonses.com.

Re: [Django] #35923: Test settings for running Django tests with PostgreSQL are not present

2024-11-20 Thread Django

#35923: Test settings for running Django tests with PostgreSQL are not present
-+-
 Reporter:  Raphael Gaschignard  |Owner:  (none)
 Type:   |   Status:  new
  Cleanup/optimization   |
Component:  Uncategorized|  Version:  dev
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * cc: Mariusz Felisiak (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019349750c2a-801501eb-c8d7-46ac-ac44-5b30a6b3a64a-00%40eu-central-1.amazonses.com.

Re: [Django] #35923: Test settings for running Django tests with PostgreSQL are not present

2024-11-20 Thread Django

Even if we will copy `test_postgres.py` to the `tests` directory, Jenkins
will still use a different settings file as it uses some environment
variables to set test database names etc. Moreover it's already
[https://docs.djangoproject.com/en/stable/internals/contributing/writing-
code/unit-tests/#running-unit-tests-settings described in docs] how to
create a `settings` module for other databases. Last but not least, why
for PostgreSQL and not for other supported databases? I don't see much
value in doing this, but I will leave the final decision to someone less
involved in our CI. (I may be biased.)
--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070193496f4788-ef553730-1858-422c-8b25-ff455b1ac45b-00%40eu-central-1.amazonses.com.

Re: [Django] #35923: Test settings for running Django tests with PostgreSQL are not present

Re: [Django] #35923: Test settings for running Django tests with PostgreSQL are not present

Re: [Django] #35923: Test settings for running Django tests with PostgreSQL are not present

Re: [Django] #35923: Test settings for running Django tests with PostgreSQL are not present

Re: [Django] #35923: Test settings for running Django tests with PostgreSQL are not present

5 matches

Site Navigation

Mail list logo

Footer information