Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  Yogya
 |  Chugh
 Type:  Bug  |   Status:  closed
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  querystring  | Triage Stage:
  requestcontext |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * resolution:   => needsinfo
 * status:  assigned => closed

Comment:

 Replying to [comment:20 Yogya Chugh ]:
 > Natalia, any updates on how you’d like to proceed here, given Jake’s
 suggestion?

 No, sorry, at this point I think we should create a post in the forum
 explaining the problem and outlining the options, for the community to
 chime in. Could any of you please do that? In the meantime I'll close as
 `needsinfo` just to ensure the triage stage reflects the current status.
 Please reopen when a clearer approach is clearer. Thank you both!
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019cf721d04d-c4f2e258-dee6-46b3-a9b7-d66a3be243c4-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  Yogya
 |  Chugh
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:
  requestcontext |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Yogya Chugh ):

 Natalia, any updates on how you’d like to proceed here, given Jake’s
 suggestion?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c8a78b8bf-0ece3619-9e50-4867-939c-6b416190eef6-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  Yogya
 |  Chugh
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:
  requestcontext |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jake Howard):

 * stage:  Accepted => Unreviewed

Comment:

 `RequestContext` should by definition always have a request. The
 difference is that now it always adds the request into its context, which
 negates the need for the request context processor entirely. Context
 processors are
 
[https://github.com/django/django/blob/fb3a11071aae27ef869d2b029289b9f59cc41128/django/template/context.py#L263
 run by RequestContext], which means if the context processors run, there
 **will** be a request in context.

 I think the request context processor should be deprecated (with a
 warning, removed in 7.0), and the
 
[https://github.com/django/django/commit/d522b51c401429c169d88742178a9b3777903d9e
 check] implemented as part of #31575 can be removed. I can't think of a
 case where you'd explicitly not want `request` in the context, so
 deprecating it shouldn't be high impact. With that, the
 `test_sidebar_aria_current_page_missing_without_request_context_processor`
 test is no longer necessary.

 Given the scope has changed a fair bit, this probably warrants an
 additional triage before continuing. Natalia, does the new deprecation
 sound sensible? The deprecation //could// be its own ticket, however the
 test would still need to be removed.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c6d7ad403-6dba0c6c-e118-45be-846e-2ee55091d39b-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  Yogya
 |  Chugh
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:  Accepted
  requestcontext |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Yogya Chugh ):

 Replying to [comment:17 Jake Howard]:
 Yes, renaming request to _request attribute in RequestContext and updating
 other references makes sense and it's the next step but my concern is
 querystring.
 Our goal ( in querystring ) is to replace usage like context.request so as
 not to assume it's a RequestContext. And as u mentioned in description,
 I'd suggest that uses of context.request directly be replaced with
 `context["request"]`, and that RequestContext automatically add request to
 its own context if it's not there already.
 The testcase fail I talked in previous comment is due to RequestContext
 adding request to it's own context {{{self.setdefault("request",
 request)}}}.
 Going from request to _request attribute is a name change in multiple
 places and is perfectly fine but request being present in context triggers
 `test_sidebar_aria_current_page_missing_without_request_context_processor`
 because it doesn't expect request being in context when context processor
 is disabled.

 So renaming request to _request **in context** was just a temporary fix to
 this, nothing else.
 What are your thoughts ?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c6d621167-bc758288-6c46-4b1d-acaf-569bf4114a3b-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  Yogya
 |  Chugh
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:  Accepted
  requestcontext |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Jake Howard):

 The `_request` reference is about changing the `RequestContext` class,
 rather than changing anything in the context directly. This should just be
 a case of renaming `RequestContext.request` to `RequestContext._request`,
 and updating any references.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c6ba64a36-65bb33c0-a725-4a88-9538-048d9a194947-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  Yogya
 |  Chugh
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:  Accepted
  requestcontext |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Yogya Chugh ):

 I have replaced the request attribute with `context["request"]` in
 `querystring` and added 3 testcases and updated 1 for checking
 compatibility with `Context` object rather than being specific to
 `RequestContext`.
 But,
 As seen in the PR too, there is 1 testcase failing ( see below ) leading
 to a lot of failed checks. It's main cause is the "request" key added to
 context.
 The test case fails on last line {{{ self.assertContains(response, 'Users' % url) }}} as it returns with an aria-current
 attribute due to the request.

 So should I go forward with setting `context["_request"]` instead as it
 passes all tests but i feel it's temporary ?
 ( About the linter issues, fixed but will be added in next commit )
 {{{
 @override_settings(
 TEMPLATES=[
 {
 "BACKEND":
 "django.template.backends.django.DjangoTemplates",
 "DIRS": [],
 "APP_DIRS": True,
 "OPTIONS": {
 "context_processors": [
 "django.contrib.auth.context_processors.auth",
 "django.contrib.messages.context_processors.messages",
 ],
 },
 }
 ]
 )
 def
 test_sidebar_aria_current_page_missing_without_request_context_processor(self):
 url = reverse("test_with_sidebar:auth_user_changelist")
 response = self.client.get(url)
 self.assertContains(
 response, ''
 )
 # Does not include aria-current attribute.
 self.assertContains(response, 'Users' % url)
 }}}
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c6ba411e4-ece5f08c-6298-4425-94b5-53623aa2634c-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  Yogya
 |  Chugh
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:  Accepted
  requestcontext |
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jake Howard):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c6157aa2b-471422e6-afeb-466d-87cc-e3f041671dd6-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  Yogya
 |  Chugh
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:  Accepted
  requestcontext |
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Yogya Chugh ):

 * has_patch:  0 => 1

Comment:

 [https://github.com/django/django/pull/20710 PR]
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c60f6b685-3149b92f-cf1f-4f2e-a197-725c3ec950ca-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  Yogya
 |  Chugh
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:  Accepted
  requestcontext |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Yogya Chugh ):

 * owner:  (none) => Yogya Chugh

Comment:

 Sure, will get on it today !
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c4fc07a43-89285430-7df8-43c5-b443-8c613f713557-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  (none)
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:  Accepted
  requestcontext |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Jacob Walls):

 Ah, but I just looked and closed that PR, as it wasn't very close at all.
 Feel free to assign yourself after all!
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c4f9dbaad-8518f6e9-699f-4364-be6d-634dd966b889-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  (none)
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:  Accepted
  requestcontext |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Jacob Walls):

 Thanks for your interest, but three days isn't long enough to signal
 inactivity.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c4f98e9e4-e608517b-94e4-4eba-8b94-4510fa4b6a18-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  (none)
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:  Accepted
  requestcontext |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Yogya Chugh ):

 * cc: Yogya Chugh  (added)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c4f8c11f2-a4cc3908-d64b-4054-9ef6-0fb7af7fe8ee-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  (none)
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:  Accepted
  requestcontext |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Comment (by Yogya Chugh ):

 Hi ! I was about to assign it to myself when i noticed a PR from 3 days
 ago. Just curious if it's been worked on cause of the linter issues, or
 can i assign ?
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c4f76290f-f2887518-dc85-4b53-a141-2de30f913ee9-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly in querystring template tag (was: Avoid using context.request directly)

[Django]

#36909: Avoid using context.request directly in querystring template tag
-+-
 Reporter:  Jake Howard  |Owner:  (none)
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:  Accepted
  requestcontext |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * summary:  Avoid using context.request directly => Avoid using
 context.request directly in querystring template tag

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c4e9892dc-c44eb564-1d4d-4be4-85ad-723a108cb8ed-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly

[Django]

#36909: Avoid using context.request directly
-+-
 Reporter:  Jake Howard  |Owner:  (none)
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:  Accepted
  requestcontext |
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * stage:  Unreviewed => Accepted

Comment:

 Thank you Jake, that makes sense!
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c4e982b1d-4590ef71-dcd9-4d6a-8aa7-00702be16a81-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly

[Django]

#36909: Avoid using context.request directly
-+-
 Reporter:  Jake Howard  |Owner:  (none)
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:
  requestcontext |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by jaffar Khan):

 * owner:  jaffar Khan => (none)
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c4db846a5-e5d09e66-d680-4aee-97fb-99850a75fe3b-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly

[Django]

#36909: Avoid using context.request directly
-+-
 Reporter:  Jake Howard  |Owner:  jaffar
 |  Khan
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:  querystring  | Triage Stage:
  requestcontext |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jake Howard):

 * resolution:  needsinfo =>
 * status:  closed => new

Comment:

 My main motivation is exactly that - that there are situations where the
 context in a template is a `Context` instance rather than `RequestContext`
 (unintentionally or otherwise). I think the primary time this comes up is
 when a template is rendered manually, rather than using Django's helpers.
 [https://github.com/wagtail/wagtail/issues/12662 Wagtail] has hit this
 issue in its StreamField, which renders templates directly, rather than as
 part of the final request rendering (ie using `Context` rather than the
 special `RequestContext`).

 Having `querystring` (and other future tags) depend on having a `request`
 in the context makes sense, but assuming it is a `RequestContext` instance
 feels unnecessarily specific, especially since `RequestContext` is
 undocumented.

 Backwards compatibility wise, since `RequestContext` isn't a public API,
 tweaking the `RequestContext.request` behaviour shouldn't be especially
 breaking. Similarly, users of `querystring` won't notice a difference, and
 if anything will see strange incompatibilities resolved.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c44655522-876887e2-a209-40e3-8cc6-d160fcee3cc0-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly

[Django]

#36909: Avoid using context.request directly
-+-
 Reporter:  Jake Howard  |Owner:  jaffar
 |  Khan
 Type:  Bug  |   Status:  closed
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  querystring  | Triage Stage:
  requestcontext |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Natalia Bidart):

 * easy:  1 => 0
 * keywords:   => querystring requestcontext
 * resolution:   => needsinfo
 * status:  assigned => closed

Comment:

 Hey Jake, thank you for the ticket. I think I have suffered from this
 issue when using `querystring` in a base template that is later used for a
 `500.html` template, but I would like to understand your motivation/use
 case (or failing test case?) before accepting the ticket. My main concern
 is the backward incompatibility (and I have also removed the easy picking
 flag because of that).
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c431cbf12-ac7049c1-9fc7-40ed-81f5-e64b4cb04d5c-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly

[Django]

#36909: Avoid using context.request directly
-+---
 Reporter:  Jake Howard  |Owner:  jaffar Khan
 Type:  Bug  |   Status:  assigned
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+---
Changes (by jaffar Khan):

 * owner:  (none) => jaffar Khan
 * status:  new => assigned

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c3c35af41-8193dc22-903a-4420-8c60-18d68279a443-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly

[Django]

#36909: Avoid using context.request directly
-+--
 Reporter:  Jake Howard  |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--
Comment (by Vidhi Singh):

 This seems like a reasonable cleanup to avoid relying on context.request,
 which isn’t always present.
 I’m happy to work on a patch if maintainers agree with the proposed
 direction.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c3c30a333-c434e9b4-4299-475c-9436-72468a0295d2-00%40eu-central-1.amazonses.com.

Re: [Django] #36909: Avoid using context.request directly

[Django]

#36909: Avoid using context.request directly
-+--
 Reporter:  Jake Howard  |Owner:  (none)
 Type:  Bug  |   Status:  new
Component:  Template system  |  Version:  5.1
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--
Changes (by jaffar Khan):

 * cc: jaffar Khan (added)

Comment:

 Like to work on it if accepted.
-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c3ad8268b-e7e6f5e4-1bce-4e1b-894e-e00900d5f807-00%40eu-central-1.amazonses.com.