Re: [PATCH 2/3] dm bufio: remove redundant __GFP_NOWARN

2025-08-11 Thread Qianfeng Rong
在 2025/8/11 23:10, Mikulas Patocka 写道: On Mon, 11 Aug 2025, Qianfeng Rong wrote: 在 2025/8/11 20:44, Mikulas Patocka 写道: Hi I think that GFP_NOWAIT already includes __GFP_NORETRY too. So, should we drop __GFP_NORETRY as well? GFP_NOWAIT does not include __GFP_NORETRY: #define GFP_NOWAIT (_

Re: [PATCH 2/3] dm bufio: remove redundant __GFP_NOWARN

2025-08-11 Thread Mikulas Patocka
On Mon, 11 Aug 2025, Qianfeng Rong wrote: > > 在 2025/8/11 20:44, Mikulas Patocka 写道: > > Hi > > > > I think that GFP_NOWAIT already includes __GFP_NORETRY too. So, should we > > drop __GFP_NORETRY as well? > > GFP_NOWAIT does not include __GFP_NORETRY: > #define GFP_NOWAIT (__GFP_KSWAPD_RECLAI

Re: [PATCH 2/3] dm bufio: remove redundant __GFP_NOWARN

2025-08-11 Thread Qianfeng Rong
在 2025/8/11 20:44, Mikulas Patocka 写道: Hi I think that GFP_NOWAIT already includes __GFP_NORETRY too. So, should we drop __GFP_NORETRY as well? GFP_NOWAIT does not include __GFP_NORETRY: #define GFP_NOWAIT (__GFP_KSWAPD_RECLAIM | __GFP_NOWARN) GFP_NOWAIT tells the memory manager to only wake

Re: [PATCH 2/3] dm bufio: remove redundant __GFP_NOWARN

2025-08-11 Thread Mikulas Patocka
Hi I think that GFP_NOWAIT already includes __GFP_NORETRY too. So, should we drop __GFP_NORETRY as well? Mikulas On Mon, 11 Aug 2025, Qianfeng Rong wrote: > GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant > __GFP_NOWARN. Also update comments to clarify the flag semant

[PATCH 2/3] dm bufio: remove redundant __GFP_NOWARN

2025-08-11 Thread Qianfeng Rong
GFP_NOWAIT already includes __GFP_NOWARN, so let's remove the redundant __GFP_NOWARN. Also update comments to clarify the flag semantics. Signed-off-by: Qianfeng Rong --- drivers/md/dm-bufio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/md/dm-bufio.c b

[PATCH 0/3] md: remove redundant __GFP_NOWARN

2025-08-11 Thread Qianfeng Rong
Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT") made GFP_NOWAIT implicitly include __GFP_NOWARN. Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT (e.g., `GFP_NOWAIT | __GFP_NOWARN`) is now redundant. Let's clean up these redundant flags across subsystems. No functional c

Re: [PATCH] docs: device-mapper :Fix typos in delay.rst and vdo-design.rst

2025-08-11 Thread Mikulas Patocka
Applied, thanks. Mikulas On Sun, 10 Aug 2025, Shubham Sharma wrote: > Fixed the following typos in device-mapper documentation: > - explicitely -> explicitly > - approriate -> appropriate > > Signed-off-by: Shubham Sharma > --- > Documentation/admin-guide/device-mapper/delay.rst | 2 +-

Re: [PATCH] dm: Use vmalloc_array to simplify code

2025-08-11 Thread Mikulas Patocka
Applied.thanks. Mikulas On Tue, 5 Aug 2025, Qianfeng Rong wrote: > Remove array_size() calls and replace vmalloc() with > vmalloc_array() to simplify the code. > > Signed-off-by: Qianfeng Rong > --- > drivers/md/dm-cache-policy-smq.c | 2 +- > drivers/md/dm-region-hash.c | 2 +- > driv

Re: [PATCH] dm: ima: more strlen() drops

2025-08-11 Thread Mikulas Patocka
Applied, thanks. (I also removed the "gfp_t flags" argument because its always GFP_KERNEL. Mikulas On Tue, 5 Aug 2025, Dmitry Antipov wrote: > Following commit ebbd17695e9e ("dm: ima: avoid extra calls to > strlen()"), convert 'dm_ima_alloc_and_copy_capacity_str()' to > return the number of c