Re: [PATCH 7/8] dm-crypt: Convert from tasklet to BH workqueue

2024-01-31 Thread Mikulas Patocka
This seems OK. Reviewed-by: Mikulas Patocka On Mon, 29 Jan 2024, Tejun Heo wrote: > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue support was recently added. A

Re: [PATCH 7/8] dm-crypt: Convert from tasklet to BH workqueue

2024-01-30 Thread Tejun Heo
Hello, On Tue, Jan 30, 2024 at 11:46:45AM +0100, Sebastian Andrzej Siewior wrote: > On 2024-01-29 23:11:54 [-1000], Tejun Heo wrote: > > if (in_hardirq() || irqs_disabled()) { > > - io->in_tasklet = true; > > - tasklet_init(&io->tasklet, kcryptd_cryp

Re: [PATCH 7/8] dm-crypt: Convert from tasklet to BH workqueue

2024-01-30 Thread Sebastian Andrzej Siewior
On 2024-01-29 23:11:54 [-1000], Tejun Heo wrote: > --- a/drivers/md/dm-crypt.c > +++ b/drivers/md/dm-crypt.c > @@ -2263,9 +2232,8 @@ static void kcryptd_queue_crypt(struct dm_crypt_io *io) /* * in_hardirq(): Crypto API's skcipher_walk_first() refuses to work in ha

[PATCH 7/8] dm-crypt: Convert from tasklet to BH workqueue

2024-01-30 Thread Tejun Heo
The only generic interface to execute asynchronously in the BH context is tasklet; however, it's marked deprecated and has some design flaws. To replace tasklets, BH workqueue support was recently added. A BH workqueue behaves similarly to regular workqueues except that the queued work items are ex