Re: Change in reported values of some block integrity sysfs attributes

2025-02-24 Thread Martin K. Petersen
Anuj, > diff --git a/drivers/scsi/sd_dif.c b/drivers/scsi/sd_dif.c > index ae6ce6f5d622..be2cd06f500b 100644 > --- a/drivers/scsi/sd_dif.c > +++ b/drivers/scsi/sd_dif.c > @@ -40,8 +40,10 @@ void sd_dif_config_host(struct scsi_disk *sdkp, struct > queue_limits *lim) > dif = 0; dix

Re: Change in reported values of some block integrity sysfs attributes

2025-02-21 Thread Anuj Gupta
On Fri, Feb 21, 2025 at 04:07:55PM +0530, Anuj gupta wrote: > > I don't see any change in what's reported with block/for-next in a > > regular SCSI HBA/disk setup. Will have to look at whether there is a > > stacking issue wrt. multipathing. > > Hi Martin, Christoph, > > It seems this change in b

Re: Change in reported values of some block integrity sysfs attributes

2025-02-21 Thread Anuj Gupta
On Fri, Feb 21, 2025 at 04:07:55PM +0530, Anuj gupta wrote: > > I don't see any change in what's reported with block/for-next in a > > regular SCSI HBA/disk setup. Will have to look at whether there is a > > stacking issue wrt. multipathing. > > Hi Martin, Christoph, > > It seems this change in b

Re: Change in reported values of some block integrity sysfs attributes

2025-02-21 Thread Anuj gupta
> I don't see any change in what's reported with block/for-next in a > regular SCSI HBA/disk setup. Will have to look at whether there is a > stacking issue wrt. multipathing. Hi Martin, Christoph, It seems this change in behaviour is not limited to SCSI only. As Nikhil mentioned an earlier commi

Re: Change in reported values of some block integrity sysfs attributes

2025-02-20 Thread M Nikhil
gentle ping!!! Hopefully I haven't missed anything. I was wondering if you could find out something and if I can provide more information.

Re: Change in reported values of some block integrity sysfs attributes

2024-12-17 Thread M Nikhil
Hi Christoph, We did not modify 'device_is_integrity_capable' attribute. On 13/12/24 8:03 pm, Christoph Hellwig wrote: Hi M, On Fri, Dec 13, 2024 at 12:46:14PM +0530, M Nikhil wrote: Hi Everyone, * We have observed change in the values of some of the block integrity sysfs attributes fo

Re: Change in reported values of some block integrity sysfs attributes

2024-12-17 Thread M Nikhil
Thanks for the inputs Martin. We have observed that even though the HBA does not support DIX Type, still the integrity attributes 'write_generate' and 'read_verify' are set to 1 for the block devices. a3560030:~ # cat /sys/class/scsi_host/host0/prot_capabilities 0 a3560030:~ # cat /sys/class

Re: Change in reported values of some block integrity sysfs attributes

2024-12-13 Thread Martin K. Petersen
> The sysfs attributes related to block device integrity , > write_generate and read_verify are enabled for the block device when > the parameter device_is_integrity_capable is disabled. 'device_is_integrity_capable' is set if storage device (media) is formatted with PI. That is completely orth

Re: Change in reported values of some block integrity sysfs attributes

2024-12-13 Thread Christoph Hellwig
Hi M, On Fri, Dec 13, 2024 at 12:46:14PM +0530, M Nikhil wrote: > Hi Everyone, > > * We have observed change in the values of some of the block integrity >sysfs attributes for the block devices on the master branch. The >sysfs attributes related to block device integrity , write_generate

Change in reported values of some block integrity sysfs attributes

2024-12-12 Thread M Nikhil
Hi Everyone, * We have observed change in the values of some of the block integrity sysfs attributes for the block devices on the master branch. The sysfs attributes related to block device integrity , write_generate and read_verify areĀ  enabled for the block device when the parameter